You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "eladkal (via GitHub)" <gi...@apache.org> on 2025/01/15 15:26:08 UTC

Re: [PR] Fix escaping of special characters or reserved words as column names in dialects of common sql provider [airflow]

eladkal commented on PR #45640:
URL: https://github.com/apache/airflow/pull/45640#issuecomment-2593195914

   > @eladkal Would it hurt if some methods in Dialects are being renamed? I don't think it's actually used yet by any released provider right?
   > 
   > I'm thinking of renaming following 2 methods:
   > 
   > escape_colmun_name -> escape_word remove_quotes -> unescape_word
   
   Dialects were not yet released so you can introduce changes. Once I cut a release you won't be able to introduce breaking changes without doing a major release 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org