[jira] [Commented] (JCRVLT-59) Reimporting an Archive does not delete missing nodes

["Mathijs den Burger (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCRVLT-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170772#comment-14170772 ] 

Mathijs den Burger commented on JCRVLT-59:
------------------------------------------

Thanks for looking into this issue. I re-tried the tmp-less.zip file on my Ubuntu 14.04 laptop, opened it with file-roller, and believe it or not: file-roller did not show the folder /tmp/foo/bar/tobi ! ([~adouma] is my witness :). So there's the source of some confusion. But good to have the additional unit test in.

> Reimporting an Archive does not delete missing nodes
> ----------------------------------------------------
>
>                 Key: JCRVLT-59
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-59
>             Project: Jackrabbit FileVault
>          Issue Type: Bug
>    Affects Versions: 3.1.6
>            Reporter: Mathijs den Burger
>             Fix For: 3.1.6
>
>         Attachments: test-reimport-less.patch, tmp-less.zip
>
>
> Reimporting an Archive at the same location with less content than before does not delete the nodes that are no longer part of the archive. 
> The attached unit test demonstrates the broken behavior. The attached tmp-less.zip file used by the test is a copy of 'testpackages/tmp.zip', but without the directory /tmp/foo/bar/tobi. The last assert in the added unit test fails: /tmp/foo/bar/tobi still exists after importing
> an archive that no longer contains it.
> Steps to reproduce:
> 1. apply the patch against jackrabbit-filevault 3.1.6
> 2. put the attached tmp-less.zip file in vault-core/src/test/resources/org/apache/jackrabbit/vault/packaging/integration/testpackages/tmp-less.zip
> 3. run the added unit test org.apache.jackrabbit.vault.packaging.integration.ImportTests#testReimportLess
> Expected: the unit test passes; since the reimported archive tmp-less.zip no longer contains /tmp/foo/bar/tobi, the associated JCR node should have been removed too after the import.
> Actual: the unit test fails since the node /tmp/foo/bar/tobi is not deleted by the reimport.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)