You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by mhfrantz <gi...@git.apache.org> on 2015/10/04 00:42:00 UTC
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-850: Reduce Graph.add...
GitHub user mhfrantz opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/101
TINKERPOP3-850: Reduce Graph.addVertex overload ambiguity
Since this is a breaking change for vendors, do we want to merge this into tp30 or master?
Also, how can we verify that it addresses the initial problem with Scala and overloading?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RedSeal-co/incubator-tinkerpop chore/TINKERPOP3-850-Reduce-Graph-addVertex-overload-ambiguity_104440766
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/101.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #101
----
commit d36651e879f11d3b519661fe36b732146a2ae5e2
Author: mhfrantz <mf...@redsealnetworks.com>
Date: 2015-10-03T18:55:24Z
GraphTest: Declare FEATURE_STRING_VALUES where it had been implicitly required
commit 9a05f07e4421d21bd4d135a5fc3f13405baf8890
Author: mhfrantz <mf...@redsealnetworks.com>
Date: 2015-10-03T19:00:52Z
GraphTest: Rename addVertex test to better reflect the desired behavior
commit 31918fac363e007c4804241f0c534a9356817208
Author: mhfrantz <mf...@redsealnetworks.com>
Date: 2015-10-03T19:25:00Z
GraphTest: Add more tests for various addVertex use cases
commit 3e494ee3dbc7bd009589b59e7044e390a0fa394a
Author: mhfrantz <mf...@redsealnetworks.com>
Date: 2015-10-03T22:37:46Z
TINKERPOP3-867: TinkerGraphProvider.getBaseConfiguration creates temp dir as needed for persistence testing
commit dd13d1a5f2c6aaa31ec72805c3fe114875622fdc
Author: mhfrantz <mf...@redsealnetworks.com>
Date: 2015-10-03T22:38:53Z
TINKERPOP3-850: Reduce Graph.addVertex overload ambiguity
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-850: Reduce Graph.add...
Posted by mhfrantz <gi...@git.apache.org>.
Github user mhfrantz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/101#issuecomment-145930855
Replaced by #102 on master, since breaking changes should not go into 3.0.2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-850: Reduce Graph.add...
Posted by mhfrantz <gi...@git.apache.org>.
Github user mhfrantz closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/101
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---