You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Josh Rosen (JIRA)" <ji...@apache.org> on 2015/02/28 06:27:04 UTC

[jira] [Commented] (SPARK-6075) Flaky AccumulatorSuite.add value to collection accumulators test

    [ https://issues.apache.org/jira/browse/SPARK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14341353#comment-14341353 ] 

Josh Rosen commented on SPARK-6075:
-----------------------------------

I left some notes on the PR that might have introduced the bug: https://github.com/apache/spark/pull/4021#issuecomment-76511660

{quote}
I'm still trying to see if I can spot the problem, but my hunch is that maybe the localAccums thread-local maps should not hold weak references. When deserializing an accumulator in an executor and registering it with localAccums, is there ever a moment in which the accumulator has no strong references pointing to it? Does someone object hold a strong reference to an accumulator while it's being deserialized? If not, this could lead to it being dropped from the localAccums map, causing that task's accumulator updates to be lost.

{quote}

> Flaky AccumulatorSuite.add value to collection accumulators test
> ----------------------------------------------------------------
>
>                 Key: SPARK-6075
>                 URL: https://issues.apache.org/jira/browse/SPARK-6075
>             Project: Spark
>          Issue Type: Bug
>          Components: Spark Core, Tests
>    Affects Versions: 1.4.0
>            Reporter: Josh Rosen
>              Labels: flaky-test
>
> It looks like some of the AccumulatorSuite tests have started failing nondeterministically on Jenkins.  The errors seem to be due to lost / missing accumulator updates, e.g.
> {code}
> Set(843, 356, 437, [...], 181, 618, 131) did not contain element 901
> {code}
> This could somehow be related to SPARK-3885 / https://github.com/apache/spark/pull/4021, a patch to garbage-collect accumulators, which was only merged into master.
> https://amplab.cs.berkeley.edu/jenkins/view/Spark/job/Spark-Master-SBT/lastCompletedBuild/AMPLAB_JENKINS_BUILD_PROFILE=hadoop2.0,label=centos/testReport/org.apache.spark/AccumulatorSuite/add_value_to_collection_accumulators/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org