[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #7134: feat: add sqllogictests crate

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #7134:
URL: https://github.com/apache/arrow-datafusion/pull/7134#discussion_r1281126767


##########
datafusion/sqllogictest/src/engines/datafusion_engine/mod.rs:
##########
@@ -0,0 +1,7 @@
+mod error;

Review Comment:
   I think this file needs the apache license header (just copy/paste from another crate)
   
   Also if you could add some high level crate comment like 
   
   ```
   /// DataFusion driver for sqllogictest
   ```
   
   or something I think that would help future readers



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org