[jira] [Comment Edited] (HBASE-10366) 0.94 filterRow() may be skipped in 0.96(or onwards) code

["Andrew Purtell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-10366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13874296#comment-13874296 ] 

Andrew Purtell edited comment on HBASE-10366 at 1/17/14 1:44 AM:
-----------------------------------------------------------------

Thanks, +1 for trunk and 0.98 with a unit test. Edit: Actually without one too, but thanks in advance for one. :-)


was (Author: apurtell):
Thanks, +1 for trunk and 0.98 with a unit test.

> 0.94 filterRow() may be skipped in 0.96(or onwards) code
> --------------------------------------------------------
>
>                 Key: HBASE-10366
>                 URL: https://issues.apache.org/jira/browse/HBASE-10366
>             Project: HBase
>          Issue Type: Bug
>          Components: Filters
>            Reporter: Jeffrey Zhong
>            Assignee: Jeffrey Zhong
>            Priority: Critical
>             Fix For: 0.98.0, 0.96.2
>
>         Attachments: hbase-10366.patch
>
>
> HBASE-6429 combines both filterRow & filterRow(List<KeyValue> kvs) functions in Filter. 
> While 0.94 code or older, it may not implement hasFilterRow as HBase-6429 expected because 0.94(old) hasFilterRow only returns true when filterRow(List<KeyValue> kvs) is overridden not the filterRow(). Therefore, the filterRow() will be skipped.
> Since we don't ask 0.94 users to update their existing filter code, the issue will cause scan returns unexpected keyvalues and break the backward compatibility.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)