You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "soumyakanti3578 (via GitHub)" <gi...@apache.org> on 2024/06/07 23:16:54 UTC
[PR] HIVE-28314: Support literals as filter expression with non-boolean re… [hive]
soumyakanti3578 opened a new pull request, #5291:
URL: https://github.com/apache/hive/pull/5291
…turn type
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Cast literals of filter expression with boolean for queries like `select * from t1 where 'foo'`, so that they can be compiled with CBO.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Refer to https://issues.apache.org/jira/browse/HIVE-27831
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### Is the change a dependency upgrade?
<!--
If yes, please attach a file with output from mvn dependency:tree to validate a complete upgrade of dependency.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
`mvn test -pl itests/qtest -Pitests -Dtest=TestMiniLlapLocalCliDriver -Dtest.output.overwrite=true -Dqfile="annotate_stats_filter.q"`
`mvn test -pl itests/qtest-iceberg -Piceberg -Pitests -Dtest=TestIcebergLlapLocalCliDriver -Dqfile=delete_iceberg_mixed.q`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28314: Support literals as filter expression with non-boolean re… [hive]
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on code in PR #5291:
URL: https://github.com/apache/hive/pull/5291#discussion_r1651017360
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java:
##########
@@ -3199,18 +3199,13 @@ private RelNode genFilterRelNode(ASTNode filterNode, RelNode srcRel,
}
private RelNode genFilterRelNode(RexNode filterExpression, RelNode srcRel,
- ImmutableMap<String, Integer> outerNameToPosMap, RowResolver outerRR) throws SemanticException {
+ ImmutableMap<String, Integer> outerNameToPosMap, RowResolver outerRR) {
if (RexUtil.isLiteral(filterExpression, false)
&& filterExpression.getType().getSqlTypeName() != SqlTypeName.BOOLEAN) {
Review Comment:
Thanks for the clarification.
Can you please check if we support other non-boolean expressions in the WHERE clause. For instance:
```sql
WHERE t.stringColumn
WHERE t.intColumn
WHERE t.dateColumn
WHERE 'foo' || 'bar'
```
I would like to understand if both conditions of the `if` clause are necessary. In other words if we are about to introduce a `CAST` to `BOOLEAN` do we really care if the `filterExpression` is a literal?
##########
ql/src/test/queries/clientpositive/filter_literals.q:
##########
@@ -0,0 +1,25 @@
+
Review Comment:
Can you also check that the semantics of non-boolean expressions in the `WHERE` clause are the same with and without CBO and add tests if necessary. This is to ensure that we are not introducing behavior changes by allowing this kind of queries to use CBO.
For instance are the following queries return the same results with and without CBO?
```sql
WHERE 'foo';WHERE 'true';WHERE 'false';
WHERE 1;WHERE 0;WHERE -1;
WHERE null;
```
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java:
##########
@@ -3199,18 +3199,13 @@ private RelNode genFilterRelNode(ASTNode filterNode, RelNode srcRel,
}
private RelNode genFilterRelNode(RexNode filterExpression, RelNode srcRel,
- ImmutableMap<String, Integer> outerNameToPosMap, RowResolver outerRR) throws SemanticException {
+ ImmutableMap<String, Integer> outerNameToPosMap, RowResolver outerRR) {
if (RexUtil.isLiteral(filterExpression, false)
&& filterExpression.getType().getSqlTypeName() != SqlTypeName.BOOLEAN) {
- // queries like select * from t1 where 'foo';
- // Calcite's rule PushFilterThroughProject chokes on it. Arguably, we
- // can insert a cast to
- // boolean in such cases, but since Postgres, Oracle and MS SQL server
- // fail on compile time
- // for such queries, its an arcane corner case, not worth of adding that
- // complexity.
- throw new CalciteSemanticException("Filter expression with non-boolean return type.",
- UnsupportedFeature.Filter_expression_with_non_boolean_return_type);
+ // Cast filterExpression of queries like select * from t1 where 'foo'
+ RelDataType booleanType = srcRel.getCluster().getTypeFactory().createSqlType(SqlTypeName.BOOLEAN);
+ filterExpression = srcRel.getCluster().getRexBuilder()
+ .makeCast(booleanType, filterExpression);
Review Comment:
Thanks for the explanation. Let's do the CAST here then.
Indeed skipping the CAST is an optimization and we don't need to do it now/here. Let's ignore this point for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28314: Support literals as filter expression with non-boolean re… [hive]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #5291:
URL: https://github.com/apache/hive/pull/5291#issuecomment-2223679192
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5291) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5291&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5291&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=5291&resolved=false&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5291&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5291&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5291)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28314: Support literals as filter expression with non-boolean re… [hive]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #5291:
URL: https://github.com/apache/hive/pull/5291#issuecomment-2177143880
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5291) **Quality Gate passed**
Issues
 [6 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5291&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5291&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=5291&resolved=false&sinceLeakPeriod=true)
 No data about Coverage
 No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5291)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28314: Support literals as filter expression with non-boolean re… [hive]
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on code in PR #5291:
URL: https://github.com/apache/hive/pull/5291#discussion_r1644104871
##########
iceberg/iceberg-handler/src/test/queries/positive/delete_iceberg_mixed.q:
##########
@@ -6,6 +6,8 @@
--! qt:replace:/("removed-files-size":")\d+/$1#FileSize#/
-- create an unpartitioned table with skip delete data set to false
+set hive.cbo.fallback.strategy=NEVER;
Review Comment:
How are the changes related to this test?
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java:
##########
@@ -3199,18 +3199,13 @@ private RelNode genFilterRelNode(ASTNode filterNode, RelNode srcRel,
}
private RelNode genFilterRelNode(RexNode filterExpression, RelNode srcRel,
- ImmutableMap<String, Integer> outerNameToPosMap, RowResolver outerRR) throws SemanticException {
+ ImmutableMap<String, Integer> outerNameToPosMap, RowResolver outerRR) {
if (RexUtil.isLiteral(filterExpression, false)
&& filterExpression.getType().getSqlTypeName() != SqlTypeName.BOOLEAN) {
- // queries like select * from t1 where 'foo';
- // Calcite's rule PushFilterThroughProject chokes on it. Arguably, we
- // can insert a cast to
- // boolean in such cases, but since Postgres, Oracle and MS SQL server
- // fail on compile time
- // for such queries, its an arcane corner case, not worth of adding that
- // complexity.
- throw new CalciteSemanticException("Filter expression with non-boolean return type.",
- UnsupportedFeature.Filter_expression_with_non_boolean_return_type);
+ // Cast filterExpression of queries like select * from t1 where 'foo'
+ RelDataType booleanType = srcRel.getCluster().getTypeFactory().createSqlType(SqlTypeName.BOOLEAN);
+ filterExpression = srcRel.getCluster().getRexBuilder()
+ .makeCast(booleanType, filterExpression);
Review Comment:
Why are we doing the CAST at this stage? It seems more natural to do it during the conversion from AST to Rex during the construction of the `filterExpression`.
Moreover, I think we can skip the CAST altogether. If we have a string literal then in the context of a boolean expression this can be either true or false so we can create the respective boolean literal directly.
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java:
##########
@@ -3199,18 +3199,13 @@ private RelNode genFilterRelNode(ASTNode filterNode, RelNode srcRel,
}
private RelNode genFilterRelNode(RexNode filterExpression, RelNode srcRel,
- ImmutableMap<String, Integer> outerNameToPosMap, RowResolver outerRR) throws SemanticException {
+ ImmutableMap<String, Integer> outerNameToPosMap, RowResolver outerRR) {
if (RexUtil.isLiteral(filterExpression, false)
&& filterExpression.getType().getSqlTypeName() != SqlTypeName.BOOLEAN) {
Review Comment:
Do we support in Hive queries combining string literals with boolean expressions (e.g., `WHERE 'foo' AND 'bar'`)?
If yes then the if statement here is not sufficient to cover those cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28314: Support literals as filter expression with non-boolean re… [hive]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #5291:
URL: https://github.com/apache/hive/pull/5291#issuecomment-2155720925
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5291) **Quality Gate passed**
Issues
 [6 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5291&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5291&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=5291&resolved=false&sinceLeakPeriod=true)
 No data about Coverage
 No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5291)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28314: Support literals as filter expression with non-boolean re… [hive]
Posted by "soumyakanti3578 (via GitHub)" <gi...@apache.org>.
soumyakanti3578 commented on code in PR #5291:
URL: https://github.com/apache/hive/pull/5291#discussion_r1645057190
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java:
##########
@@ -3199,18 +3199,13 @@ private RelNode genFilterRelNode(ASTNode filterNode, RelNode srcRel,
}
private RelNode genFilterRelNode(RexNode filterExpression, RelNode srcRel,
- ImmutableMap<String, Integer> outerNameToPosMap, RowResolver outerRR) throws SemanticException {
+ ImmutableMap<String, Integer> outerNameToPosMap, RowResolver outerRR) {
if (RexUtil.isLiteral(filterExpression, false)
&& filterExpression.getType().getSqlTypeName() != SqlTypeName.BOOLEAN) {
- // queries like select * from t1 where 'foo';
- // Calcite's rule PushFilterThroughProject chokes on it. Arguably, we
- // can insert a cast to
- // boolean in such cases, but since Postgres, Oracle and MS SQL server
- // fail on compile time
- // for such queries, its an arcane corner case, not worth of adding that
- // complexity.
- throw new CalciteSemanticException("Filter expression with non-boolean return type.",
- UnsupportedFeature.Filter_expression_with_non_boolean_return_type);
+ // Cast filterExpression of queries like select * from t1 where 'foo'
+ RelDataType booleanType = srcRel.getCluster().getTypeFactory().createSqlType(SqlTypeName.BOOLEAN);
+ filterExpression = srcRel.getCluster().getRexBuilder()
+ .makeCast(booleanType, filterExpression);
Review Comment:
Unfortunately, when we are converting the string ASTNode `foo`, we don't have the context that it is part of a filter expression, i.e., `StrExprProcessor` doesn't know if `foo` is part of `a IN ('foo', 'bar')` or `WHERE 'foo'`. Maybe we can create a new child class of `TypeCheckCtx` to handle this, I will have to look into it.
But I think since more complex expressions containing literals are getting handled correctly (as explained in another comment), and we only need to check for the `WHERE 'foo'` case here, I guess this is probably a good place for the check.
Regarding the second part of your comment, that is a good idea but maybe out of scope of this PR, and it may change a lot of other plans (from CAST(...) to true/false). But I will look into it if you want me to - either in this PR or another :)
I have also added `filter_literals.q` and `filter_literals.q.out` containing some more tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28314: Support literals as filter expression with non-boolean re… [hive]
Posted by "soumyakanti3578 (via GitHub)" <gi...@apache.org>.
soumyakanti3578 commented on code in PR #5291:
URL: https://github.com/apache/hive/pull/5291#discussion_r1644793716
##########
iceberg/iceberg-handler/src/test/queries/positive/delete_iceberg_mixed.q:
##########
@@ -6,6 +6,8 @@
--! qt:replace:/("removed-files-size":")\d+/$1#FileSize#/
-- create an unpartitioned table with skip delete data set to false
+set hive.cbo.fallback.strategy=NEVER;
Review Comment:
This test falls back to non-cbo path due to `where null`:
```
[2024-06-06T22:35:22.382Z] delete from ice01 where null
[2024-06-06T22:35:22.382Z] fname=delete_iceberg_mixed.q
[2024-06-06T22:35:22.382Z]
[2024-06-06T22:35:22.382Z] See ./ql/target/tmp/log/hive.log or ./itests/qtest/target/tmp/log/hive.log, or check ./ql/target/surefire-reports or ./itests/qtest/target/surefire-reports/ for specific test cases logs.
[2024-06-06T22:35:22.382Z] org.apache.hadoop.hive.ql.optimizer.calcite.CalciteSemanticException: Filter expression with non-boolean return type.
[2024-06-06T22:35:22.382Z] at org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genFilterRelNode(CalcitePlanner.java:3212)
[2024-06-06T22:35:22.382Z] at org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genFilterRelNode(CalcitePlanner.java:3198)
[2024-06-06T22:35:22.382Z] at org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genFilterRelNode(CalcitePlanner.java:3395)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28314: Support literals as filter expression with non-boolean re… [hive]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #5291:
URL: https://github.com/apache/hive/pull/5291#issuecomment-2221339989
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5291) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5291&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5291&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=5291&resolved=false&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5291&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5291&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5291)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28314: Support literals as filter expression with non-boolean re… [hive]
Posted by "soumyakanti3578 (via GitHub)" <gi...@apache.org>.
soumyakanti3578 commented on code in PR #5291:
URL: https://github.com/apache/hive/pull/5291#discussion_r1674831578
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java:
##########
@@ -3199,18 +3199,13 @@ private RelNode genFilterRelNode(ASTNode filterNode, RelNode srcRel,
}
private RelNode genFilterRelNode(RexNode filterExpression, RelNode srcRel,
- ImmutableMap<String, Integer> outerNameToPosMap, RowResolver outerRR) throws SemanticException {
+ ImmutableMap<String, Integer> outerNameToPosMap, RowResolver outerRR) {
if (RexUtil.isLiteral(filterExpression, false)
&& filterExpression.getType().getSqlTypeName() != SqlTypeName.BOOLEAN) {
Review Comment:
Removed the `isLiteral` check, which caused some changes to `vector_empty_where.q.out` - as seen in the latest commit.
I think the predicate changes make sense - kind of, but let me know what you think about them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28314: Support literals as filter expression with non-boolean re… [hive]
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on code in PR #5291:
URL: https://github.com/apache/hive/pull/5291#discussion_r1679183742
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java:
##########
@@ -3199,18 +3199,13 @@ private RelNode genFilterRelNode(ASTNode filterNode, RelNode srcRel,
}
private RelNode genFilterRelNode(RexNode filterExpression, RelNode srcRel,
- ImmutableMap<String, Integer> outerNameToPosMap, RowResolver outerRR) throws SemanticException {
+ ImmutableMap<String, Integer> outerNameToPosMap, RowResolver outerRR) {
if (RexUtil.isLiteral(filterExpression, false)
&& filterExpression.getType().getSqlTypeName() != SqlTypeName.BOOLEAN) {
Review Comment:
The changes do seem like an improvement so we are good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28314: Support literals as filter expression with non-boolean re… [hive]
Posted by "soumyakanti3578 (via GitHub)" <gi...@apache.org>.
soumyakanti3578 commented on code in PR #5291:
URL: https://github.com/apache/hive/pull/5291#discussion_r1645045838
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java:
##########
@@ -3199,18 +3199,13 @@ private RelNode genFilterRelNode(ASTNode filterNode, RelNode srcRel,
}
private RelNode genFilterRelNode(RexNode filterExpression, RelNode srcRel,
- ImmutableMap<String, Integer> outerNameToPosMap, RowResolver outerRR) throws SemanticException {
+ ImmutableMap<String, Integer> outerNameToPosMap, RowResolver outerRR) {
if (RexUtil.isLiteral(filterExpression, false)
&& filterExpression.getType().getSqlTypeName() != SqlTypeName.BOOLEAN) {
Review Comment:
`WHERE 'foo' and 'bar'` is already supported through CBO because it goes through `TypeCheckProcFactory.DefaultExprProcessor#process()` as it tries to generate for the `and` tree. Because `and`'s children should be of type `boolean`, they get cast appropriately.
Whereas, when we only have `WHERE 'foo'`, it goes through `TypeCheckProcFactory.StrExprProcessor#process()`, which just returns the string back, without adding a cast.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28314: Support literals as filter expression with non-boolean re… [hive]
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak closed pull request #5291: HIVE-28314: Support literals as filter expression with non-boolean re…
URL: https://github.com/apache/hive/pull/5291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28314: Support literals as filter expression with non-boolean re… [hive]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #5291:
URL: https://github.com/apache/hive/pull/5291#issuecomment-2155808516
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5291) **Quality Gate passed**
Issues
 [6 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5291&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5291&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=5291&resolved=false&sinceLeakPeriod=true)
 No data about Coverage
 No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5291)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org