You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Michal Durdina (JIRA)" <de...@myfaces.apache.org> on 2007/06/21 15:27:45 UTC
[jira] Created: (MYFACES-1668) Fix for Websphere 5.1
Fix for Websphere 5.1
---------------------
Key: MYFACES-1668
URL: https://issues.apache.org/jira/browse/MYFACES-1668
Project: MyFaces Core
Issue Type: Bug
Components: General
Affects Versions: 1.1.5
Environment: Tested with IBM WebSphere Application Server 5.1.1.14 running on IBM JDK 1.4.2 (enclose in WAS) on Windows XP
Reporter: Michal Durdina
Priority: Minor
Fix for Websphere 5.1. since WAS uses protocol wsjar: for accessing jar content instead of regular protocol jar:
This affects FacesConfigurator which does not correctly detect jars on classpath. FacesConfigurator indirectly uses Enumeration resources = ClassLoader.getResources(resource); to detect libraries on classpath and check if they start with prefix jar: what is obviously not true for IBM Websphere :(
ie. WAS returns wsjar:file:mypath/myjar.jar!xyz where Tomcat returns jar:file:mypath/myjar.jar!xyz
Patch is provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1668) Fix for Websphere 5.1
Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506900 ]
Matthias Weßendorf commented on MYFACES-1668:
---------------------------------------------
what's wrong with endsWith("jar:") instead of adding ajar: bjar: cjar: ...
> Fix for Websphere 5.1
> ---------------------
>
> Key: MYFACES-1668
> URL: https://issues.apache.org/jira/browse/MYFACES-1668
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
> Affects Versions: 1.1.5
> Environment: Tested with IBM WebSphere Application Server 5.1.1.14 running on IBM JDK 1.4.2 (enclose in WAS) on Windows XP
> Reporter: Michal Durdina
> Priority: Minor
> Attachments: release-1-1-5_p1.diff
>
>
> Fix for Websphere 5.1. since WAS uses protocol wsjar: for accessing jar content instead of regular protocol jar:
> This affects FacesConfigurator which does not correctly detect jars on classpath. FacesConfigurator indirectly uses Enumeration resources = ClassLoader.getResources(resource); to detect libraries on classpath and check if they start with prefix jar: what is obviously not true for IBM Websphere :(
> ie. WAS returns wsjar:file:mypath/myjar.jar!xyz where Tomcat returns jar:file:mypath/myjar.jar!xyz
> Patch is provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-1668) Fix for Websphere 5.1
Posted by "Michal Durdina (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michal Durdina updated MYFACES-1668:
------------------------------------
Status: Patch Available (was: Open)
> Fix for Websphere 5.1
> ---------------------
>
> Key: MYFACES-1668
> URL: https://issues.apache.org/jira/browse/MYFACES-1668
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
> Affects Versions: 1.1.5
> Environment: Tested with IBM WebSphere Application Server 5.1.1.14 running on IBM JDK 1.4.2 (enclose in WAS) on Windows XP
> Reporter: Michal Durdina
> Priority: Minor
>
> Fix for Websphere 5.1. since WAS uses protocol wsjar: for accessing jar content instead of regular protocol jar:
> This affects FacesConfigurator which does not correctly detect jars on classpath. FacesConfigurator indirectly uses Enumeration resources = ClassLoader.getResources(resource); to detect libraries on classpath and check if they start with prefix jar: what is obviously not true for IBM Websphere :(
> ie. WAS returns wsjar:file:mypath/myjar.jar!xyz where Tomcat returns jar:file:mypath/myjar.jar!xyz
> Patch is provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1668) Fix for Websphere 5.1
Posted by "Michal Durdina (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506905 ]
Michal Durdina commented on MYFACES-1668:
-----------------------------------------
Becuase the original code checked 'startsWith("jar:")' not endsWith("jar:").
In supplied patch I changed severals IFs that where checking jar: prefix and !META-INF/MANIFEST.MF suffix to regexp match "(wsjar:|jar:)(.+)!META-INF/MANIFEST.MF".
The path between prefix and suffix is then checked as it was before.
Junit test is provided.
> Fix for Websphere 5.1
> ---------------------
>
> Key: MYFACES-1668
> URL: https://issues.apache.org/jira/browse/MYFACES-1668
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
> Affects Versions: 1.1.5
> Environment: Tested with IBM WebSphere Application Server 5.1.1.14 running on IBM JDK 1.4.2 (enclose in WAS) on Windows XP
> Reporter: Michal Durdina
> Priority: Minor
> Attachments: release-1-1-5_p1.diff
>
>
> Fix for Websphere 5.1. since WAS uses protocol wsjar: for accessing jar content instead of regular protocol jar:
> This affects FacesConfigurator which does not correctly detect jars on classpath. FacesConfigurator indirectly uses Enumeration resources = ClassLoader.getResources(resource); to detect libraries on classpath and check if they start with prefix jar: what is obviously not true for IBM Websphere :(
> ie. WAS returns wsjar:file:mypath/myjar.jar!xyz where Tomcat returns jar:file:mypath/myjar.jar!xyz
> Patch is provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-1668) Fix for Websphere 5.1
Posted by "Michal Durdina (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michal Durdina updated MYFACES-1668:
------------------------------------
Status: Open (was: Patch Available)
> Fix for Websphere 5.1
> ---------------------
>
> Key: MYFACES-1668
> URL: https://issues.apache.org/jira/browse/MYFACES-1668
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
> Affects Versions: 1.1.5
> Environment: Tested with IBM WebSphere Application Server 5.1.1.14 running on IBM JDK 1.4.2 (enclose in WAS) on Windows XP
> Reporter: Michal Durdina
> Priority: Minor
>
> Fix for Websphere 5.1. since WAS uses protocol wsjar: for accessing jar content instead of regular protocol jar:
> This affects FacesConfigurator which does not correctly detect jars on classpath. FacesConfigurator indirectly uses Enumeration resources = ClassLoader.getResources(resource); to detect libraries on classpath and check if they start with prefix jar: what is obviously not true for IBM Websphere :(
> ie. WAS returns wsjar:file:mypath/myjar.jar!xyz where Tomcat returns jar:file:mypath/myjar.jar!xyz
> Patch is provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-1668) Fix for Websphere 5.1
Posted by "Michal Durdina (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michal Durdina updated MYFACES-1668:
------------------------------------
Status: Patch Available (was: Open)
> Fix for Websphere 5.1
> ---------------------
>
> Key: MYFACES-1668
> URL: https://issues.apache.org/jira/browse/MYFACES-1668
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
> Affects Versions: 1.1.5
> Environment: Tested with IBM WebSphere Application Server 5.1.1.14 running on IBM JDK 1.4.2 (enclose in WAS) on Windows XP
> Reporter: Michal Durdina
> Priority: Minor
>
> Fix for Websphere 5.1. since WAS uses protocol wsjar: for accessing jar content instead of regular protocol jar:
> This affects FacesConfigurator which does not correctly detect jars on classpath. FacesConfigurator indirectly uses Enumeration resources = ClassLoader.getResources(resource); to detect libraries on classpath and check if they start with prefix jar: what is obviously not true for IBM Websphere :(
> ie. WAS returns wsjar:file:mypath/myjar.jar!xyz where Tomcat returns jar:file:mypath/myjar.jar!xyz
> Patch is provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.