You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by mm...@apache.org on 2020/06/26 16:21:33 UTC

[pulsar] branch master updated: Schema check logging is too verbose (#7359)

This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new 875e933  Schema check logging is too verbose (#7359)
875e933 is described below

commit 875e933c7b1ebfff55a65a27e556984bd4210a34
Author: Matteo Merli <mm...@apache.org>
AuthorDate: Fri Jun 26 09:21:20 2020 -0700

    Schema check logging is too verbose (#7359)
    
    These were error level logs at the broker, which triggers alerts even
    though there's nothing the operator can do, as the problem occurs when
    the client sends invalid schema to the broker. Marking as warn.
    
    Co-authored-by: Ivan Kelly <ik...@splunk.com>
---
 .../broker/service/schema/AvroSchemaBasedCompatibilityCheck.java      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/AvroSchemaBasedCompatibilityCheck.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/AvroSchemaBasedCompatibilityCheck.java
index 5249fc6..8e24955 100644
--- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/AvroSchemaBasedCompatibilityCheck.java
+++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/AvroSchemaBasedCompatibilityCheck.java
@@ -61,10 +61,10 @@ abstract class AvroSchemaBasedCompatibilityCheck implements SchemaCompatibilityC
             SchemaValidator schemaValidator = createSchemaValidator(strategy);
             schemaValidator.validate(toSchema, fromList);
         } catch (SchemaParseException e) {
-            log.error("Error during schema parsing: {}", e.getMessage(), e);
+            log.warn("Error during schema parsing: {}", e.getMessage());
             throw new IncompatibleSchemaException(e);
         } catch (SchemaValidationException e) {
-            log.error("Error during schema compatibility check: {}", e.getMessage(), e);
+            log.warn("Error during schema compatibility check: {}", e.getMessage());
             throw new IncompatibleSchemaException(e);
         }
     }