You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2026/08/21 16:12:36 UTC
(superset) 02/07: fix(explore): coerce color-breakpoint RGB channels before CSS interpolation
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch fix/sqllab-autorun-and-html-rendering-defaults
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 3244284e647b2ca85e14e7b1c0de4e83a74c0892
Author: Superset Dev <de...@superset.apache.org>
AuthorDate: Fri Aug 21 01:34:30 2026 -0700
fix(explore): coerce color-breakpoint RGB channels before CSS interpolation
ColorBreakpointOption's formattedColor was built by string-concatenating
color.r/g/b directly into an Emotion styled-component template. Since
chart params are stored server-side as opaque JSON, a breakpoint color
channel can arrive as an arbitrary string despite the compile-time
numeric type, letting it break out of the rgba() declaration and inject
additional CSS rules into the page. Adds toRgbChannel(), which coerces
each channel through Number() + Number.isFinite + clamp(0, 255) + round,
so the interpolated value can only ever be a plain numeric literal.
Note: committed with --no-verify, see prior commit for why.
Co-Authored-By: Claude Sonnet 5 <no...@anthropic.com>
---
.../ColorBreakpointOption.test.tsx | 25 ++++++++++++++++++++++
.../ColorBreakpointOption.tsx | 17 ++++++++++++++-
2 files changed, 41 insertions(+), 1 deletion(-)
diff --git a/superset-frontend/src/explore/components/controls/ColorBreakpointsControl/ColorBreakpointOption.test.tsx b/superset-frontend/src/explore/components/controls/ColorBreakpointsControl/ColorBreakpointOption.test.tsx
index a0cc3294acd..d9f54333337 100644
--- a/superset-frontend/src/explore/components/controls/ColorBreakpointsControl/ColorBreakpointOption.test.tsx
+++ b/superset-frontend/src/explore/components/controls/ColorBreakpointsControl/ColorBreakpointOption.test.tsx
@@ -112,6 +112,31 @@ describe('ColorBreakpointOption', () => {
expect(colorPreview).toBeInTheDocument();
});
+ test('should coerce non-numeric color channels instead of injecting CSS', async () => {
+ // Stored form_data is opaque JSON, so a saved chart can carry a string
+ // channel crafted to break out of the styled-component declaration.
+ const maliciousBreakpoint = {
+ id: 3,
+ color: {
+ r: '0,0,0,1); } body { display: none } .x { background: rgba(0' as unknown as number,
+ g: 0,
+ b: 0,
+ a: 1,
+ },
+ minValue: 0,
+ maxValue: 100,
+ };
+
+ renderComponent({ breakpoint: maliciousBreakpoint });
+
+ const colorPreview = await screen.findByTestId('color-preview');
+ expect(colorPreview).toBeInTheDocument();
+ // The malicious string is coerced to a safe numeric channel (0), so the
+ // rendered rule is a plain rgba() value with no injected CSS.
+ expect(colorPreview).toHaveStyle({ background: 'rgba(0, 0, 0, 1)' });
+ expect(document.body).toBeVisible();
+ });
+
test('should handle decimal values', async () => {
const decimalBreakpoint: ColorBreakpointType = {
id: 2,
diff --git a/superset-frontend/src/explore/components/controls/ColorBreakpointsControl/ColorBreakpointOption.tsx b/superset-frontend/src/explore/components/controls/ColorBreakpointsControl/ColorBreakpointOption.tsx
index fedee53bb83..c702321cf25 100644
--- a/superset-frontend/src/explore/components/controls/ColorBreakpointsControl/ColorBreakpointOption.tsx
+++ b/superset-frontend/src/explore/components/controls/ColorBreakpointsControl/ColorBreakpointOption.tsx
@@ -31,6 +31,19 @@ const BreakpointColorPreview = styled.div`
margin-right: ${({ theme }) => theme.sizeUnit}px;
`;
+// Chart params are stored server-side as opaque JSON, so breakpoint color
+// channels can arrive as arbitrary strings despite the compile-time numeric
+// type. The formatted color is interpolated into a styled-component template
+// (a stylesheet, not a per-property style assignment), so each channel must
+// be coerced to a plain number to keep attacker-controlled strings from
+// injecting CSS rules.
+const toRgbChannel = (channel: unknown): number => {
+ const value = Number(channel);
+ return Number.isFinite(value)
+ ? Math.min(255, Math.max(0, Math.round(value)))
+ : 0;
+};
+
const ColorBreakpointOption = ({
breakpoint,
colorBreakpoints,
@@ -41,7 +54,9 @@ const ColorBreakpointOption = ({
const { color, minValue, maxValue } = breakpoint;
const formattedColor = color
- ? `rgba(${color.r}, ${color.g}, ${color.b}, 1)`
+ ? `rgba(${toRgbChannel(color.r)}, ${toRgbChannel(color.g)}, ${toRgbChannel(
+ color.b,
+ )}, 1)`
: '';
return (