[GitHub] [skywalking] wu-sheng commented on issue #6305: about httpasyncclient4.x enhancement

[GitBox <gi...@apache.org>]

wu-sheng commented on issue #6305:
URL: https://github.com/apache/skywalking/issues/6305#issuecomment-771502238


   Thanks for providing the details. 
   
   > In the enhancement of httpasyncclient4.x because of the class SessionRequestImpl was not always be created（when reuse the connection），so the enhancement was failed when resuse the httpconnection。
   
   In this case, then it is a bug for sure.
   
   > But the most important thing was that the DefaultClientExchangeHandlerImpl is not “public”，i wonder if it is a right thing to enhance the class which is not “public” in skywalking。
   
   Not a public class is fine and acceptable for SkyWalking. We don't care how the original codes open classes, we change it based on how they works and make sure the context propagation works. 
   
   As you already have the idea, feel free to submit a pull request to fix, and if you could enhance the plugin test to verify it, it is better.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org