You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "slfan1989 (via GitHub)" <gi...@apache.org> on 2023/04/06 02:27:14 UTC
[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4963: YARN-11326. [Federation] Add RM FederationStateStoreService Metrics.
slfan1989 commented on code in PR #4963:
URL: https://github.com/apache/hadoop/pull/4963#discussion_r1159222245
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/federation/FederationStateStoreService.java:
##########
@@ -283,154 +290,251 @@ public void checkVersion() throws Exception {
@Override
public GetSubClusterPolicyConfigurationResponse getPolicyConfiguration(
GetSubClusterPolicyConfigurationRequest request) throws YarnException {
- return stateStoreClient.getPolicyConfiguration(request);
+ FederationClientMethod<GetSubClusterPolicyConfigurationResponse> clientMethod =
+ new FederationClientMethod<>("getPolicyConfiguration",
+ GetSubClusterPolicyConfigurationRequest.class, request,
+ GetSubClusterPolicyConfigurationResponse.class, stateStoreClient, clock);
+ return clientMethod.invoke();
}
@Override
public SetSubClusterPolicyConfigurationResponse setPolicyConfiguration(
SetSubClusterPolicyConfigurationRequest request) throws YarnException {
- return stateStoreClient.setPolicyConfiguration(request);
+ FederationClientMethod<SetSubClusterPolicyConfigurationResponse> clientMethod =
+ new FederationClientMethod<>("setPolicyConfiguration",
+ SetSubClusterPolicyConfigurationRequest.class, request,
+ SetSubClusterPolicyConfigurationResponse.class, stateStoreClient, clock);
+ return clientMethod.invoke();
}
@Override
public GetSubClusterPoliciesConfigurationsResponse getPoliciesConfigurations(
GetSubClusterPoliciesConfigurationsRequest request) throws YarnException {
- return stateStoreClient.getPoliciesConfigurations(request);
+ FederationClientMethod<GetSubClusterPoliciesConfigurationsResponse> clientMethod =
+ new FederationClientMethod<>("getPoliciesConfigurations",
+ GetSubClusterPoliciesConfigurationsRequest.class, request,
+ GetSubClusterPoliciesConfigurationsResponse.class, stateStoreClient, clock);
+ return clientMethod.invoke();
}
@Override
- public SubClusterRegisterResponse registerSubCluster(
- SubClusterRegisterRequest registerSubClusterRequest)
+ public SubClusterRegisterResponse registerSubCluster(SubClusterRegisterRequest request)
throws YarnException {
- return stateStoreClient.registerSubCluster(registerSubClusterRequest);
+ FederationClientMethod<SubClusterRegisterResponse> clientMethod =
+ new FederationClientMethod<>("registerSubCluster",
+ SubClusterRegisterRequest.class, request,
+ SubClusterRegisterResponse.class, stateStoreClient, clock);
+ return clientMethod.invoke();
}
@Override
- public SubClusterDeregisterResponse deregisterSubCluster(
- SubClusterDeregisterRequest subClusterDeregisterRequest)
+ public SubClusterDeregisterResponse deregisterSubCluster(SubClusterDeregisterRequest request)
throws YarnException {
- return stateStoreClient.deregisterSubCluster(subClusterDeregisterRequest);
+ FederationClientMethod<SubClusterDeregisterResponse> clientMethod =
+ new FederationClientMethod<>("deregisterSubCluster",
+ SubClusterDeregisterRequest.class, request,
+ SubClusterDeregisterResponse.class, stateStoreClient, clock);
+ return clientMethod.invoke();
}
@Override
- public SubClusterHeartbeatResponse subClusterHeartbeat(
- SubClusterHeartbeatRequest subClusterHeartbeatRequest)
+ public SubClusterHeartbeatResponse subClusterHeartbeat(SubClusterHeartbeatRequest request)
throws YarnException {
- return stateStoreClient.subClusterHeartbeat(subClusterHeartbeatRequest);
+ FederationClientMethod<SubClusterHeartbeatResponse> clientMethod =
+ new FederationClientMethod<>("subClusterHeartbeat",
+ SubClusterHeartbeatRequest.class, request,
+ SubClusterHeartbeatResponse.class, stateStoreClient, clock);
+ return clientMethod.invoke();
}
@Override
- public GetSubClusterInfoResponse getSubCluster(
- GetSubClusterInfoRequest subClusterRequest) throws YarnException {
- return stateStoreClient.getSubCluster(subClusterRequest);
+ public GetSubClusterInfoResponse getSubCluster(GetSubClusterInfoRequest request)
+ throws YarnException {
+ FederationClientMethod<GetSubClusterInfoResponse> clientMethod =
+ new FederationClientMethod<>("getSubCluster",
+ GetSubClusterInfoRequest.class, request,
+ GetSubClusterInfoResponse.class, stateStoreClient, clock);
+ return clientMethod.invoke();
}
@Override
- public GetSubClustersInfoResponse getSubClusters(
- GetSubClustersInfoRequest subClustersRequest) throws YarnException {
- return stateStoreClient.getSubClusters(subClustersRequest);
+ public GetSubClustersInfoResponse getSubClusters(GetSubClustersInfoRequest request)
+ throws YarnException {
+ FederationClientMethod<GetSubClustersInfoResponse> clientMethod =
+ new FederationClientMethod<>("getSubClusters",
+ GetSubClustersInfoRequest.class, request,
+ GetSubClustersInfoResponse.class, stateStoreClient, clock);
+ return clientMethod.invoke();
}
@Override
public AddApplicationHomeSubClusterResponse addApplicationHomeSubCluster(
AddApplicationHomeSubClusterRequest request) throws YarnException {
- return stateStoreClient.addApplicationHomeSubCluster(request);
+ FederationClientMethod<AddApplicationHomeSubClusterResponse> clientMethod =
+ new FederationClientMethod<>("addApplicationHomeSubCluster",
+ AddApplicationHomeSubClusterRequest.class, request,
+ AddApplicationHomeSubClusterResponse.class, stateStoreClient, clock);
+ return clientMethod.invoke();
}
@Override
public UpdateApplicationHomeSubClusterResponse updateApplicationHomeSubCluster(
UpdateApplicationHomeSubClusterRequest request) throws YarnException {
- return stateStoreClient.updateApplicationHomeSubCluster(request);
+ FederationClientMethod<UpdateApplicationHomeSubClusterResponse> clientMethod =
+ new FederationClientMethod<>("updateApplicationHomeSubCluster",
+ AddApplicationHomeSubClusterRequest.class, request,
+ UpdateApplicationHomeSubClusterResponse.class, stateStoreClient, clock);
+ return clientMethod.invoke();
}
@Override
public GetApplicationHomeSubClusterResponse getApplicationHomeSubCluster(
GetApplicationHomeSubClusterRequest request) throws YarnException {
- return stateStoreClient.getApplicationHomeSubCluster(request);
+ FederationClientMethod<GetApplicationHomeSubClusterResponse> clientMethod =
+ new FederationClientMethod<>("getApplicationHomeSubCluster",
+ GetApplicationHomeSubClusterRequest.class, request,
+ GetApplicationHomeSubClusterResponse.class, stateStoreClient, clock);
+ return clientMethod.invoke();
}
@Override
public GetApplicationsHomeSubClusterResponse getApplicationsHomeSubCluster(
GetApplicationsHomeSubClusterRequest request) throws YarnException {
- return stateStoreClient.getApplicationsHomeSubCluster(request);
+ FederationClientMethod<GetApplicationsHomeSubClusterResponse> clientMethod =
+ new FederationClientMethod<>("getApplicationsHomeSubCluster",
+ GetApplicationsHomeSubClusterRequest.class, request,
+ GetApplicationsHomeSubClusterResponse.class, stateStoreClient, clock);
+ return clientMethod.invoke();
}
@Override
public DeleteApplicationHomeSubClusterResponse deleteApplicationHomeSubCluster(
DeleteApplicationHomeSubClusterRequest request) throws YarnException {
- return stateStoreClient.deleteApplicationHomeSubCluster(request);
+ FederationClientMethod<DeleteApplicationHomeSubClusterResponse> clientMethod =
+ new FederationClientMethod<>("deleteApplicationHomeSubCluster",
+ DeleteApplicationHomeSubClusterRequest.class, request,
+ DeleteApplicationHomeSubClusterResponse.class, stateStoreClient, clock);
+ return clientMethod.invoke();
}
@Override
public AddReservationHomeSubClusterResponse addReservationHomeSubCluster(
AddReservationHomeSubClusterRequest request) throws YarnException {
- return stateStoreClient.addReservationHomeSubCluster(request);
+ FederationClientMethod<AddReservationHomeSubClusterResponse> clientMethod =
+ new FederationClientMethod<>("addReservationHomeSubCluster",
+ AddReservationHomeSubClusterRequest.class, request,
+ AddReservationHomeSubClusterResponse.class, stateStoreClient, clock);
+ return clientMethod.invoke();
}
@Override
public GetReservationHomeSubClusterResponse getReservationHomeSubCluster(
GetReservationHomeSubClusterRequest request) throws YarnException {
- return stateStoreClient.getReservationHomeSubCluster(request);
+ FederationClientMethod<GetReservationHomeSubClusterResponse> clientMethod =
+ new FederationClientMethod<>("getReservationHomeSubCluster",
+ GetReservationHomeSubClusterRequest.class, request,
+ GetReservationHomeSubClusterResponse.class, stateStoreClient, clock);
+ return clientMethod.invoke();
}
@Override
public GetReservationsHomeSubClusterResponse getReservationsHomeSubCluster(
GetReservationsHomeSubClusterRequest request) throws YarnException {
- return stateStoreClient.getReservationsHomeSubCluster(request);
+ FederationClientMethod<GetReservationsHomeSubClusterResponse> clientMethod =
+ new FederationClientMethod<>("getReservationsHomeSubCluster",
+ GetReservationsHomeSubClusterRequest.class, request,
+ GetReservationsHomeSubClusterResponse.class, stateStoreClient, clock);
+ return clientMethod.invoke();
}
@Override
public UpdateReservationHomeSubClusterResponse updateReservationHomeSubCluster(
UpdateReservationHomeSubClusterRequest request) throws YarnException {
- return stateStoreClient.updateReservationHomeSubCluster(request);
+ FederationClientMethod<UpdateReservationHomeSubClusterResponse> clientMethod =
+ new FederationClientMethod<>("updateReservationHomeSubCluster",
+ GetReservationsHomeSubClusterRequest.class, request,
+ UpdateReservationHomeSubClusterResponse.class, stateStoreClient, clock);
+ return clientMethod.invoke();
}
@Override
public DeleteReservationHomeSubClusterResponse deleteReservationHomeSubCluster(
DeleteReservationHomeSubClusterRequest request) throws YarnException {
- return stateStoreClient.deleteReservationHomeSubCluster(request);
+ FederationClientMethod<DeleteReservationHomeSubClusterResponse> clientMethod =
+ new FederationClientMethod<>("deleteReservationHomeSubCluster",
+ DeleteReservationHomeSubClusterRequest.class, request,
+ DeleteReservationHomeSubClusterResponse.class, stateStoreClient, clock);
+ return clientMethod.invoke();
}
@Override
public RouterMasterKeyResponse storeNewMasterKey(RouterMasterKeyRequest request)
throws YarnException, IOException {
- return stateStoreClient.storeNewMasterKey(request);
+ FederationClientMethod<RouterMasterKeyResponse> clientMethod =
+ new FederationClientMethod<>("storeNewMasterKey",
+ RouterMasterKeyRequest.class, request,
+ RouterMasterKeyResponse.class, stateStoreClient, clock);
+ return clientMethod.invoke();
}
@Override
public RouterMasterKeyResponse removeStoredMasterKey(RouterMasterKeyRequest request)
throws YarnException, IOException {
- return stateStoreClient.removeStoredMasterKey(request);
+ FederationClientMethod<RouterMasterKeyResponse> clientMethod =
+ new FederationClientMethod<>("removeStoredMasterKey",
+ RouterMasterKeyRequest.class, request,
+ RouterMasterKeyResponse.class, stateStoreClient, clock);
+ return clientMethod.invoke();
}
@Override
public RouterMasterKeyResponse getMasterKeyByDelegationKey(RouterMasterKeyRequest request)
throws YarnException, IOException {
- return stateStoreClient.getMasterKeyByDelegationKey(request);
+ FederationClientMethod<RouterMasterKeyResponse> clientMethod =
+ new FederationClientMethod<>("getMasterKeyByDelegationKey",
+ RouterMasterKeyRequest.class, request,
+ RouterMasterKeyResponse.class, stateStoreClient, clock);
+ return clientMethod.invoke();
}
@Override
public RouterRMTokenResponse storeNewToken(RouterRMTokenRequest request)
throws YarnException, IOException {
- return stateStoreClient.storeNewToken(request);
+ FederationClientMethod<RouterRMTokenResponse> clientMethod =
+ new FederationClientMethod<>("storeNewToken",
+ RouterRMTokenRequest.class, request,
+ RouterRMTokenResponse.class, stateStoreClient, clock);
+ return clientMethod.invoke();
}
@Override
public RouterRMTokenResponse updateStoredToken(RouterRMTokenRequest request)
throws YarnException, IOException {
- return stateStoreClient.updateStoredToken(request);
+ FederationClientMethod<RouterRMTokenResponse> clientMethod =
+ new FederationClientMethod<>("updateStoredToken",
Review Comment:
Thanks for your suggestion! I will modify the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org