You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/16 15:32:13 UTC
[GitHub] [flink] dawidwys opened a new pull request #13668: [hotfix] Log interrupted exception on debug when closing threads in ExternalSorter
dawidwys opened a new pull request #13668:
URL: https://github.com/apache/flink/pull/13668
## What is the purpose of the change
Revert the behaviour of logging an InterreputedException on debug level when closing working threads in ExternalSorter.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13668: [hotfix] Log interrupted exception on debug when closing threads in ExternalSorter
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13668:
URL: https://github.com/apache/flink/pull/13668#issuecomment-710144238
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0602dadb007befbb94f13c6a57ccbe29481f2a5b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0602dadb007befbb94f13c6a57ccbe29481f2a5b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0602dadb007befbb94f13c6a57ccbe29481f2a5b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13668: [hotfix] Log interrupted exception on debug when closing threads in ExternalSorter
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13668:
URL: https://github.com/apache/flink/pull/13668#issuecomment-710144238
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0602dadb007befbb94f13c6a57ccbe29481f2a5b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7771",
"triggerID" : "0602dadb007befbb94f13c6a57ccbe29481f2a5b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0602dadb007befbb94f13c6a57ccbe29481f2a5b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7771)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys merged pull request #13668: [hotfix] Log interrupted exception on debug when closing threads in ExternalSorter
Posted by GitBox <gi...@apache.org>.
dawidwys merged pull request #13668:
URL: https://github.com/apache/flink/pull/13668
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13668: [hotfix] Log interrupted exception on debug when closing threads in ExternalSorter
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13668:
URL: https://github.com/apache/flink/pull/13668#issuecomment-710118986
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 0602dadb007befbb94f13c6a57ccbe29481f2a5b (Fri Oct 16 15:34:17 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #13668: [hotfix] Log interrupted exception on debug when closing threads in ExternalSorter
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #13668:
URL: https://github.com/apache/flink/pull/13668#discussion_r506908873
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/ExternalSorter.java
##########
@@ -230,6 +218,20 @@ public void close() {
}
}
+ private void closeThread(StageRunner sortThread, String threadName) {
Review comment:
```suggestion
private void closeThread(StageRunner thread, String threadName) {
```
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/ExternalSorter.java
##########
@@ -230,6 +218,20 @@ public void close() {
}
}
+ private void closeThread(StageRunner sortThread, String threadName) {
+ try {
+ sortThread.close();
Review comment:
```suggestion
thread.close();
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13668: [hotfix] Log interrupted exception on debug when closing threads in ExternalSorter
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13668:
URL: https://github.com/apache/flink/pull/13668#issuecomment-710144238
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0602dadb007befbb94f13c6a57ccbe29481f2a5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7771",
"triggerID" : "0602dadb007befbb94f13c6a57ccbe29481f2a5b",
"triggerType" : "PUSH"
}, {
"hash" : "8e1a0846b116dde3455d09e77a6c21484caeac5d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8315",
"triggerID" : "8e1a0846b116dde3455d09e77a6c21484caeac5d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8e1a0846b116dde3455d09e77a6c21484caeac5d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8315)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13668: [hotfix] Log interrupted exception on debug when closing threads in ExternalSorter
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13668:
URL: https://github.com/apache/flink/pull/13668#issuecomment-710144238
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0602dadb007befbb94f13c6a57ccbe29481f2a5b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7771",
"triggerID" : "0602dadb007befbb94f13c6a57ccbe29481f2a5b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0602dadb007befbb94f13c6a57ccbe29481f2a5b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7771)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13668: [hotfix] Log interrupted exception on debug when closing threads in ExternalSorter
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13668:
URL: https://github.com/apache/flink/pull/13668#issuecomment-710144238
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0602dadb007befbb94f13c6a57ccbe29481f2a5b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7771",
"triggerID" : "0602dadb007befbb94f13c6a57ccbe29481f2a5b",
"triggerType" : "PUSH"
}, {
"hash" : "8e1a0846b116dde3455d09e77a6c21484caeac5d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8e1a0846b116dde3455d09e77a6c21484caeac5d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0602dadb007befbb94f13c6a57ccbe29481f2a5b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7771)
* 8e1a0846b116dde3455d09e77a6c21484caeac5d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13668: [hotfix] Log interrupted exception on debug when closing threads in ExternalSorter
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13668:
URL: https://github.com/apache/flink/pull/13668#issuecomment-710144238
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0602dadb007befbb94f13c6a57ccbe29481f2a5b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7771",
"triggerID" : "0602dadb007befbb94f13c6a57ccbe29481f2a5b",
"triggerType" : "PUSH"
}, {
"hash" : "8e1a0846b116dde3455d09e77a6c21484caeac5d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8315",
"triggerID" : "8e1a0846b116dde3455d09e77a6c21484caeac5d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0602dadb007befbb94f13c6a57ccbe29481f2a5b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7771)
* 8e1a0846b116dde3455d09e77a6c21484caeac5d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8315)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org