You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by felixcheung <gi...@git.apache.org> on 2017/05/01 00:49:26 UTC

[GitHub] spark issue #17807: [SPARK-20532][SPARKR] Implement grouping and grouping_id

Github user felixcheung commented on the issue:

    https://github.com/apache/spark/pull/17807
  
    yea, I agree it's not ideal and I'm not in favor of dispatch hacking either.
    
    I think the latest you have is reasonable... but as you say, perhaps this isn't worthwhile to iterate that much with. Either that or what if we name this something else, like perhaps `grouping_bit` to distinguish with `grouping_id`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org