You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by purplecabbage <gi...@git.apache.org> on 2016/10/12 06:30:48 UTC
[GitHub] cordova-windows pull request #200: CB-11999 platformAPIs contain js code tha...
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-windows/pull/200
CB-11999 platformAPIs contain js code that is deceptively uncallable
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
windows
### What does this PR do?
catches possible error
### What testing has been done on this change?
jshint
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-windows CB-11999
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/200.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #200
----
commit 50730294f4d041f11f83d69dce6739674ff4d4e7
Author: Jesse MacFadyen <pu...@gmail.com>
Date: 2016-10-12T06:26:01Z
output message, catch exception if require fails, change eventEmitter to events to be consistent with ios+android
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows issue #200: CB-11999 platformAPIs contain js code that is de...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-windows/pull/200
## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/200?src=pr) is 74.34% (diff: 100%)
> Merging [#200](https://codecov.io/gh/apache/cordova-windows/pull/200?src=pr) into [master](https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr) will not change coverage
```diff
@@ master #200 diff @@
==========================================
Files 14 14
Lines 1949 1949
Methods 366 366
Messages 0 0
Branches 392 392
==========================================
Hits 1449 1449
Misses 500 500
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [bf505cc...5073029](https://codecov.io/gh/apache/cordova-windows/compare/bf505cc69c13d16b4d3c32d1bef53367f16b6230...50730294f4d041f11f83d69dce6739674ff4d4e7?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request #200: CB-11999 platformAPIs contain js code tha...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/200
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org