You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Farhan Khan <fa...@freestoneinfotech.com> on 2022/04/21 10:19:14 UTC
Review Request 73952: ATLAS-4585: (UI)Incorrect hyphenation of words in property description field
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73952/
-----------------------------------------------------------
Review request for atlas, Jayendra Parab and Prasad Pawar.
Bugs: ATLAS-4585
https://issues.apache.org/jira/browse/ATLAS-4585
Repository: atlas
Description
-------
Hyphenation of words is incorrect.
Ex (see attached picture) :
"Abonnement et" should be :
"abonnement
et"
but we get
"abonnement e"
"t"
=> Hyphenation happens at the middle of the word "et"
Note: This happens on Entity details page in the Technical properties section having description fields.
Diffs
-----
dashboardv2/public/css/scss/common.scss 5e7ffef67
dashboardv2/public/css/scss/table.scss 121769b18
dashboardv3/public/css/scss/common.scss c13c47c20
dashboardv3/public/css/scss/table.scss 121769b18
Diff: https://reviews.apache.org/r/73952/diff/1/
Testing
-------
Manually tested on both the UI's.
Thanks,
Farhan Khan
Re: Review Request 73952: ATLAS-4585: (UI)Incorrect hyphenation of words in property description field
Posted by Ashutosh Mestry <as...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73952/#review224346
-----------------------------------------------------------
Ship it!
Ship It!
- Ashutosh Mestry
On April 21, 2022, 10:37 a.m., Farhan Khan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73952/
> -----------------------------------------------------------
>
> (Updated April 21, 2022, 10:37 a.m.)
>
>
> Review request for atlas, Jayendra Parab and Prasad Pawar.
>
>
> Bugs: ATLAS-4585
> https://issues.apache.org/jira/browse/ATLAS-4585
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Hyphenation of words is incorrect.
>
>
> "Abonnement et" should be :
>
> "abonnement
> et"
>
> but we get
>
> "abonnement e"
> "t"
> => Hyphenation happens at the middle of the word "et"
>
> Note: This happens on Entity details page in the Technical properties section having description fields.
>
>
> Diffs
> -----
>
> dashboardv2/public/css/scss/common.scss 5e7ffef67
> dashboardv2/public/css/scss/table.scss 121769b18
> dashboardv3/public/css/scss/common.scss c13c47c20
> dashboardv3/public/css/scss/table.scss 121769b18
>
>
> Diff: https://reviews.apache.org/r/73952/diff/1/
>
>
> Testing
> -------
>
> Manually tested on both the UI's by adding lots of description text and it is getting displayed in proper format as expected.
>
>
> Thanks,
>
> Farhan Khan
>
>
Re: Review Request 73952: ATLAS-4585: (UI)Incorrect hyphenation of words in property description field
Posted by Prasad Pawar <pr...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73952/#review224369
-----------------------------------------------------------
Ship it!
Ship It!
- Prasad Pawar
On April 21, 2022, 10:37 a.m., Farhan Khan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73952/
> -----------------------------------------------------------
>
> (Updated April 21, 2022, 10:37 a.m.)
>
>
> Review request for atlas, Jayendra Parab and Prasad Pawar.
>
>
> Bugs: ATLAS-4585
> https://issues.apache.org/jira/browse/ATLAS-4585
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Hyphenation of words is incorrect.
>
>
> "Abonnement et" should be :
>
> "abonnement
> et"
>
> but we get
>
> "abonnement e"
> "t"
> => Hyphenation happens at the middle of the word "et"
>
> Note: This happens on Entity details page in the Technical properties section having description fields.
>
>
> Diffs
> -----
>
> dashboardv2/public/css/scss/common.scss 5e7ffef67
> dashboardv2/public/css/scss/table.scss 121769b18
> dashboardv3/public/css/scss/common.scss c13c47c20
> dashboardv3/public/css/scss/table.scss 121769b18
>
>
> Diff: https://reviews.apache.org/r/73952/diff/1/
>
>
> Testing
> -------
>
> Manually tested on both the UI's by adding lots of description text and it is getting displayed in proper format as expected.
>
>
> Thanks,
>
> Farhan Khan
>
>
Re: Review Request 73952: ATLAS-4585: (UI)Incorrect hyphenation of words in property description field
Posted by Farhan Khan <fa...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73952/
-----------------------------------------------------------
(Updated April 21, 2022, 10:37 a.m.)
Review request for atlas, Jayendra Parab and Prasad Pawar.
Bugs: ATLAS-4585
https://issues.apache.org/jira/browse/ATLAS-4585
Repository: atlas
Description (updated)
-------
Hyphenation of words is incorrect.
"Abonnement et" should be :
"abonnement
et"
but we get
"abonnement e"
"t"
=> Hyphenation happens at the middle of the word "et"
Note: This happens on Entity details page in the Technical properties section having description fields.
Diffs
-----
dashboardv2/public/css/scss/common.scss 5e7ffef67
dashboardv2/public/css/scss/table.scss 121769b18
dashboardv3/public/css/scss/common.scss c13c47c20
dashboardv3/public/css/scss/table.scss 121769b18
Diff: https://reviews.apache.org/r/73952/diff/1/
Testing (updated)
-------
Manually tested on both the UI's by adding lots of description text and it is getting displayed in proper format as expected.
Thanks,
Farhan Khan