[jira] [Commented] (CALCITE-2156) DateRangeRules not handling timestamp with local timezone properly

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349478#comment-16349478 ] 

Julian Hyde commented on CALCITE-2156:
--------------------------------------

Reviewing [4dfa0092|https://github.com/apache/calcite/pull/617/commits/4dfa00920b481af1cc788cb7ca9fdef744abf133]:
* Remove test123
* I can't figure out why we need an anonymous sub-class of TesterImpl in two places in RelOptRulesTest. Did you make that change for debugging, and forget to revert it? If you really need new functionality, add it as a method to the fluid API {{RelOptTestBase.Sql}}, so tests can just write {{sql(sql).withTheNewThing().withProgram(program).check()}}.

> DateRangeRules not handling timestamp with local timezone properly
> ------------------------------------------------------------------
>
>                 Key: CALCITE-2156
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2156
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Nishant Bangarwa
>            Assignee: Nishant Bangarwa
>            Priority: Major
>
> DateRangeRules calculate floor and ceil on timestamp with local timezone in UTC timezone, instead it should do the floor or ceil on timestamp in local timezone when data type is timestamp with local timezone. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)