You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/02/19 19:52:48 UTC
[GitHub] [incubator-mxnet] access2rohit opened a new pull request #19928: [BUGFIX] Pip Build: use runtime.Features instead of manual check for mkldnn headers (#19195)
access2rohit opened a new pull request #19928:
URL: https://github.com/apache/incubator-mxnet/pull/19928
Backport #19195 as a part of effort #19911
* use runtime Features instead of manual check
* move mxnet package closer to where its used
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #19928: [BUGFIX] Pip Build: use runtime.Features instead of manual check for mkldnn headers (#19195)
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on a change in pull request #19928:
URL: https://github.com/apache/incubator-mxnet/pull/19928#discussion_r579691455
##########
File path: tools/pip/setup.py
##########
@@ -142,22 +142,16 @@ def skip_markdown_comments(md):
libraries.append('CUDA-10.0')
elif variant.startswith('CU92'):
libraries.append('CUDA-9.2')
- elif variant.startswith('CU91'):
Review comment:
Are we dropping support for all cuda till 9? I guess yes [since cuda11 has launched and we support till latest major version-1]. Can we update the PR title to also reflect the same? Since currently it just talks about mkldnn and this PR changes things more than that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya merged pull request #19928: [BUGFIX] Pip Build: use runtime.Features instead of manual check for mkldnn headers (#19195)
Posted by GitBox <gi...@apache.org>.
ChaiBapchya merged pull request #19928:
URL: https://github.com/apache/incubator-mxnet/pull/19928
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19928: [BUGFIX] Pip Build: use runtime.Features instead of manual check for mkldnn headers (#19195)
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19928:
URL: https://github.com/apache/incubator-mxnet/pull/19928#issuecomment-782304054
Hey @access2rohit , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [windows-cpu, unix-gpu, centos-gpu, website, clang, windows-gpu, miscellaneous, sanity, edge, centos-cpu, unix-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #19928: [BUGFIX] Pip Build: use runtime.Features instead of manual check for mkldnn headers (#19195)
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #19928:
URL: https://github.com/apache/incubator-mxnet/pull/19928#issuecomment-782304297
@josephevans @ChaiBapchya Can you review ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org