You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/09/10 18:51:47 UTC

[GitHub] codecov-io commented on issue #5359: Upgrade to React==16.4.1 & Enzyme==3.3.0

codecov-io commented on issue #5359: Upgrade to React==16.4.1 &  Enzyme==3.3.0
URL: https://github.com/apache/incubator-superset/pull/5359#issuecomment-420020915
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5359?src=pr&el=h1) Report
   > Merging [#5359](https://codecov.io/gh/apache/incubator-superset/pull/5359?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e35bfba308a1ed21226143c18feb4e11f5bec845?src=pr&el=desc) will **decrease** coverage by `9.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5359/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5359?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #5359      +/-   ##
   ==========================================
   - Coverage    63.6%   54.31%   -9.29%     
   ==========================================
     Files         374      328      -46     
     Lines       23321    14019    -9302     
     Branches     2608     2608              
   ==========================================
   - Hits        14833     7615    -7218     
   + Misses       8475     6391    -2084     
     Partials       13       13
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5359?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/assets/src/common.js](https://codecov.io/gh/apache/incubator-superset/pull/5359/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21tb24uanM=) | `0% <ø> (-40%)` | :arrow_down: |
   | [...src/explore/components/controls/SpatialControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5359/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvU3BhdGlhbENvbnRyb2wuanN4) | `32.94% <ø> (-0.78%)` | :arrow_down: |
   | [superset/assets/src/SqlLab/actions.js](https://codecov.io/gh/apache/incubator-superset/pull/5359/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvYWN0aW9ucy5qcw==) | `71.25% <100%> (ø)` | :arrow_up: |
   | [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5359/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvQWRob2NNZXRyaWNFZGl0UG9wb3Zlci5qc3g=) | `80.58% <100%> (+3.88%)` | :arrow_up: |
   | [superset/assets/src/utils/common.js](https://codecov.io/gh/apache/incubator-superset/pull/5359/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy91dGlscy9jb21tb24uanM=) | `61.53% <100%> (+1.01%)` | :arrow_up: |
   | [...uperset/assets/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5359/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TcWxFZGl0b3IuanN4) | `78.09% <100%> (ø)` | :arrow_up: |
   | [superset/assets/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/5359/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9jaGFydEFjdGlvbi5qcw==) | `50% <100%> (ø)` | :arrow_up: |
   | [...rset/assets/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5359/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9UYWJsZUVsZW1lbnQuanN4) | `94.04% <0%> (-1.2%)` | :arrow_down: |
   | [superset/connectors/druid/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/5359/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9fX2luaXRfXy5weQ==) | | |
   | ... and [56 more](https://codecov.io/gh/apache/incubator-superset/pull/5359/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5359?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5359?src=pr&el=footer). Last update [e35bfba...75a5c76](https://codecov.io/gh/apache/incubator-superset/pull/5359?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org