You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by li...@apache.org on 2024/04/05 00:04:32 UTC
(superset) branch table-time-comparison-blank created (now 6edf76bb94)
This is an automated email from the ASF dual-hosted git repository.
lilykuang pushed a change to branch table-time-comparison-blank
in repository https://gitbox.apache.org/repos/asf/superset.git
at 6edf76bb94 fix: table with time comparison shows blank columns when dimension is numeric
This branch includes the following new commits:
new 6edf76bb94 fix: table with time comparison shows blank columns when dimension is numeric
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(superset) 01/01: fix: table with time comparison shows blank columns when dimension is numeric
Posted by li...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
lilykuang pushed a commit to branch table-time-comparison-blank
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 6edf76bb9484130ccb7e8b4ad672c18d496368a4
Author: lilykuang <ji...@gmail.com>
AuthorDate: Thu Apr 4 17:00:35 2024 -0700
fix: table with time comparison shows blank columns when dimension is numeric
---
superset-frontend/plugins/plugin-chart-table/src/transformProps.ts | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/superset-frontend/plugins/plugin-chart-table/src/transformProps.ts b/superset-frontend/plugins/plugin-chart-table/src/transformProps.ts
index a49c3ac4af..af0e4cdde6 100644
--- a/superset-frontend/plugins/plugin-chart-table/src/transformProps.ts
+++ b/superset-frontend/plugins/plugin-chart-table/src/transformProps.ts
@@ -288,7 +288,11 @@ const processComparisonColumns = (
const config = columnConfig[col.key] || {};
const savedFormat = columnFormats?.[col.key];
const numberFormat = config.d3NumberFormat || savedFormat;
- if (col.isNumeric && !col.key.includes(COMPARISON_PREFIX)) {
+ if (
+ (col.isMetric || col.isPercentMetric) &&
+ !col.key.includes(COMPARISON_PREFIX) &&
+ col.isNumeric
+ ) {
return [
{
...col,