You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/04/24 22:31:13 UTC
[GitHub] [kafka] ableegoldman commented on a change in pull request #8445: KAFKA-9823: Remember the sent generation for the coordinator request
ableegoldman commented on a change in pull request #8445:
URL: https://github.com/apache/kafka/pull/8445#discussion_r414898776
##########
File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##########
@@ -1209,9 +1227,18 @@ public void handle(OffsetCommitResponse commitResponse, RequestFuture<Void> futu
return;
} else if (error == Errors.UNKNOWN_MEMBER_ID
|| error == Errors.ILLEGAL_GENERATION) {
- // need to reset generation and re-join group
- resetGenerationOnResponseError(ApiKeys.OFFSET_COMMIT, error);
- future.raise(new CommitFailedException());
+ log.info("OffsetCommit failed with {}: {}", sentGeneration, error.message());
+
+ // only need to reset generation and re-join group if generation has not changed;
+ // otherwise only raise rebalance-in-progress error
+ if (generationUnchanged()) {
+ resetGenerationOnResponseError(ApiKeys.OFFSET_COMMIT, error);
+ future.raise(new CommitFailedException());
+ } else {
+ future.raise(new RebalanceInProgressException("Offset commit cannot be completed since the " +
Review comment:
This seems a bit misleading, because the consumer is not actually participating in an ongoing rebalance (yet)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org