You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/15 09:14:33 UTC

[GitHub] [pulsar] AnonHxy commented on a change in pull request #14267: [WIP][Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicies about publishRate

AnonHxy commented on a change in pull request #14267:
URL: https://github.com/apache/pulsar/pull/14267#discussion_r806609861



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
##########
@@ -1061,7 +1044,8 @@ protected boolean isExceedMaximumMessageSize(int size, PublishContext publishCon
     /**
      * update topic publish dispatcher for this topic.
      */
-    protected void updatePublishDispatcher(PublishRate publishRate) {
+    public void updatePublishDispatcher() {
+        PublishRate publishRate = topicPolicies.getPublishRate().get();

Review comment:
       It can not return null, I will remove the `if (publishRate != null` below




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org