You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/06/20 10:41:52 UTC
[GitHub] [trafficserver] brbzull0 commented on a diff in pull request #8918: uri_signing/parse: check for null iss when kid == NULL
brbzull0 commented on code in PR #8918:
URL: https://github.com/apache/trafficserver/pull/8918#discussion_r901522006
##########
plugins/experimental/uri_signing/parse.c:
##########
@@ -222,6 +222,10 @@ validate_jws(cjose_jws_t *jws, struct config *cfg, const char *uri, size_t uri_c
}
TimerDebug("checking crypto signature for jwt");
} else {
+ if (!jwt->iss) {
Review Comment:
maybe I am missing something:
I guess it does not harm but, If the `jwt_validate` [up](https://github.com/apache/trafficserver/blob/8ca74ee27cc14f27a1480a88fc453fbabc954e4e/plugins/experimental/uri_signing/parse.c#L195) above fails because `iss` is null then we should never get this far. Previous [PR](https://github.com/apache/trafficserver/pull/8901/) added a validation for this field in which case it should prevent us getting this far.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org