You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mcgilman <gi...@git.apache.org> on 2018/04/26 16:36:09 UTC
[GitHub] nifi pull request #2662: NIFI-5124: Upgrading commons-fileupload
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2662
NIFI-5124: Upgrading commons-fileupload
NIFI-5124:
- Upgrading to the latest version of commons-fileupload.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcgilman/nifi NIFI-5124
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2662.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2662
----
commit 00a7b96e4ab07a9b0c98849379d13617a097e105
Author: Matt Gilman <ma...@...>
Date: 2018-04-26T16:35:02Z
NIFI-5124:
- Upgrading to the latest version of commons-fileupload.
----
---
[GitHub] nifi issue #2662: NIFI-5124: Upgrading commons-fileupload
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2662
I must have pushed it to the wrong remote. I couldn't see it either so I rebased and pushed to `apache/master`. Should be good now. Thanks.
---
[GitHub] nifi pull request #2662: NIFI-5124: Upgrading commons-fileupload
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman closed the pull request at:
https://github.com/apache/nifi/pull/2662
---
[GitHub] nifi issue #2662: NIFI-5124: Upgrading commons-fileupload
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2662
Thanks @alopresto!
---
[GitHub] nifi issue #2662: NIFI-5124: Upgrading commons-fileupload
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2662
Mistyped the commit message magic words; @mcgilman can you please close this when you get a chance?
---
[GitHub] nifi issue #2662: NIFI-5124: Upgrading commons-fileupload
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2662
Ran `contrib-check` and all tests pass. Verified the file upload functionality still works by importing a template. +1, merging.
---
[GitHub] nifi issue #2662: NIFI-5124: Upgrading commons-fileupload
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2662
@alopresto I don't see the commit for this PR in master (unless I'm missing it). Can you please double check that it was pushed? Thanks!
---
[GitHub] nifi issue #2662: NIFI-5124: Upgrading commons-fileupload
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2662
Reviewing...
---