[jira] [Commented] (IGNITE-9802) Test TcpCommunicationSpiFaultyClientTest.testNotAcceptedConnection is flaky in master

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-9802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643064#comment-16643064 ] 

ASF GitHub Bot commented on IGNITE-9802:
----------------------------------------

GitHub user NSAmelchev opened a pull request:

    https://github.com/apache/ignite/pull/4931

    IGNITE-9802

    Fix for the test. 
    
    The problem was that PME happens and prevent to closing idle connections. The test needs close connections to recreate comm client. There was only 1s sleep. I replace it with **awaitPartitionMapExchange** and **waitForCondition**.  
    
    Also, code style and inspections fix. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NSAmelchev/ignite ignite-9802

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/4931.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4931
    
----
commit 6899735ed5e7bcb85d06021f3bae95b38b25052d
Author: NSAmelchev <ns...@...>
Date:   2018-10-09T09:49:42Z

    Fix TcpCommunicationSpiFaultyClientTest.testNotAcceptedConnection test

----


> Test TcpCommunicationSpiFaultyClientTest.testNotAcceptedConnection is flaky in master
> -------------------------------------------------------------------------------------
>
>                 Key: IGNITE-9802
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9802
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Amelchev Nikita
>            Assignee: Amelchev Nikita
>            Priority: Major
>              Labels: MakeTeamcityGreenAgain
>
> The test is flaky in master. Example of fail: [TC build. |https://ci.ignite.apache.org/viewLog.html?buildTypeId=IgniteTests24Java8_Spi&buildId=1976776] 
> Log details:
> {noformat}
> junit.framework.AssertionFailedError
> at org.apache.ignite.spi.communication.tcp.TcpCommunicationSpiFaultyClientTest.testFailClient(TcpCommunicationSpiFaultyClientTest.java:178)
> at org.apache.ignite.spi.communication.tcp.TcpCommunicationSpiFaultyClientTest.testNotAcceptedConnection(TcpCommunicationSpiFaultyClientTest.java:130){noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)