You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2020/04/10 21:23:59 UTC

[GitHub] [knox] risdenk opened a new pull request #311: KNOX-2339 - Add Github Actions for CI

risdenk opened a new pull request #311: KNOX-2339 - Add Github Actions for CI
URL: https://github.com/apache/knox/pull/311
 
 
   ## What changes were proposed in this pull request?
   
   Add Github Actions for CI
   
   ## How was this patch tested?
   
   Need to look at this on a fork or something - but pushing here for initial thoughts. It is missing some of Travis CI stuff - but will look at that too.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [knox] risdenk merged pull request #311: KNOX-2339 - Add Github Actions for CI

Posted by GitBox <gi...@apache.org>.
risdenk merged pull request #311: KNOX-2339 - Add Github Actions for CI
URL: https://github.com/apache/knox/pull/311
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [knox] smolnar82 commented on issue #311: KNOX-2339 - Add Github Actions for CI

Posted by GitBox <gi...@apache.org>.
smolnar82 commented on issue #311: KNOX-2339 - Add Github Actions for CI
URL: https://github.com/apache/knox/pull/311#issuecomment-613018963
 
 
   In Travis, we have `shellcheck` support too. There is a `shellcheck` action in GitHub Actions too:
   https://github.com/marketplace/actions/shellcheck
   
   Is it possible that you integrate it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [knox] risdenk removed a comment on issue #311: KNOX-2339 - Add Github Actions for CI

Posted by GitBox <gi...@apache.org>.
risdenk removed a comment on issue #311: KNOX-2339 - Add Github Actions for CI
URL: https://github.com/apache/knox/pull/311#issuecomment-612225082
 
 
   Ah ha it does run on my fork branch: https://github.com/risdenk/knox/runs/577938164

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [knox] risdenk commented on issue #311: KNOX-2339 - Add Github Actions for CI

Posted by GitBox <gi...@apache.org>.
risdenk commented on issue #311: KNOX-2339 - Add Github Actions for CI
URL: https://github.com/apache/knox/pull/311#issuecomment-613042453
 
 
   Yea I was just trying to get a start on this. I had added shellcheck but it was causing issues. I will go back and look into it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [knox] risdenk commented on issue #311: KNOX-2339 - Add Github Actions for CI

Posted by GitBox <gi...@apache.org>.
risdenk commented on issue #311: KNOX-2339 - Add Github Actions for CI
URL: https://github.com/apache/knox/pull/311#issuecomment-612292974
 
 
   This is blocked by #312 and failed due to java-support issues which has been reverted. I'll rebase once #312 is in.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [knox] risdenk commented on issue #311: KNOX-2339 - Add Github Actions for CI

Posted by GitBox <gi...@apache.org>.
risdenk commented on issue #311: KNOX-2339 - Add Github Actions for CI
URL: https://github.com/apache/knox/pull/311#issuecomment-612225082
 
 
   Ah ha it does run on my fork branch: https://github.com/risdenk/knox/runs/577938164

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services