You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/11/11 19:37:00 UTC

[jira] [Commented] (LUCENE-10063) SimpleTextKnnVectorsReader.search needs an implementation

    [ https://issues.apache.org/jira/browse/LUCENE-10063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442424#comment-17442424 ] 

ASF subversion and git services commented on LUCENE-10063:
----------------------------------------------------------

Commit 2a9adb81df314ffeb92951bbf2d99fecc94fa581 in lucene's branch refs/heads/main from Julie Tibshirani
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=2a9adb8 ]

LUCENE-10063: Fix score calculation in SimpleTextKnnVectorsFormat

The method VectorSimilarityFunction#convertToScore already reverses the
similarity, so we shouldn't reverse it again.


> SimpleTextKnnVectorsReader.search needs an implementation
> ---------------------------------------------------------
>
>                 Key: LUCENE-10063
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10063
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Adrien Grand
>            Priority: Blocker
>             Fix For: main (10.0)
>
>          Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> SimpleText doesn't implement vector search today by throwing an UnsupportedOperationException. We worked around this by disabling SimpleText on tests that use vectors until now, but this isn't a good solution: SimpleText should implement APIs correctly and only be disabled on tests that expect a binary format or that are too slow with SimpleText.
> Let's implement this method via linear scan for now?



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org