You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2012/09/05 06:47:07 UTC
[jira] [Created] (LUCENE-4362) ban tab-indented source
Robert Muir created LUCENE-4362:
-----------------------------------
Summary: ban tab-indented source
Key: LUCENE-4362
URL: https://issues.apache.org/jira/browse/LUCENE-4362
Project: Lucene - Core
Issue Type: Task
Reporter: Robert Muir
This makes code really difficult to read and work with.
Its easy enough to prevent.
{noformat}
Index: build.xml
===================================================================
--- build.xml (revision 1380979)
+++ build.xml (working copy)
@@ -77,11 +77,12 @@
<or>
<containsregexp expression="@author\b" casesensitive="yes"/>
<containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
+ <containsregexp expression="\t" casesensitive="no"/>
</or>
</fileset>
<map from="${validate.currDir}${file.separator}" to="* "/>
</pathconvert>
- <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
+ <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
</target>
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by Robert Muir <rc...@gmail.com>.
On Thu, Sep 6, 2012 at 12:18 PM, Erick Erickson <er...@gmail.com> wrote:
> Java files matching anything ending in .jj or .jflex, right?
>
> Yep, I changed one of the java files once, I think McCandless rescued me....
>
> I'll make it so, but just to verify that I'm not going off the deep
> end again, the process will be to modify the .jj or .jflex files to
> remove tabs, regenerate the java and check _both_ back in?
>
I don't think so. I think just ignore the problems in the jflex/javacc
generated code for now, so this means we cannot yet enable the ant
check.
I think the generators themselves are making these tabs, we need to
deal with that separately.
--
lucidworks.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by Erick Erickson <er...@gmail.com>.
Java files matching anything ending in .jj or .jflex, right?
Yep, I changed one of the java files once, I think McCandless rescued me....
I'll make it so, but just to verify that I'm not going off the deep
end again, the process will be to modify the .jj or .jflex files to
remove tabs, regenerate the java and check _both_ back in?
Erick
On Thu, Sep 6, 2012 at 9:05 AM, Erick Erickson (JIRA) <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449766#comment-13449766 ]
>
> Erick Erickson commented on LUCENE-4362:
> ----------------------------------------
>
> OK, my test failures apparently related to this patch, I'm getting the same thing after rolling it all back. I'll post on the dev list.
>
>> ban tab-indented source
>> -----------------------
>>
>> Key: LUCENE-4362
>> URL: https://issues.apache.org/jira/browse/LUCENE-4362
>> Project: Lucene - Core
>> Issue Type: Task
>> Reporter: Robert Muir
>> Assignee: Erick Erickson
>> Attachments: LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch
>>
>>
>> This makes code really difficult to read and work with.
>> Its easy enough to prevent.
>> {noformat}
>> Index: build.xml
>> ===================================================================
>> --- build.xml (revision 1380979)
>> +++ build.xml (working copy)
>> @@ -77,11 +77,12 @@
>> <or>
>> <containsregexp expression="@author\b" casesensitive="yes"/>
>> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
>> + <containsregexp expression="\t" casesensitive="no"/>
>> </or>
>> </fileset>
>> <map from="${validate.currDir}${file.separator}" to="* "/>
>> </pathconvert>
>> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
>> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
>> </target>
>> {noformat}
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
RE: [jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by Uwe Schindler <uw...@thetaphi.de>.
I added you also to Lucene!
-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: uwe@thetaphi.de
> -----Original Message-----
> From: Erick Erickson [mailto:erickerickson@gmail.com]
> Sent: Wednesday, September 05, 2012 6:56 PM
> To: dev@lucene.apache.org
> Subject: Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
>
> I'll be happy to. I got the patches and applied them, but I can't assign the JIRA
> to myself.....
>
> I can in Solr, but in Lucene I don't have the "assign" tab displayed.
> Who do I talk to?
>
> Erick
>
> On Wed, Sep 5, 2012 at 11:57 AM, Robert Muir <rc...@gmail.com> wrote:
> > On Wed, Sep 5, 2012 at 11:04 AM, Erick Erickson <er...@gmail.com>
> wrote:
> >> @Uwe: Right, wasn't thinking, a fairly common happening.....
> >>
> >> Note that this is fairly ugly in that the simple-minded substitution
> >> I did isn't totally right. You get diff lines like:
> >
> > I think the automatic 2-space replacement is fine for "hopeless" files.
> > I updated the patch on LUCENE-4362 with fixes for files that aren't
> > hopeless, just have a few stray tabs.
> > If you want, just assign the issue, but maybe apply that patch before
> > doing anything automatic? I was careful with those files (some had
> > tables etc that should be aligned).
> >
> > --
> > lucidworks.com
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For
> > additional commands, e-mail: dev-help@lucene.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional
> commands, e-mail: dev-help@lucene.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by Erick Erickson <er...@gmail.com>.
Nah, here's my alter ego: http://www.redstate.com/
Anyway, the address I try to use for all this is
Erick.Erickson@gmail.com, thanks
for straightening this out, I just assigned this one to myself. I'll
attach a patch shortly.
Erick
On Wed, Sep 5, 2012 at 11:39 AM, Dawid Weiss
<da...@cs.put.poznan.pl> wrote:
>> Erick.Erickson@gmail.com (that one had permissions), but that either
>
> It's probably Erick's dark side alter ego:
> http://goo.gl/orGMC
>
> Dawid
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by Dawid Weiss <da...@cs.put.poznan.pl>.
> Erick.Erickson@gmail.com (that one had permissions), but that either
It's probably Erick's dark side alter ego:
http://goo.gl/orGMC
Dawid
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
RE: [jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by Uwe Schindler <uw...@thetaphi.de>.
LOL: I added that one because this was the Solr one.
Erick: Just to be sure: what is your account name and eMail address in JIRA?
-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: uwe@thetaphi.de
> -----Original Message-----
> From: Robert Muir [mailto:rcmuir@gmail.com]
> Sent: Wednesday, September 05, 2012 7:02 PM
> To: dev@lucene.apache.org
> Subject: Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
>
> I took care of it. THe problem was 2 Erick Ericksons. one was
> Erick.Erickson@gmail.com (that one had permissions), but that either isn't you,
> or was an old address.
>
> I put your new one in there and disabled access for the other one
>
> On Wed, Sep 5, 2012 at 12:59 PM, Steven A Rowe <sa...@syr.edu> wrote:
> > Hi Erick,
> >
> > I think I can add you to the appropriate group.
> >
> > Trying now.
> >
> > Steve
> >
> > -----Original Message-----
> > From: Erick Erickson [mailto:erickerickson@gmail.com]
> > Sent: Wednesday, September 05, 2012 12:56 PM
> > To: dev@lucene.apache.org
> > Subject: Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
> >
> > I'll be happy to. I got the patches and applied them, but I can't
> > assign the JIRA to myself.....
> >
> > I can in Solr, but in Lucene I don't have the "assign" tab displayed.
> > Who do I talk to?
> >
> > Erick
> >
> > On Wed, Sep 5, 2012 at 11:57 AM, Robert Muir <rc...@gmail.com> wrote:
> >> On Wed, Sep 5, 2012 at 11:04 AM, Erick Erickson
> <er...@gmail.com> wrote:
> >>> @Uwe: Right, wasn't thinking, a fairly common happening.....
> >>>
> >>> Note that this is fairly ugly in that the simple-minded substitution
> >>> I did isn't totally right. You get diff lines like:
> >>
> >> I think the automatic 2-space replacement is fine for "hopeless" files.
> >> I updated the patch on LUCENE-4362 with fixes for files that aren't
> >> hopeless, just have a few stray tabs.
> >> If you want, just assign the issue, but maybe apply that patch before
> >> doing anything automatic? I was careful with those files (some had
> >> tables etc that should be aligned).
> >>
> >> --
> >> lucidworks.com
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For
> >> additional commands, e-mail: dev-help@lucene.apache.org
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For
> > additional commands, e-mail: dev-help@lucene.apache.org
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For
> > additional commands, e-mail: dev-help@lucene.apache.org
> >
>
>
>
> --
> lucidworks.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional
> commands, e-mail: dev-help@lucene.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
RE: [jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by Steven A Rowe <sa...@syr.edu>.
I was wondering why Erick's name was already in the Administrators group...
Thanks Robert.
-----Original Message-----
From: Robert Muir [mailto:rcmuir@gmail.com]
Sent: Wednesday, September 05, 2012 1:02 PM
To: dev@lucene.apache.org
Subject: Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
I took care of it. THe problem was 2 Erick Ericksons. one was
Erick.Erickson@gmail.com (that one had permissions), but that either
isn't you, or was an old address.
I put your new one in there and disabled access for the other one
On Wed, Sep 5, 2012 at 12:59 PM, Steven A Rowe <sa...@syr.edu> wrote:
> Hi Erick,
>
> I think I can add you to the appropriate group.
>
> Trying now.
>
> Steve
>
> -----Original Message-----
> From: Erick Erickson [mailto:erickerickson@gmail.com]
> Sent: Wednesday, September 05, 2012 12:56 PM
> To: dev@lucene.apache.org
> Subject: Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
>
> I'll be happy to. I got the patches and applied them, but I can't
> assign the JIRA to myself.....
>
> I can in Solr, but in Lucene I don't have the "assign" tab displayed.
> Who do I talk to?
>
> Erick
>
> On Wed, Sep 5, 2012 at 11:57 AM, Robert Muir <rc...@gmail.com> wrote:
>> On Wed, Sep 5, 2012 at 11:04 AM, Erick Erickson <er...@gmail.com> wrote:
>>> @Uwe: Right, wasn't thinking, a fairly common happening.....
>>>
>>> Note that this is fairly ugly in that the simple-minded substitution
>>> I did isn't totally right. You get diff lines like:
>>
>> I think the automatic 2-space replacement is fine for "hopeless" files.
>> I updated the patch on LUCENE-4362 with fixes for files that aren't
>> hopeless, just have a few stray tabs.
>> If you want, just assign the issue, but maybe apply that patch before
>> doing anything automatic? I was careful with those files (some had
>> tables etc that should be aligned).
>>
>> --
>> lucidworks.com
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
--
lucidworks.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by Robert Muir <rc...@gmail.com>.
I took care of it. THe problem was 2 Erick Ericksons. one was
Erick.Erickson@gmail.com (that one had permissions), but that either
isn't you, or was an old address.
I put your new one in there and disabled access for the other one
On Wed, Sep 5, 2012 at 12:59 PM, Steven A Rowe <sa...@syr.edu> wrote:
> Hi Erick,
>
> I think I can add you to the appropriate group.
>
> Trying now.
>
> Steve
>
> -----Original Message-----
> From: Erick Erickson [mailto:erickerickson@gmail.com]
> Sent: Wednesday, September 05, 2012 12:56 PM
> To: dev@lucene.apache.org
> Subject: Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
>
> I'll be happy to. I got the patches and applied them, but I can't
> assign the JIRA to myself.....
>
> I can in Solr, but in Lucene I don't have the "assign" tab displayed.
> Who do I talk to?
>
> Erick
>
> On Wed, Sep 5, 2012 at 11:57 AM, Robert Muir <rc...@gmail.com> wrote:
>> On Wed, Sep 5, 2012 at 11:04 AM, Erick Erickson <er...@gmail.com> wrote:
>>> @Uwe: Right, wasn't thinking, a fairly common happening.....
>>>
>>> Note that this is fairly ugly in that the simple-minded substitution
>>> I did isn't totally right. You get diff lines like:
>>
>> I think the automatic 2-space replacement is fine for "hopeless" files.
>> I updated the patch on LUCENE-4362 with fixes for files that aren't
>> hopeless, just have a few stray tabs.
>> If you want, just assign the issue, but maybe apply that patch before
>> doing anything automatic? I was careful with those files (some had
>> tables etc that should be aligned).
>>
>> --
>> lucidworks.com
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
--
lucidworks.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
RE: [jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by Steven A Rowe <sa...@syr.edu>.
Hi Erick,
I think I can add you to the appropriate group.
Trying now.
Steve
-----Original Message-----
From: Erick Erickson [mailto:erickerickson@gmail.com]
Sent: Wednesday, September 05, 2012 12:56 PM
To: dev@lucene.apache.org
Subject: Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
I'll be happy to. I got the patches and applied them, but I can't
assign the JIRA to myself.....
I can in Solr, but in Lucene I don't have the "assign" tab displayed.
Who do I talk to?
Erick
On Wed, Sep 5, 2012 at 11:57 AM, Robert Muir <rc...@gmail.com> wrote:
> On Wed, Sep 5, 2012 at 11:04 AM, Erick Erickson <er...@gmail.com> wrote:
>> @Uwe: Right, wasn't thinking, a fairly common happening.....
>>
>> Note that this is fairly ugly in that the simple-minded substitution
>> I did isn't totally right. You get diff lines like:
>
> I think the automatic 2-space replacement is fine for "hopeless" files.
> I updated the patch on LUCENE-4362 with fixes for files that aren't
> hopeless, just have a few stray tabs.
> If you want, just assign the issue, but maybe apply that patch before
> doing anything automatic? I was careful with those files (some had
> tables etc that should be aligned).
>
> --
> lucidworks.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by Erick Erickson <er...@gmail.com>.
I'll be happy to. I got the patches and applied them, but I can't
assign the JIRA to myself.....
I can in Solr, but in Lucene I don't have the "assign" tab displayed.
Who do I talk to?
Erick
On Wed, Sep 5, 2012 at 11:57 AM, Robert Muir <rc...@gmail.com> wrote:
> On Wed, Sep 5, 2012 at 11:04 AM, Erick Erickson <er...@gmail.com> wrote:
>> @Uwe: Right, wasn't thinking, a fairly common happening.....
>>
>> Note that this is fairly ugly in that the simple-minded substitution
>> I did isn't totally right. You get diff lines like:
>
> I think the automatic 2-space replacement is fine for "hopeless" files.
> I updated the patch on LUCENE-4362 with fixes for files that aren't
> hopeless, just have a few stray tabs.
> If you want, just assign the issue, but maybe apply that patch before
> doing anything automatic? I was careful with those files (some had
> tables etc that should be aligned).
>
> --
> lucidworks.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by Robert Muir <rc...@gmail.com>.
On Wed, Sep 5, 2012 at 11:04 AM, Erick Erickson <er...@gmail.com> wrote:
> @Uwe: Right, wasn't thinking, a fairly common happening.....
>
> Note that this is fairly ugly in that the simple-minded substitution
> I did isn't totally right. You get diff lines like:
I think the automatic 2-space replacement is fine for "hopeless" files.
I updated the patch on LUCENE-4362 with fixes for files that aren't
hopeless, just have a few stray tabs.
If you want, just assign the issue, but maybe apply that patch before
doing anything automatic? I was careful with those files (some had
tables etc that should be aligned).
--
lucidworks.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by Erick Erickson <er...@gmail.com>.
@Uwe: Right, wasn't thinking, a fairly common happening.....
Note that this is fairly ugly in that the simple-minded substitution
I did isn't totally right. You get diff lines like:
return new FloatDocValues(this) {
@Override
public float floatVal(int doc) {
- return func(doc, vals);
+ return func(doc, vals);
}
@Override
public String toString(int doc) {
- return name() + '(' + vals.toString(doc) + ')';
+ return name() + '(' + vals.toString(doc) + ')';
}
};
}
where the tab stops were other than 2 spaces. Unfortunately, I think the
alternative is to reformat all the files where this substitution was done
or go through by hand and do them all. And I'm really reluctant to volunteer
to fix over 8,000 of these by hand.
I'd _like_ to reformat all the files, but we all know the problems
there. I propose
that if nobody (or not enough people) object, I'll check them in with the
ugly indentation and the bad indents can be fixed when people are working
on the specific sections of code. At least it's progress.
Or if the consensus is to reformat the offending files I can do that. Tedious
but not that time-consuming.
Let me know...
On Wed, Sep 5, 2012 at 9:50 AM, Robert Muir <rc...@gmail.com> wrote:
> No it didnt. these classes do not exist in trunk.
>
> On Wed, Sep 5, 2012 at 8:37 AM, Erick Erickson <er...@gmail.com> wrote:
>> Interestingly, this check missed the FrenchStemFilter.java (and I
>> don't know what others)
>> that found tabs by doing a quick search of the Lucene source tree.
>> Does the ant task
>> skip deprecated classes?
>>
>> I like the check, I'll see about doing something about the tabs anyway, that's
>> gruntwork after all...
>>
>>
>> On Wed, Sep 5, 2012 at 6:39 AM, Uwe Schindler (JIRA) <ji...@apache.org> wrote:
>>>
>>> [ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448621#comment-13448621 ]
>>>
>>> Uwe Schindler commented on LUCENE-4362:
>>> ---------------------------------------
>>>
>>> Yeah, and with the ANT check, so it is enforced!
>>> If somebody wants to use a tab, e.g. in a string, he can always do \t
>>>
>>>> ban tab-indented source
>>>> -----------------------
>>>>
>>>> Key: LUCENE-4362
>>>> URL: https://issues.apache.org/jira/browse/LUCENE-4362
>>>> Project: Lucene - Core
>>>> Issue Type: Task
>>>> Reporter: Robert Muir
>>>> Attachments: LUCENE-4362_core.patch
>>>>
>>>>
>>>> This makes code really difficult to read and work with.
>>>> Its easy enough to prevent.
>>>> {noformat}
>>>> Index: build.xml
>>>> ===================================================================
>>>> --- build.xml (revision 1380979)
>>>> +++ build.xml (working copy)
>>>> @@ -77,11 +77,12 @@
>>>> <or>
>>>> <containsregexp expression="@author\b" casesensitive="yes"/>
>>>> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
>>>> + <containsregexp expression="\t" casesensitive="no"/>
>>>> </or>
>>>> </fileset>
>>>> <map from="${validate.currDir}${file.separator}" to="* "/>
>>>> </pathconvert>
>>>> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
>>>> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
>>>> </target>
>>>> {noformat}
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> If you think it was sent incorrectly, please contact your JIRA administrators
>>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>
>
>
> --
> lucidworks.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by Robert Muir <rc...@gmail.com>.
No it didnt. these classes do not exist in trunk.
On Wed, Sep 5, 2012 at 8:37 AM, Erick Erickson <er...@gmail.com> wrote:
> Interestingly, this check missed the FrenchStemFilter.java (and I
> don't know what others)
> that found tabs by doing a quick search of the Lucene source tree.
> Does the ant task
> skip deprecated classes?
>
> I like the check, I'll see about doing something about the tabs anyway, that's
> gruntwork after all...
>
>
> On Wed, Sep 5, 2012 at 6:39 AM, Uwe Schindler (JIRA) <ji...@apache.org> wrote:
>>
>> [ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448621#comment-13448621 ]
>>
>> Uwe Schindler commented on LUCENE-4362:
>> ---------------------------------------
>>
>> Yeah, and with the ANT check, so it is enforced!
>> If somebody wants to use a tab, e.g. in a string, he can always do \t
>>
>>> ban tab-indented source
>>> -----------------------
>>>
>>> Key: LUCENE-4362
>>> URL: https://issues.apache.org/jira/browse/LUCENE-4362
>>> Project: Lucene - Core
>>> Issue Type: Task
>>> Reporter: Robert Muir
>>> Attachments: LUCENE-4362_core.patch
>>>
>>>
>>> This makes code really difficult to read and work with.
>>> Its easy enough to prevent.
>>> {noformat}
>>> Index: build.xml
>>> ===================================================================
>>> --- build.xml (revision 1380979)
>>> +++ build.xml (working copy)
>>> @@ -77,11 +77,12 @@
>>> <or>
>>> <containsregexp expression="@author\b" casesensitive="yes"/>
>>> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
>>> + <containsregexp expression="\t" casesensitive="no"/>
>>> </or>
>>> </fileset>
>>> <map from="${validate.currDir}${file.separator}" to="* "/>
>>> </pathconvert>
>>> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
>>> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
>>> </target>
>>> {noformat}
>>
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA administrators
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
--
lucidworks.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
RE: [jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by Uwe Schindler <uw...@thetaphi.de>.
Erick: There is an issue about this:
https://issues.apache.org/jira/browse/LUCENE-4362
-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: uwe@thetaphi.de
> -----Original Message-----
> From: Erick Erickson [mailto:erickerickson@gmail.com]
> Sent: Wednesday, September 05, 2012 3:03 PM
> To: dev@lucene.apache.org
> Subject: Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
>
> OK, through the miracles of modern IDEs I can make all the changes (for tabs
> only) in just a few minutes, running tests now...
>
> NOTE: this is just the java files, and a really stupid substitution of two spaces for
> each and every tab. No, I didn't just reformat the whole source tree, though it
> was tempting I'll admit<G>...
>
> BUT. The freaking patch is 900K for 4x, and it touches 190 java files. I'll be
> happy to check all this in, but there's a lot of code out in branches, Git, what
> have you, and I want to give it a couple of days for people to object before
> possibly introducing a reconciliation nightmare.
>
> If nobody objects by the weekend, I'll just commit (I'll create a JIRA) both for 4x
> and trunk.
>
> So a patch is indicated after all I think?
>
> Let me know....
>
> On Wed, Sep 5, 2012 at 8:39 AM, Erick Erickson <er...@gmail.com>
> wrote:
> > I'm claiming that fixing tabs isn't worth patch files, although maybe
> > a JIRA to track progress, agree?
> >
> > On Wed, Sep 5, 2012 at 8:37 AM, Erick Erickson <er...@gmail.com>
> wrote:
> >> Interestingly, this check missed the FrenchStemFilter.java (and I
> >> don't know what others) that found tabs by doing a quick search of
> >> the Lucene source tree.
> >> Does the ant task
> >> skip deprecated classes?
> >>
> >> I like the check, I'll see about doing something about the tabs
> >> anyway, that's gruntwork after all...
> >>
> >>
> >> On Wed, Sep 5, 2012 at 6:39 AM, Uwe Schindler (JIRA) <ji...@apache.org>
> wrote:
> >>>
> >>> [
> >>> https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian
> >>> .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId
> >>> =13448621#comment-13448621 ]
> >>>
> >>> Uwe Schindler commented on LUCENE-4362:
> >>> ---------------------------------------
> >>>
> >>> Yeah, and with the ANT check, so it is enforced!
> >>> If somebody wants to use a tab, e.g. in a string, he can always do
> >>> \t
> >>>
> >>>> ban tab-indented source
> >>>> -----------------------
> >>>>
> >>>> Key: LUCENE-4362
> >>>> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> >>>> Project: Lucene - Core
> >>>> Issue Type: Task
> >>>> Reporter: Robert Muir
> >>>> Attachments: LUCENE-4362_core.patch
> >>>>
> >>>>
> >>>> This makes code really difficult to read and work with.
> >>>> Its easy enough to prevent.
> >>>> {noformat}
> >>>> Index: build.xml
> >>>>
> ================================================================
> ===
> >>>> --- build.xml (revision 1380979)
> >>>> +++ build.xml (working copy)
> >>>> @@ -77,11 +77,12 @@
> >>>> <or>
> >>>> <containsregexp expression="@author\b" casesensitive="yes"/>
> >>>> <containsregexp expression="\bno(n|)commit\b"
> >>>> casesensitive="no"/>
> >>>> + <containsregexp expression="\t" casesensitive="no"/>
> >>>> </or>
> >>>> </fileset>
> >>>> <map from="${validate.currDir}${file.separator}" to="* "/>
> >>>> </pathconvert>
> >>>> - <fail if="validate.patternsFound">The following files contain @author
> tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> >>>> + <fail if="validate.patternsFound">The following files contain
> >>>> + @author tags, tabs or
> >>>> + nocommits:${line.separator}${validate.patternsFound}</fail>
> >>>> </target>
> >>>> {noformat}
> >>>
> >>> --
> >>> This message is automatically generated by JIRA.
> >>> If you think it was sent incorrectly, please contact your JIRA
> >>> administrators For more information on JIRA, see:
> >>> http://www.atlassian.com/software/jira
> >>>
> >>> --------------------------------------------------------------------
> >>> - To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For
> >>> additional commands, e-mail: dev-help@lucene.apache.org
> >>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional
> commands, e-mail: dev-help@lucene.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by Robert Muir <rc...@gmail.com>.
On Wed, Sep 5, 2012 at 9:03 AM, Erick Erickson <er...@gmail.com> wrote:
> OK, through the miracles of modern IDEs I can make all the
> changes (for tabs only) in just a few minutes, running tests now...
>
> NOTE: this is just the java files, and a really stupid substitution
> of two spaces for each and every tab. No, I didn't just reformat
> the whole source tree, though it was tempting I'll admit<G>...
>
> BUT. The freaking patch is 900K for 4x, and it touches 190 java
> files. I'll be happy to check all this in, but there's a lot of code out
> in branches, Git, what have you, and I want to give it a couple of
> days for people to object before possibly introducing a reconciliation
> nightmare.
>
> If nobody objects by the weekend, I'll just commit (I'll create a JIRA)
> both for 4x and trunk.
get rid of the tabs please!
My only concern is that some of this is generated files: e.g. jflex
generated. we shouldnt do anything to this generated code directly.
--
lucidworks.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by Erick Erickson <er...@gmail.com>.
OK, through the miracles of modern IDEs I can make all the
changes (for tabs only) in just a few minutes, running tests now...
NOTE: this is just the java files, and a really stupid substitution
of two spaces for each and every tab. No, I didn't just reformat
the whole source tree, though it was tempting I'll admit<G>...
BUT. The freaking patch is 900K for 4x, and it touches 190 java
files. I'll be happy to check all this in, but there's a lot of code out
in branches, Git, what have you, and I want to give it a couple of
days for people to object before possibly introducing a reconciliation
nightmare.
If nobody objects by the weekend, I'll just commit (I'll create a JIRA)
both for 4x and trunk.
So a patch is indicated after all I think?
Let me know....
On Wed, Sep 5, 2012 at 8:39 AM, Erick Erickson <er...@gmail.com> wrote:
> I'm claiming that fixing tabs isn't worth patch files, although maybe
> a JIRA to track progress, agree?
>
> On Wed, Sep 5, 2012 at 8:37 AM, Erick Erickson <er...@gmail.com> wrote:
>> Interestingly, this check missed the FrenchStemFilter.java (and I
>> don't know what others)
>> that found tabs by doing a quick search of the Lucene source tree.
>> Does the ant task
>> skip deprecated classes?
>>
>> I like the check, I'll see about doing something about the tabs anyway, that's
>> gruntwork after all...
>>
>>
>> On Wed, Sep 5, 2012 at 6:39 AM, Uwe Schindler (JIRA) <ji...@apache.org> wrote:
>>>
>>> [ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448621#comment-13448621 ]
>>>
>>> Uwe Schindler commented on LUCENE-4362:
>>> ---------------------------------------
>>>
>>> Yeah, and with the ANT check, so it is enforced!
>>> If somebody wants to use a tab, e.g. in a string, he can always do \t
>>>
>>>> ban tab-indented source
>>>> -----------------------
>>>>
>>>> Key: LUCENE-4362
>>>> URL: https://issues.apache.org/jira/browse/LUCENE-4362
>>>> Project: Lucene - Core
>>>> Issue Type: Task
>>>> Reporter: Robert Muir
>>>> Attachments: LUCENE-4362_core.patch
>>>>
>>>>
>>>> This makes code really difficult to read and work with.
>>>> Its easy enough to prevent.
>>>> {noformat}
>>>> Index: build.xml
>>>> ===================================================================
>>>> --- build.xml (revision 1380979)
>>>> +++ build.xml (working copy)
>>>> @@ -77,11 +77,12 @@
>>>> <or>
>>>> <containsregexp expression="@author\b" casesensitive="yes"/>
>>>> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
>>>> + <containsregexp expression="\t" casesensitive="no"/>
>>>> </or>
>>>> </fileset>
>>>> <map from="${validate.currDir}${file.separator}" to="* "/>
>>>> </pathconvert>
>>>> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
>>>> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
>>>> </target>
>>>> {noformat}
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> If you think it was sent incorrectly, please contact your JIRA administrators
>>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by Erick Erickson <er...@gmail.com>.
I'm claiming that fixing tabs isn't worth patch files, although maybe
a JIRA to track progress, agree?
On Wed, Sep 5, 2012 at 8:37 AM, Erick Erickson <er...@gmail.com> wrote:
> Interestingly, this check missed the FrenchStemFilter.java (and I
> don't know what others)
> that found tabs by doing a quick search of the Lucene source tree.
> Does the ant task
> skip deprecated classes?
>
> I like the check, I'll see about doing something about the tabs anyway, that's
> gruntwork after all...
>
>
> On Wed, Sep 5, 2012 at 6:39 AM, Uwe Schindler (JIRA) <ji...@apache.org> wrote:
>>
>> [ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448621#comment-13448621 ]
>>
>> Uwe Schindler commented on LUCENE-4362:
>> ---------------------------------------
>>
>> Yeah, and with the ANT check, so it is enforced!
>> If somebody wants to use a tab, e.g. in a string, he can always do \t
>>
>>> ban tab-indented source
>>> -----------------------
>>>
>>> Key: LUCENE-4362
>>> URL: https://issues.apache.org/jira/browse/LUCENE-4362
>>> Project: Lucene - Core
>>> Issue Type: Task
>>> Reporter: Robert Muir
>>> Attachments: LUCENE-4362_core.patch
>>>
>>>
>>> This makes code really difficult to read and work with.
>>> Its easy enough to prevent.
>>> {noformat}
>>> Index: build.xml
>>> ===================================================================
>>> --- build.xml (revision 1380979)
>>> +++ build.xml (working copy)
>>> @@ -77,11 +77,12 @@
>>> <or>
>>> <containsregexp expression="@author\b" casesensitive="yes"/>
>>> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
>>> + <containsregexp expression="\t" casesensitive="no"/>
>>> </or>
>>> </fileset>
>>> <map from="${validate.currDir}${file.separator}" to="* "/>
>>> </pathconvert>
>>> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
>>> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
>>> </target>
>>> {noformat}
>>
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA administrators
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by Erick Erickson <er...@gmail.com>.
Interestingly, this check missed the FrenchStemFilter.java (and I
don't know what others)
that found tabs by doing a quick search of the Lucene source tree.
Does the ant task
skip deprecated classes?
I like the check, I'll see about doing something about the tabs anyway, that's
gruntwork after all...
On Wed, Sep 5, 2012 at 6:39 AM, Uwe Schindler (JIRA) <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448621#comment-13448621 ]
>
> Uwe Schindler commented on LUCENE-4362:
> ---------------------------------------
>
> Yeah, and with the ANT check, so it is enforced!
> If somebody wants to use a tab, e.g. in a string, he can always do \t
>
>> ban tab-indented source
>> -----------------------
>>
>> Key: LUCENE-4362
>> URL: https://issues.apache.org/jira/browse/LUCENE-4362
>> Project: Lucene - Core
>> Issue Type: Task
>> Reporter: Robert Muir
>> Attachments: LUCENE-4362_core.patch
>>
>>
>> This makes code really difficult to read and work with.
>> Its easy enough to prevent.
>> {noformat}
>> Index: build.xml
>> ===================================================================
>> --- build.xml (revision 1380979)
>> +++ build.xml (working copy)
>> @@ -77,11 +77,12 @@
>> <or>
>> <containsregexp expression="@author\b" casesensitive="yes"/>
>> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
>> + <containsregexp expression="\t" casesensitive="no"/>
>> </or>
>> </fileset>
>> <map from="${validate.currDir}${file.separator}" to="* "/>
>> </pathconvert>
>> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
>> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
>> </target>
>> {noformat}
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4362) ban tab-indented source
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson updated LUCENE-4362:
-----------------------------------
Attachment: (was: LUCENE-4326_trunk.patch)
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Fix For: 5.0, 4.0
>
> Attachments: LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch, LUCENE-4362_trunk.patch, LUCENE-4362_trunk.patch, LUCENE-4362_trunk.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449766#comment-13449766 ]
Erick Erickson commented on LUCENE-4362:
----------------------------------------
OK, my test failures apparently related to this patch, I'm getting the same thing after rolling it all back. I'll post on the dev list.
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4362) ban tab-indented source
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson updated LUCENE-4362:
-----------------------------------
Fix Version/s: 4.0
5.0
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Fix For: 5.0, 4.0
>
> Attachments: LUCENE-4326_trunk.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch, LUCENE-4362_trunk.patch, LUCENE-4362_trunk.patch, LUCENE-4362_trunk.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453396#comment-13453396 ]
Steven Rowe commented on LUCENE-4362:
-------------------------------------
{quote}
There's also a section of comments that's tabbed in the generated file, it may very well be the same issue of introducing tabs in the comments...
...../trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/parser/StandardSyntaxParser.java
{quote}
queryparser uses JavaCC, not JFlex, right?
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4326_trunk.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453393#comment-13453393 ]
Erick Erickson commented on LUCENE-4362:
----------------------------------------
There's also a section of comments that's tabbed in the generated file, it may very well be the same issue of introducing tabs in the comments...
...../trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/parser/StandardSyntaxParser.java
{noformat}
// QueryNode Query(CharSequence field) :
// {
// List clauses = new ArrayList();
// List modifiers = new ArrayList();
// QueryNode q, firstQuery=null;
// ModifierQueryNode.Modifier mods;
// int conj;
// }
// {
// mods=Modifiers() q=Clause(field)
// {
// if (mods == ModifierQueryNode.Modifier.MOD_NONE) firstQuery=q;
//
// // do not create modifier nodes with MOD_NONE
// if (mods != ModifierQueryNode.Modifier.MOD_NONE) {
// q = new ModifierQueryNode(q, mods);
// }
// clauses.add(q);
// }
// (
// conj=Conjunction() mods=Modifiers() q=Clause(field)
// {
// // do not create modifier nodes with MOD_NONE
// if (mods != ModifierQueryNode.Modifier.MOD_NONE) {
// q = new ModifierQueryNode(q, mods);
// }
// clauses.add(q);
// //TODO: figure out what to do with AND and ORs
// }
// )*
// {
// if (clauses.size() == 1 && firstQuery != null)
// return firstQuery;
// else {
// return new BooleanQueryNode(clauses);
// }
// }
// }
{noformat}
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4326_trunk.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4362) ban tab-indented source
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson updated LUCENE-4362:
-----------------------------------
Attachment: LUCENE-4362_trunk.patch
LUCENE-4362_4x.patch
Final patch, will commit momentarily
Thanks Steve! All tabs generated by jflex are now gone.
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4326_trunk.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch, LUCENE-4362_trunk.patch, LUCENE-4362_trunk.patch, LUCENE-4362_trunk.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by "Jack Krupansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457059#comment-13457059 ]
Jack Krupansky commented on LUCENE-4362:
----------------------------------------
Is this issue for 5.0 only or for 4.0 as well? No "Fix Version" is listed, but I do see a "4x" patch.
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4326_trunk.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch, LUCENE-4362_trunk.patch, LUCENE-4362_trunk.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4362) ban tab-indented source
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-4362:
--------------------------------
Attachment: LUCENE-4362_core.patch
Here's a start. I did lucene/core src only.
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Attachments: LUCENE-4362_core.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451387#comment-13451387 ]
Erick Erickson commented on LUCENE-4362:
----------------------------------------
Robert:
You're right in that a number of tabs are introduced into the generated files, I'll leave those for another day.
So, I didn't change any of the .java files that had a corresponding .jj or .jflex file, but I did try to run the "ant jflex" target in lucene/analysis/common after taking out all the tabs in the .jj or .jflex files. I figure that that's worth doing separate from fixing the injected tabs. Unfortunately I keep getting
jflex-UAX29URLEmailTokenizer:
[jflex]
[jflex] Error: JFlex has run out of memory. Please try increasing the maximum JVM heap size
[jflex]
. What's the magic to increase the JVM heap? Or should I just not bother?
I tried setting ANT_OPTS JAVA_OPTS, changing the jflex script in <jflex_home>/jflex/bin to $JAVA -Xmx2G JFlex.Main $@, and I keep getting the same error. Which means there's an incredibly simple way to do this that I don't know about......
Any hints?
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Assigned] (LUCENE-4362) ban tab-indented source
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson reassigned LUCENE-4362:
--------------------------------------
Assignee: Erick Erickson
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4362_core.patch, LUCENE-4362.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453369#comment-13453369 ]
Robert Muir commented on LUCENE-4362:
-------------------------------------
{quote}
Any suggestions about what to do about tabs introduced into generated files?
{quote}
Well as a workaround, we can add a replace-regexp to the ant that generates them.
But e.g. in the jflex case it seemed like the tab was not intentional (just a comment) so we
can probably just ask them if they can fix it for the long term.
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4326_trunk.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453371#comment-13453371 ]
Steven Rowe commented on LUCENE-4362:
-------------------------------------
bq. But e.g. in the jflex case it seemed like the tab was not intentional (just a comment) so we can probably just ask them if they can fix it for the long term.
I'm one of them - I'll take a look.
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4326_trunk.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456577#comment-13456577 ]
Uwe Schindler commented on LUCENE-4362:
---------------------------------------
But Steven fixed JFlex? Maybe you must update your JFlex checkout and rebuild with maven?
Otherwise +1 to commit (the generated files are checked in, yes, and need to be regenerated). But when regenerating, check that the output looks almost the same, just to be sure that you are not using the wrong version. JavaCC is hard linked to a IVY-Download with specific version, but JFlex is trunk, so take care of unwanted changes, e.g. introduced by too old versions!
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4326_trunk.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch, LUCENE-4362_trunk.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4362) ban tab-indented source
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson updated LUCENE-4362:
-----------------------------------
Attachment: LUCENE-4362_4x.patch
OK, after waiting 50 minutes for the tests to complete, all tests pass with these two patches (trunk and 4x).
So if I check all this in, it'll change the generated java files since they were newly generated from the changes to the jflex/jj files. Is this the usual procedure?
This doesn't address the tabs introduced by the parser compilers.
If no one objects, I'll check this in probably tonight or tomorrow.
But I'd still like to keep this open even so. Between last week and now more tabs have been introduced into source.
Any suggestions about what to do about tabs introduced into generated files?
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4326_trunk.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448621#comment-13448621 ]
Uwe Schindler commented on LUCENE-4362:
---------------------------------------
Yeah, and with the ANT check, so it is enforced!
If somebody wants to use a tab, e.g. in a string, he can always do \t
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Attachments: LUCENE-4362_core.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457118#comment-13457118 ]
Robert Muir commented on LUCENE-4362:
-------------------------------------
Erick: I committed the checks to build.xml: passes on both branches.
Bye bye tabs!
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Fix For: 5.0, 4.0
>
> Attachments: LUCENE-4326_trunk.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch, LUCENE-4362_trunk.patch, LUCENE-4362_trunk.patch, LUCENE-4362_trunk.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457099#comment-13457099 ]
Robert Muir commented on LUCENE-4362:
-------------------------------------
Thanks for taking ahold of this Erick!
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4326_trunk.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch, LUCENE-4362_trunk.patch, LUCENE-4362_trunk.patch, LUCENE-4362_trunk.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-4362) ban tab-indented source
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson resolved LUCENE-4362.
------------------------------------
Resolution: Fixed
committed:
4x: 1386675
trunk: 1386681
Can we add the check real soon now? Tabs seem to creep in quite regularly.
It's probably a good idea to update, there are lots and lots and lots of files this touches.
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4326_trunk.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch, LUCENE-4362_trunk.patch, LUCENE-4362_trunk.patch, LUCENE-4362_trunk.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448619#comment-13448619 ]
Michael McCandless commented on LUCENE-4362:
--------------------------------------------
+1
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Attachments: LUCENE-4362_core.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456617#comment-13456617 ]
Steven Rowe commented on LUCENE-4362:
-------------------------------------
bq. But Steven fixed JFlex?
Well, I fixed the non-fixed-case-order problem, but not the tabs-in-generated-source problem.
So while the case order you see in sources generated with current trunk JFlex will be different from previously checked in Jflex-generated code, it should be stable from now on.
I'll work on tabs in generated code today, Erick, so could you hold off a little before checking in?
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4326_trunk.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch, LUCENE-4362_trunk.patch, LUCENE-4362_trunk.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4362) ban tab-indented source
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-4362:
--------------------------------
Attachment: LUCENE-4362.patch
updated patch to trunk, and fixed a few more files with just stray tabs.
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Attachments: LUCENE-4362_core.patch, LUCENE-4362.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456975#comment-13456975 ]
Steven Rowe commented on LUCENE-4362:
-------------------------------------
I got rid of the tab in front of the "{{// numRead < 0}}" comment - update JFlex to rev 615 and {{mvn install}}.
Erick, I applied your patch on trunk, regenerated all jflex-based sources, and then ran {{ant validate}} patched to complain about tabs, and the build was successful.
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4326_trunk.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch, LUCENE-4362_trunk.patch, LUCENE-4362_trunk.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456669#comment-13456669 ]
Erick Erickson commented on LUCENE-4362:
----------------------------------------
Steve:
Sure, just let me know when things are ready.
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4326_trunk.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch, LUCENE-4362_trunk.patch, LUCENE-4362_trunk.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448474#comment-13448474 ]
Robert Muir commented on LUCENE-4362:
-------------------------------------
{noformat}
BUILD FAILED
/home/rmuir/workspace/lucene-trunk/build.xml:85: The following files contain @author tags, tabs or nocommits:
* lucene/analysis/common/src/java/org/apache/lucene/analysis/br/BrazilianAnalyzer.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/br/BrazilianStemmer.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/charfilter/HTMLStripCharFilter.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/compound/DictionaryCompoundWordTokenFilterFactory.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/compound/HyphenationCompoundWordTokenFilterFactory.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/cz/CzechAnalyzer.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/CapitalizationFilterFactory.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/HyphenatedWordsFilter.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/HyphenatedWordsFilterFactory.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/path/PathHierarchyTokenizerFactory.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/query/QueryAutoStopWordAnalyzer.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/shingle/ShingleFilter.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/standard/ClassicTokenizerImpl.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/standard/StandardTokenizerImpl.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/standard/UAX29URLEmailTokenizerImpl.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/wikipedia/WikipediaTokenizerImpl.java
* lucene/analysis/common/src/java/org/tartarus/snowball/Among.java
* lucene/analysis/common/src/java/org/tartarus/snowball/SnowballProgram.java
* lucene/analysis/common/src/test/org/apache/lucene/analysis/br/TestBrazilianStemmer.java
* lucene/analysis/common/src/test/org/apache/lucene/analysis/core/WordBreakTestUnicode_6_1_0.java
* lucene/analysis/common/src/test/org/apache/lucene/analysis/el/GreekAnalyzerTest.java
* lucene/analysis/common/src/test/org/apache/lucene/analysis/fr/TestFrenchAnalyzer.java
* lucene/analysis/common/src/test/org/apache/lucene/analysis/miscellaneous/TestHyphenatedWordsFilter.java
* lucene/analysis/common/src/test/org/apache/lucene/analysis/nl/TestDutchStemmer.java
* lucene/analysis/common/src/test/org/apache/lucene/analysis/pattern/TestPatternTokenizer.java
* lucene/analysis/common/src/test/org/apache/lucene/analysis/th/TestThaiAnalyzer.java
* lucene/analysis/common/src/test/org/apache/lucene/analysis/util/TestWordlistLoader.java
* lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseTokenizer.java
* lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/BinaryDictionary.java
* lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/Dictionary.java
* lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/UnknownDictionary.java
* lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/UserDictionary.java
* lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/util/CSVUtil.java
* lucene/analysis/kuromoji/src/test/org/apache/lucene/analysis/ja/TestJapaneseTokenizer.java
* lucene/analysis/kuromoji/src/test/org/apache/lucene/analysis/ja/dict/UserDictionaryTest.java
* lucene/analysis/kuromoji/src/tools/java/org/apache/lucene/analysis/ja/util/TokenInfoDictionaryBuilder.java
* lucene/analysis/kuromoji/src/tools/java/org/apache/lucene/analysis/ja/util/UnknownDictionaryBuilder.java
* lucene/analysis/phonetic/src/test/org/apache/lucene/analysis/phonetic/TestPhoneticFilterFactory.java
* lucene/analysis/smartcn/src/java/org/apache/lucene/analysis/cn/smart/hhmm/AbstractDictionary.java
* lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/utils/StreamUtils.java
* lucene/benchmark/src/test/org/apache/lucene/benchmark/byTask/tasks/WriteLineDocTaskTest.java
* lucene/benchmark/src/test/org/apache/lucene/benchmark/byTask/utils/StreamUtilsTest.java
* lucene/core/src/java/org/apache/lucene/codecs/FixedGapTermsIndexReader.java
* lucene/core/src/java/org/apache/lucene/codecs/lucene40/BitVector.java
* lucene/core/src/java/org/apache/lucene/index/CheckIndex.java
* lucene/core/src/java/org/apache/lucene/index/DocumentsWriterFlushControl.java
* lucene/core/src/java/org/apache/lucene/index/IndexFileDeleter.java
* lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
* lucene/core/src/java/org/apache/lucene/index/SegmentInfo.java
* lucene/core/src/java/org/apache/lucene/search/BooleanQuery.java
* lucene/core/src/java/org/apache/lucene/search/FieldCache.java
* lucene/core/src/java/org/apache/lucene/search/FieldCacheImpl.java
* lucene/core/src/java/org/apache/lucene/search/FilteredDocIdSetIterator.java
* lucene/core/src/java/org/apache/lucene/search/MultiPhraseQuery.java
* lucene/core/src/java/org/apache/lucene/search/PhrasePositions.java
* lucene/core/src/java/org/apache/lucene/search/PhraseQuery.java
* lucene/core/src/java/org/apache/lucene/search/payloads/MinPayloadFunction.java
* lucene/core/src/java/org/apache/lucene/search/payloads/PayloadFunction.java
* lucene/core/src/java/org/apache/lucene/search/payloads/PayloadNearQuery.java
* lucene/core/src/java/org/apache/lucene/search/spans/NearSpansOrdered.java
* lucene/core/src/java/org/apache/lucene/search/spans/NearSpansUnordered.java
* lucene/core/src/java/org/apache/lucene/search/spans/SpanNearQuery.java
* lucene/core/src/java/org/apache/lucene/search/spans/SpanPositionCheckQuery.java
* lucene/core/src/java/org/apache/lucene/search/spans/Spans.java
* lucene/core/src/java/org/apache/lucene/store/BufferedIndexInput.java
* lucene/core/src/java/org/apache/lucene/store/Lock.java
* lucene/core/src/java/org/apache/lucene/util/Constants.java
* lucene/core/src/java/org/apache/lucene/util/PriorityQueue.java
* lucene/core/src/test/org/apache/lucene/index/TestLongPostings.java
* lucene/core/src/test/org/apache/lucene/index/TestParallelReaderEmptyIndex.java
* lucene/core/src/test/org/apache/lucene/index/TestSameTokenSamePosition.java
* lucene/core/src/test/org/apache/lucene/index/TestTransactionRollback.java
* lucene/core/src/test/org/apache/lucene/index/TestTransactions.java
* lucene/core/src/test/org/apache/lucene/search/TestCachingCollector.java
* lucene/core/src/test/org/apache/lucene/search/TestDocIdSet.java
* lucene/core/src/test/org/apache/lucene/search/TestFuzzyQuery.java
* lucene/core/src/test/org/apache/lucene/search/payloads/TestPayloadNearQuery.java
* lucene/core/src/test/org/apache/lucene/search/spans/TestBasics.java
* lucene/core/src/test/org/apache/lucene/store/TestWindowsMMap.java
* lucene/core/src/test/org/apache/lucene/util/TestBitUtil.java
* lucene/core/src/test/org/apache/lucene/util/TestFixedBitSet.java
* lucene/core/src/test/org/apache/lucene/util/TestOpenBitSet.java
* lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java
* lucene/highlighter/src/java/org/apache/lucene/search/highlight/DefaultEncoder.java
* lucene/highlighter/src/java/org/apache/lucene/search/highlight/Encoder.java
* lucene/highlighter/src/java/org/apache/lucene/search/highlight/Formatter.java
* lucene/highlighter/src/java/org/apache/lucene/search/highlight/GradientFormatter.java
* lucene/highlighter/src/java/org/apache/lucene/search/highlight/Highlighter.java
* lucene/highlighter/src/java/org/apache/lucene/search/highlight/InvalidTokenOffsetsException.java
* lucene/highlighter/src/java/org/apache/lucene/search/highlight/QueryTermExtractor.java
* lucene/highlighter/src/java/org/apache/lucene/search/highlight/SimpleHTMLEncoder.java
* lucene/highlighter/src/java/org/apache/lucene/search/highlight/SimpleHTMLFormatter.java
* lucene/highlighter/src/java/org/apache/lucene/search/highlight/SpanGradientFormatter.java
* lucene/highlighter/src/java/org/apache/lucene/search/highlight/TextFragment.java
* lucene/highlighter/src/java/org/apache/lucene/search/highlight/WeightedTerm.java
* lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/DualFloatFunction.java
* lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/MultiBoolFunction.java
* lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/ScaleFloatFunction.java
* lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/SimpleBoolFunction.java
* lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/SimpleFloatFunction.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/classic/FastCharStream.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/core/nodes/FieldQueryNode.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/parser/FastCharStream.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/parser/StandardSyntaxParser.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/surround/parser/FastCharStream.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/surround/query/BasicQueryFactory.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/surround/query/RewriteQuery.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/surround/query/SimpleTermRewriteQuery.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/CoreParser.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/CorePlusExtensionsParser.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/DOMUtils.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/FilterBuilder.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/ParserException.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/QueryBuilder.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/QueryTemplateManager.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/CachedFilterBuilder.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/NumericRangeFilterBuilder.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/SpanQueryBuilder.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/UserInputQueryBuilder.java
* lucene/queryparser/src/test/org/apache/lucene/queryparser/xml/TestQueryTemplateManager.java
* lucene/sandbox/src/java/org/apache/lucene/sandbox/queries/FuzzyLikeThisQuery.java
* lucene/sandbox/src/test/org/apache/lucene/sandbox/queries/TestSlowFuzzyQuery.java
* lucene/suggest/src/java/org/apache/lucene/search/spell/DirectSpellChecker.java
* lucene/suggest/src/java/org/apache/lucene/search/spell/SpellChecker.java
* lucene/suggest/src/java/org/apache/lucene/search/suggest/tst/TernaryTreeNode.java
* lucene/test-framework/src/java/org/apache/lucene/analysis/MockTokenizer.java
* lucene/test-framework/src/java/org/apache/lucene/util/LuceneTestCase.java
* lucene/test-framework/src/java/org/apache/lucene/util/RunListenerPrintReproduceInfo.java
* solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DIHLogLevels.java
* solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DIHWriter.java
* solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DataImportHandler.java
* solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DataImporter.java
* solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DebugLogger.java
* solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DocBuilder.java
* solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/EntityProcessorBase.java
* solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/SimplePropertiesWriter.java
* solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/SolrWriter.java
* solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/AbstractDIHCacheTestCase.java
* solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestSortedMapBackedCache.java
* solr/contrib/uima/src/test/org/apache/solr/uima/ts/EntityAnnotation_Type.java
* solr/contrib/uima/src/test/org/apache/solr/uima/ts/SentimentAnnotation_Type.java
* solr/contrib/velocity/src/java/org/apache/solr/response/PageTool.java
* solr/core/src/java/org/apache/solr/cloud/CloudDescriptor.java
* solr/core/src/java/org/apache/solr/core/Config.java
* solr/core/src/java/org/apache/solr/core/CoreContainer.java
* solr/core/src/java/org/apache/solr/handler/component/ResponseBuilder.java
* solr/core/src/java/org/apache/solr/handler/component/SpellCheckComponent.java
* solr/core/src/java/org/apache/solr/handler/loader/CSVLoaderBase.java
* solr/core/src/java/org/apache/solr/response/PHPSerializedResponseWriter.java
* solr/core/src/java/org/apache/solr/response/RawResponseWriter.java
* solr/core/src/java/org/apache/solr/response/SolrQueryResponse.java
* solr/core/src/java/org/apache/solr/schema/SchemaField.java
* solr/core/src/java/org/apache/solr/search/QParser.java
* solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java
* solr/core/src/java/org/apache/solr/spelling/AbstractLuceneSpellChecker.java
* solr/core/src/java/org/apache/solr/spelling/ConjunctionSolrSpellChecker.java
* solr/core/src/java/org/apache/solr/spelling/DirectSolrSpellChecker.java
* solr/core/src/java/org/apache/solr/util/LongPriorityQueue.java
* solr/core/src/test/org/apache/solr/TestDistributedGrouping.java
* solr/core/src/test/org/apache/solr/handler/XmlUpdateRequestHandlerTest.java
* solr/core/src/test/org/apache/solr/handler/XsltUpdateRequestHandlerTest.java
* solr/core/src/test/org/apache/solr/handler/component/DistributedSpellCheckComponentTest.java
* solr/core/src/test/org/apache/solr/handler/component/SpellCheckComponentTest.java
* solr/core/src/test/org/apache/solr/handler/component/StatsComponentTest.java
* solr/core/src/test/org/apache/solr/highlight/DummyHighlighter.java
* solr/core/src/test/org/apache/solr/highlight/HighlighterConfigTest.java
* solr/core/src/test/org/apache/solr/search/SpatialFilterTest.java
* solr/core/src/test/org/apache/solr/search/function/NvlValueSourceParser.java
* solr/core/src/test/org/apache/solr/spelling/DirectSolrSpellCheckerTest.java
* solr/core/src/test/org/apache/solr/spelling/SpellCheckCollatorTest.java
* solr/core/src/test/org/apache/solr/spelling/SpellPossibilityIteratorTest.java
* solr/core/src/test/org/apache/solr/update/UpdateParamsTest.java
* solr/solrj/src/java/org/apache/solr/client/solrj/beans/DocumentObjectBinder.java
* solr/solrj/src/java/org/apache/solr/client/solrj/request/LukeRequest.java
* solr/solrj/src/java/org/apache/solr/client/solrj/response/SpellCheckResponse.java
* solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java
* solr/solrj/src/java/org/apache/solr/common/util/NamedList.java
* solr/solrj/src/test/org/apache/solr/client/solrj/response/TestSpellCheckResponse.java
Total time: 2 seconds
{noformat}
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Attachments: LUCENE-4362_core.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4362) ban tab-indented source
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson updated LUCENE-4362:
-----------------------------------
Attachment: LUCENE-4326_trunk.patch
LUCENE-4362_4x.patch
Current versions, but I can't build the jflex files, and I'm still having the test problem with the unresponsive process.
So, anyone who already has jflex set up want to try applying this, running jflex and maybe the tests?
The state of these patches:
> all the tabs removed from java files that don't have corresponding .jj or .jflex files.
> All the tabs removed from the .jflex and jj files. I'm a little nervous about this...
> Partial run of jflex until I ran out of memory, which I can't seem to get around. So a couple the corresponding generated files have been changed (several StandardTokenizerImpl's and a ClassicTokenizerImpl).
> I'm sure as Robert points out that there'll be a couple of tabs re-introduced by running the parser compilers, but at least the source going in doesn't have any.
> My daughter and her husband want to go hiking. I've got better things to do for a while than fight jflex this afternoon <G>...
Or should I just forget about the jflex nonsense for the time being?
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4326_trunk.patch, LUCENE-4362_4x.patch, LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457126#comment-13457126 ]
Erick Erickson commented on LUCENE-4362:
----------------------------------------
And good riddance to them! Now on to my next vista.... formatting all the code. All it takes is cmd-alt-l form the root in Intellij... NOT....
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Fix For: 5.0, 4.0
>
> Attachments: LUCENE-4326_trunk.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch, LUCENE-4362_trunk.patch, LUCENE-4362_trunk.patch, LUCENE-4362_trunk.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448478#comment-13448478 ]
Chris Male commented on LUCENE-4362:
------------------------------------
Well damn.
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Attachments: LUCENE-4362_core.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4362) ban tab-indented source
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson updated LUCENE-4362:
-----------------------------------
Attachment: LUCENE-4362_trunk.patch
LUCENE-4362_4x.patch
Right. Finally got back to this, traveling really hurts. Anyway...
I'm about ready to check this all in, running tests now.
regenerated all the .jj and .jflex files, those get checked in too, right? Speak now or....
All that's left as far as .java files is concerned is the pesky
// numRead < 0
in things like HtmlStripCharFilterFactory.java that jflex generates.
And can we please put in the check real soon now? Two more files have been checked in over the last week with tabs....
Note, I've only looked at java files and their precursors. I've ignored all .xml, .vm, .js, .<anything except java>
Latest patches attached.
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4326_trunk.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch, LUCENE-4362_trunk.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4362) ban tab-indented source
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson updated LUCENE-4362:
-----------------------------------
Attachment: LUCENE-4362_4x.patch
LUCENE-4362_trunk.patch
I don't think so. Thanks to your help, I did nuke my jflex, re-checkout, mvn install and re-run jflex.
My generated files have this notation:
/**
* This class is a scanner generated by
* <a href="http://www.jflex.de/">JFlex</a> 1.5.0-SNAPSHOT
* on 9/16/12 12:10 PM from the specification file
* <tt>/Users/Erick/apache/4x_4326/lucene/analysis/common/src/java/org/apache/lucene/analysis/charfilter/HTMLStripCharFilter.jflex</tt>
so I think I have the right jflex, but the tabs still appear in things like HTMLStripCharFilterFactory. And the files aren't comparable by eyeball, at least by me. The order of that huge, ugly case statement is different in the two files, but when I spot-checked a couple of the cases they appear identical.
So I'll try running the silly tests again and disable my troublesome one. If they pass I'm checking this in unless there are howls of protest.
I'm attaching another pair of files just to insure that what I check in is exactly what I have on my machine.
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4326_trunk.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch, LUCENE-4362_trunk.patch, LUCENE-4362_trunk.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462165#comment-13462165 ]
Erick Erickson commented on LUCENE-4362:
----------------------------------------
There was a dyslexic patch that was far too easy to confuse with the real patch (4326 rather than 4362 for trunk) so I removed it. It was never applied anyway.
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Fix For: 5.0, 4.0
>
> Attachments: LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch, LUCENE-4362_trunk.patch, LUCENE-4362_trunk.patch, LUCENE-4362_trunk.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4362) ban tab-indented source
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson updated LUCENE-4362:
-----------------------------------
Attachment: LUCENE-4362.patch
Rolls up both the other patches and removes the rest of the tabs from the java files
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449687#comment-13449687 ]
Erick Erickson commented on LUCENE-4362:
----------------------------------------
I took Robert's patch, applied it and spent some time on a flight playing with tabs. I went through the diffs on a fast scan and indented some egregious indentation that jumped out.
Honest, I tried to restrain myself when reformatting _code_ rather than just indenting some stray lines, but in a few cases I just couldn't stand it and reformatted a couple of files (almost all the lines had tabs anyway) and a few complete methods that also had almost all tabbed lines so there shouldn't be very many gratuitous changes...
However, a curious thing happens when I try "ant test". There's some kind of never-ending process that I'm seeing occasionally on my machine. I won't have a chance to really look at it for a bit, I'll report more detail when I do. I'll need to roll back my changes and see if it occurs without them, the usual....
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453374#comment-13453374 ]
Robert Muir commented on LUCENE-4362:
-------------------------------------
Steve, thanks for taking a look. you can see it in Erick's first patch:
{noformat}
Index: lucene/analysis/common/src/java/org/apache/lucene/analysis/standard/StandardTokenizerImpl.java
===================================================================
--- lucene/analysis/common/src/java/org/apache/lucene/analysis/standard/StandardTokenizerImpl.java (revision 1381159)
+++ lucene/analysis/common/src/java/org/apache/lucene/analysis/standard/StandardTokenizerImpl.java (working copy)
@@ -936,7 +936,7 @@
}
}
- // numRead < 0
+ // numRead < 0
return true;
}
{noformat}
So all the generated files seem to have that one lone tab.
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4326_trunk.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4362) ban tab-indented source
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449694#comment-13449694 ]
Robert Muir commented on LUCENE-4362:
-------------------------------------
as mentioned on the list, i dont think we should change the generated files (e.g. standardtokenizerimpl etc).
We should fix those separately as part of the generation process / get jflex fixed for the one line it generates that causes this, etc :)
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org