You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/08/09 09:08:51 UTC

[GitHub] [dubbo] EarthChen opened a new pull request #8458: Fix/triple exception

EarthChen opened a new pull request #8458:
URL: https://github.com/apache/dubbo/pull/8458


   ## What is the purpose of the change
   
   fix dubbo 3.0 use triple can not return real exception #8363 
   
   
   ## Brief changelog
   
   - use hessian2 wrapper java exception
   - add common exception structure for multi-language 
   
   
   ## Verifying this change
   
   
   <!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
   
   ## Checklist
   - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
   - [ ] Each commit in the pull request should have a meaningful subject line and body.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
   - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
   - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
   - [ ] GitHub Actions works fine on your own branch.
   - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8458: Fix 3.0 use triple can not return real exception

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8458:
URL: https://github.com/apache/dubbo/pull/8458#issuecomment-896574983


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8458](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cdc2c29) into [3.0](https://codecov.io/gh/apache/dubbo/commit/4149543bed77fb9d4f859c766c4d90aa09bc81af?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4149543) will **decrease** coverage by `0.45%`.
   > The diff coverage is `5.67%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8458/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8458      +/-   ##
   ============================================
   - Coverage     63.20%   62.75%   -0.46%     
   - Complexity      311      312       +1     
   ============================================
     Files          1099     1112      +13     
     Lines         46054    46633     +579     
     Branches       6956     7016      +60     
   ============================================
   + Hits          29109    29263     +154     
   - Misses        13692    14097     +405     
   - Partials       3253     3273      +20     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `57.73% <0.00%> (ø)` | |
   | [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...apache/dubbo/rpc/protocol/tri/DefaultMetadata.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvRGVmYXVsdE1ldGFkYXRhLmphdmE=) | `58.33% <0.00%> (-11.67%)` | :arrow_down: |
   | [.../apache/dubbo/rpc/protocol/tri/ExceptionUtils.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvRXhjZXB0aW9uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `44.15% <0.00%> (-4.42%)` | :arrow_down: |
   | [...apache/dubbo/rpc/protocol/tri/Http2HeaderMeta.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSHR0cDJIZWFkZXJNZXRhLmphdmE=) | `55.55% <0.00%> (-19.45%)` | :arrow_down: |
   | [...va/org/apache/dubbo/rpc/protocol/tri/Metadata.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvTWV0YWRhdGEuamF2YQ==) | `33.33% <ø> (ø)` | |
   | [...he/dubbo/rpc/protocol/tri/TripleClientHandler.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlQ2xpZW50SGFuZGxlci5qYXZh) | `54.54% <0.00%> (ø)` | |
   | [...che/dubbo/rpc/protocol/tri/TripleRpcException.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlUnBjRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlVXRpbC5qYXZh) | `35.33% <0.00%> (-10.36%)` | :arrow_down: |
   | ... and [106 more](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4149543...cdc2c29](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] AlbumenJ commented on pull request #8458: Fix 3.0 use triple can not return real exception

Posted by GitBox <gi...@apache.org>.
AlbumenJ commented on pull request #8458:
URL: https://github.com/apache/dubbo/pull/8458#issuecomment-896495764


   please fix compile error


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8458: Fix 3.0 use triple can not return real exception

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8458:
URL: https://github.com/apache/dubbo/pull/8458#issuecomment-896574983


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8458](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cdc2c29) into [3.0](https://codecov.io/gh/apache/dubbo/commit/4149543bed77fb9d4f859c766c4d90aa09bc81af?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4149543) will **decrease** coverage by `0.35%`.
   > The diff coverage is `5.67%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8458/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8458      +/-   ##
   ============================================
   - Coverage     63.20%   62.84%   -0.36%     
   - Complexity      311      312       +1     
   ============================================
     Files          1099     1112      +13     
     Lines         46054    46633     +579     
     Branches       6956     7016      +60     
   ============================================
   + Hits          29109    29308     +199     
   - Misses        13692    14061     +369     
   - Partials       3253     3264      +11     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `57.73% <0.00%> (ø)` | |
   | [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...apache/dubbo/rpc/protocol/tri/DefaultMetadata.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvRGVmYXVsdE1ldGFkYXRhLmphdmE=) | `58.33% <0.00%> (-11.67%)` | :arrow_down: |
   | [.../apache/dubbo/rpc/protocol/tri/ExceptionUtils.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvRXhjZXB0aW9uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `44.15% <0.00%> (-4.42%)` | :arrow_down: |
   | [...apache/dubbo/rpc/protocol/tri/Http2HeaderMeta.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSHR0cDJIZWFkZXJNZXRhLmphdmE=) | `55.55% <0.00%> (-19.45%)` | :arrow_down: |
   | [...va/org/apache/dubbo/rpc/protocol/tri/Metadata.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvTWV0YWRhdGEuamF2YQ==) | `33.33% <ø> (ø)` | |
   | [...he/dubbo/rpc/protocol/tri/TripleClientHandler.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlQ2xpZW50SGFuZGxlci5qYXZh) | `54.54% <0.00%> (ø)` | |
   | [...che/dubbo/rpc/protocol/tri/TripleRpcException.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlUnBjRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlVXRpbC5qYXZh) | `35.33% <0.00%> (-10.36%)` | :arrow_down: |
   | ... and [98 more](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4149543...cdc2c29](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter commented on pull request #8458: Fix 3.0 use triple can not return real exception

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #8458:
URL: https://github.com/apache/dubbo/pull/8458#issuecomment-896574983


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8458](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cdc2c29) into [3.0](https://codecov.io/gh/apache/dubbo/commit/4149543bed77fb9d4f859c766c4d90aa09bc81af?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4149543) will **decrease** coverage by `0.51%`.
   > The diff coverage is `5.67%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8458/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8458      +/-   ##
   ============================================
   - Coverage     63.20%   62.69%   -0.52%     
   + Complexity      311      309       -2     
   ============================================
     Files          1099     1112      +13     
     Lines         46054    46633     +579     
     Branches       6956     6995      +39     
   ============================================
   + Hits          29109    29235     +126     
   - Misses        13692    14121     +429     
   - Partials       3253     3277      +24     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `57.73% <0.00%> (ø)` | |
   | [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...apache/dubbo/rpc/protocol/tri/DefaultMetadata.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvRGVmYXVsdE1ldGFkYXRhLmphdmE=) | `58.33% <0.00%> (-11.67%)` | :arrow_down: |
   | [.../apache/dubbo/rpc/protocol/tri/ExceptionUtils.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvRXhjZXB0aW9uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `44.15% <0.00%> (-4.42%)` | :arrow_down: |
   | [...apache/dubbo/rpc/protocol/tri/Http2HeaderMeta.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSHR0cDJIZWFkZXJNZXRhLmphdmE=) | `55.55% <0.00%> (-19.45%)` | :arrow_down: |
   | [...va/org/apache/dubbo/rpc/protocol/tri/Metadata.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvTWV0YWRhdGEuamF2YQ==) | `33.33% <ø> (ø)` | |
   | [...he/dubbo/rpc/protocol/tri/TripleClientHandler.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlQ2xpZW50SGFuZGxlci5qYXZh) | `54.54% <0.00%> (ø)` | |
   | [...che/dubbo/rpc/protocol/tri/TripleRpcException.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlUnBjRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlVXRpbC5qYXZh) | `35.33% <0.00%> (-10.36%)` | :arrow_down: |
   | ... and [111 more](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4149543...cdc2c29](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] guohao merged pull request #8458: Fix 3.0 use triple can not return real exception

Posted by GitBox <gi...@apache.org>.
guohao merged pull request #8458:
URL: https://github.com/apache/dubbo/pull/8458


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8458: Fix 3.0 use triple can not return real exception

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8458:
URL: https://github.com/apache/dubbo/pull/8458#issuecomment-896574983


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8458](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cdc2c29) into [3.0](https://codecov.io/gh/apache/dubbo/commit/4149543bed77fb9d4f859c766c4d90aa09bc81af?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4149543) will **decrease** coverage by `0.34%`.
   > The diff coverage is `5.67%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8458/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8458      +/-   ##
   ============================================
   - Coverage     63.20%   62.86%   -0.35%     
   - Complexity      311      312       +1     
   ============================================
     Files          1099     1112      +13     
     Lines         46054    46633     +579     
     Branches       6956     7016      +60     
   ============================================
   + Hits          29109    29314     +205     
   - Misses        13692    14056     +364     
   - Partials       3253     3263      +10     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `57.73% <0.00%> (ø)` | |
   | [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...apache/dubbo/rpc/protocol/tri/DefaultMetadata.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvRGVmYXVsdE1ldGFkYXRhLmphdmE=) | `58.33% <0.00%> (-11.67%)` | :arrow_down: |
   | [.../apache/dubbo/rpc/protocol/tri/ExceptionUtils.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvRXhjZXB0aW9uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `44.15% <0.00%> (-4.42%)` | :arrow_down: |
   | [...apache/dubbo/rpc/protocol/tri/Http2HeaderMeta.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSHR0cDJIZWFkZXJNZXRhLmphdmE=) | `55.55% <0.00%> (-19.45%)` | :arrow_down: |
   | [...va/org/apache/dubbo/rpc/protocol/tri/Metadata.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvTWV0YWRhdGEuamF2YQ==) | `33.33% <ø> (ø)` | |
   | [...he/dubbo/rpc/protocol/tri/TripleClientHandler.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlQ2xpZW50SGFuZGxlci5qYXZh) | `54.54% <0.00%> (ø)` | |
   | [...che/dubbo/rpc/protocol/tri/TripleRpcException.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlUnBjRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlVXRpbC5qYXZh) | `35.33% <0.00%> (-10.36%)` | :arrow_down: |
   | ... and [98 more](https://codecov.io/gh/apache/dubbo/pull/8458/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4149543...cdc2c29](https://codecov.io/gh/apache/dubbo/pull/8458?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org