You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/06 01:35:30 UTC
[PR] feat: resolve DLQ admin client from selected instance [rocketmq-dashboard]
Aias00 opened a new pull request, #1058:
URL: https://github.com/apache/rocketmq-dashboard/pull/1058
## Summary
- add a runtime resolver from `instanceId` to the saved instance endpoint and the existing endpoint-keyed admin-client cache
- require instance context for DLQ list and resend operations
- configure DLQ pull/producer clients with the selected instance endpoint instead of the global default
- pass the selected instance through the DLQ page, service and API layers
## Scope
This is the foundation slice of #982. It closes #1057 and only wires DLQ; client connections, message query and message trace will follow in separate PRs.
Closes #1057
## Verification
- `JAVA_HOME=$( /usr/libexec/java_home -v 21 ) mvn -Dtest=RuntimeAdminClientResolverTest,RocketMQDLQProviderTest,DLQControllerTest,DLQServiceTest,DLQProviderStubTest test`
- `npm test -- --run src/api/dlq.test.ts src/services/messageService.test.ts src/pages/instance/__tests__/DLQPage.test.tsx`
- `npm run lint` (0 errors; 3 existing warnings)
- `npm run build`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: resolve runtime admin client for DLQ and client connections [rocketmq-dashboard]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on code in PR #1058:
URL: https://github.com/apache/rocketmq-dashboard/pull/1058#discussion_r3726859947
##########
server/src/main/java/org/apache/rocketmq/studio/cluster/client/ProducerConnectionService.java:
##########
@@ -41,7 +41,7 @@ public List<ProducerConnectionVO> listConnections(String topic, String producerG
}
public List<String> listProducerGroups() {
- return clientProvider.findConnections(null, ClientType.Producer.name()).stream()
+ return clientProvider.findConnections(null, null, ClientType.Producer.name()).stream()
Review Comment:
**[Warning]** This call now passes `null` for `instanceId`, which will cause `RuntimeAdminClientResolver.execute()` to throw `BusinessException(400, "instanceId is required")`. This method needs to be updated to either accept an `instanceId` parameter or use a different code path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: resolve runtime admin client for DLQ and client connections [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #1058:
URL: https://github.com/apache/rocketmq-dashboard/pull/1058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org