You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/27 15:27:46 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #2611: Fix vairous issues found in bt uart shim driver

xiaoxiang781216 opened a new pull request #2611:
URL: https://github.com/apache/incubator-nuttx/pull/2611


   ## Summary
   bt_uart_shim: Correct the prototype of bt_uart_shim_getdevice
   bt_uart_shim: Support the multiple instances
   bt_uart_shim: Don't hardcode the thread stack size
   bt_uart_shim: Remove g_lowerstatic static variable
   bt_uart_shim: Make CONFIG_SERIAL_TERMIOS optional
   bt_uart_shim: Setup pollfd with file* correctly
   
   ## Impact
   
   ## Testing
   Please ignore nxstyle warning which is fixed by: #2607
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] jerpelea commented on pull request #2611: Fix vairous issues found in bt uart shim driver

Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #2611:
URL: https://github.com/apache/incubator-nuttx/pull/2611#issuecomment-751611116


   @xiaoxiang781216 
   Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/include/nuttx/wireless/bluetooth/bt_uart_shim.h:9:78: error: Long line found
   Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/include/nuttx/wireless/bluetooth/bt_uart_shim.h:14:79: error: Long line found
   Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/include/nuttx/wireless/bluetooth/bt_uart_shim.h:15:79: error: Long line found
   Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/include/nuttx/wireless/bluetooth/bt_uart_shim.h:19:79: error: Long line found
   Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/include/nuttx/wireless/bluetooth/bt_uart_shim.h:22:78: error: Long line found


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2611: Fix vairous issues found in bt uart shim driver

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2611:
URL: https://github.com/apache/incubator-nuttx/pull/2611#issuecomment-751618180


   @jerpelea fixed here: https://github.com/apache/incubator-nuttx/pull/2607


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] jerpelea merged pull request #2611: Fix vairous issues found in bt uart shim driver

Posted by GitBox <gi...@apache.org>.
jerpelea merged pull request #2611:
URL: https://github.com/apache/incubator-nuttx/pull/2611


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2611: Fix vairous issues found in bt uart shim driver

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2611:
URL: https://github.com/apache/incubator-nuttx/pull/2611#issuecomment-751626900


   @jerpelea thanks, PR pass CI now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org