You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Lukasz Lenart (JIRA)" <ji...@apache.org> on 2008/12/17 00:10:44 UTC

[jira] Created: (BEANUTILS-333) Avoid calling setAccessible() if not needed

Avoid calling setAccessible() if not needed
-------------------------------------------

                 Key: BEANUTILS-333
                 URL: https://issues.apache.org/jira/browse/BEANUTILS-333
             Project: Commons BeanUtils
          Issue Type: Improvement
          Components: Bean / Property Utils
    Affects Versions: 1.7.0
         Environment: Windows XP Professional SP3, Xwork 2.1,
            Reporter: Lukasz Lenart
            Priority: Minor


I already solved the bug in Xwork (see http://jira.opensymphony.com/browse/XW-661), but the same problem exists with Common BeanUtils in org.apache.commons.beanutils.MethodUtils.getMatchingAccessibleMethod():558, add additional check if method is already accessible, like this

if (!method.isAccessible()) {
     method.setAccessible(true);
}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BEANUTILS-333) Avoid calling setAccessible() if not needed

Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BEANUTILS-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657277#action_12657277 ] 

Paul Benedict commented on BEANUTILS-333:
-----------------------------------------

Good point.

> Avoid calling setAccessible() if not needed
> -------------------------------------------
>
>                 Key: BEANUTILS-333
>                 URL: https://issues.apache.org/jira/browse/BEANUTILS-333
>             Project: Commons BeanUtils
>          Issue Type: Improvement
>          Components: Bean / Property Utils
>    Affects Versions: 1.7.0
>         Environment: Windows XP Professional SP3, Xwork 2.1,
>            Reporter: Lukasz Lenart
>            Priority: Minor
>
> I already solved the bug in Xwork (see http://jira.opensymphony.com/browse/XW-661), but the same problem exists with Common BeanUtils in org.apache.commons.beanutils.MethodUtils.getMatchingAccessibleMethod():558, add additional check if method is already accessible, like this
> if (!method.isAccessible()) {
>      method.setAccessible(true);
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (BEANUTILS-333) Avoid calling setAccessible() if not needed

Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BEANUTILS-333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Niall Pemberton resolved BEANUTILS-333.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.8.1
         Assignee: Niall Pemberton

Fixed thanks

http://svn.apache.org/viewvc?view=rev&revision=800975

> Avoid calling setAccessible() if not needed
> -------------------------------------------
>
>                 Key: BEANUTILS-333
>                 URL: https://issues.apache.org/jira/browse/BEANUTILS-333
>             Project: Commons BeanUtils
>          Issue Type: Improvement
>          Components: Bean / Property Utils
>    Affects Versions: 1.7.0
>         Environment: Windows XP Professional SP3, Xwork 2.1,
>            Reporter: Lukasz Lenart
>            Assignee: Niall Pemberton
>            Priority: Minor
>             Fix For: 1.8.1
>
>
> I already solved the bug in Xwork (see http://jira.opensymphony.com/browse/XW-661), but the same problem exists with Common BeanUtils in org.apache.commons.beanutils.MethodUtils.getMatchingAccessibleMethod():558, add additional check if method is already accessible, like this
> if (!method.isAccessible()) {
>      method.setAccessible(true);
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.