You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2008/10/30 06:21:44 UTC

[jira] Created: (HADOOP-4545) Add an example of a secondary sort

Add an example of a secondary sort
----------------------------------

                 Key: HADOOP-4545
                 URL: https://issues.apache.org/jira/browse/HADOOP-4545
             Project: Hadoop Core
          Issue Type: Improvement
          Components: examples
            Reporter: Owen O'Malley
            Assignee: Owen O'Malley
             Fix For: 0.20.0


We should have an example of using secondary sort.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (HADOOP-4545) Add an example of a secondary sort

Posted by "Rares Vernica (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719076#action_12719076 ] 

Rares Vernica edited comment on HADOOP-4545 at 6/12/09 9:47 PM:
----------------------------------------------------------------

In the example, is there a typo in the hashCode function of IntPair?

    public int hashCode() {
      return first * 157 + second;

                             ^^^

                            127?

    }

Here is the .java file: http://svn.apache.org/viewvc/hadoop/core/trunk/src/examples/org/apache/hadoop/examples/SecondarySort.java

      was (Author: rvernica):
    In the example, is there a typo in the hashCode function of IntPair?

    public int hashCode() {
      return first * 157 + second;
                             ^^^
                            127?
    }

Here is the .java file: http://svn.apache.org/viewvc/hadoop/core/trunk/src/examples/org/apache/hadoop/examples/SecondarySort.java
  
> Add an example of a secondary sort
> ----------------------------------
>
>                 Key: HADOOP-4545
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4545
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: examples
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.20.0
>
>         Attachments: h4545.patch, h4545.patch
>
>
> We should have an example of using secondary sort.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4545) Add an example of a secondary sort

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656938#action_12656938 ] 

Chris Douglas commented on HADOOP-4545:
---------------------------------------

+1

> Add an example of a secondary sort
> ----------------------------------
>
>                 Key: HADOOP-4545
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4545
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: examples
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.20.0
>
>         Attachments: h4545.patch, h4545.patch
>
>
> We should have an example of using secondary sort.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4545) Add an example of a secondary sort

Posted by "Rares Vernica (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719076#action_12719076 ] 

Rares Vernica commented on HADOOP-4545:
---------------------------------------

In the example, is there a typo in the hashCode function of IntPair?

    public int hashCode() {
      return first * 157 + second;
                             ^^^
                            127?
    }

Here is the .java file: http://svn.apache.org/viewvc/hadoop/core/trunk/src/examples/org/apache/hadoop/examples/SecondarySort.java

> Add an example of a secondary sort
> ----------------------------------
>
>                 Key: HADOOP-4545
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4545
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: examples
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.20.0
>
>         Attachments: h4545.patch, h4545.patch
>
>
> We should have an example of using secondary sort.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4545) Add an example of a secondary sort

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-4545:
----------------------------------

    Fix Version/s: 0.20.0
           Status: Patch Available  (was: Open)

> Add an example of a secondary sort
> ----------------------------------
>
>                 Key: HADOOP-4545
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4545
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: examples
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.20.0
>
>         Attachments: h4545.patch, h4545.patch
>
>
> We should have an example of using secondary sort.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4545) Add an example of a secondary sort

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-4545:
----------------------------------

    Attachment: h4545.patch

Here is an example.

> Add an example of a secondary sort
> ----------------------------------
>
>                 Key: HADOOP-4545
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4545
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: examples
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.20.0
>
>         Attachments: h4545.patch
>
>
> We should have an example of using secondary sort.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4545) Add an example of a secondary sort

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658554#action_12658554 ] 

Hudson commented on HADOOP-4545:
--------------------------------

Integrated in Hadoop-trunk #698 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/698/])
    

> Add an example of a secondary sort
> ----------------------------------
>
>                 Key: HADOOP-4545
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4545
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: examples
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.20.0
>
>         Attachments: h4545.patch, h4545.patch
>
>
> We should have an example of using secondary sort.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4545) Add an example of a secondary sort

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-4545:
----------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I just committed this.

> Add an example of a secondary sort
> ----------------------------------
>
>                 Key: HADOOP-4545
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4545
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: examples
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.20.0
>
>         Attachments: h4545.patch, h4545.patch
>
>
> We should have an example of using secondary sort.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4545) Add an example of a secondary sort

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-4545:
----------------------------------

    Attachment: h4545.patch

This patch:
  1. Updates the example to the new map/reduce api
  2. Adds a unit test case.

> Add an example of a secondary sort
> ----------------------------------
>
>                 Key: HADOOP-4545
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4545
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: examples
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>         Attachments: h4545.patch, h4545.patch
>
>
> We should have an example of using secondary sort.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (HADOOP-4545) Add an example of a secondary sort

Posted by "Rares Vernica (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719076#action_12719076 ] 

Rares Vernica edited comment on HADOOP-4545 at 6/12/09 9:49 PM:
----------------------------------------------------------------

In the example, is there a typo in the hashCode function of IntPair?

{noformat}
    public int hashCode() {
      return first * 157 + second;
                     ^^^
                     127?
    }
{noformat}

Here is the .java file: http://svn.apache.org/viewvc/hadoop/core/trunk/src/examples/org/apache/hadoop/examples/SecondarySort.java

      was (Author: rvernica):
    In the example, is there a typo in the hashCode function of IntPair?

{noformat}
    public int hashCode() {
      return first * 157 + second;
                             ^^^
                            127?
    }
{noformat}

Here is the .java file: http://svn.apache.org/viewvc/hadoop/core/trunk/src/examples/org/apache/hadoop/examples/SecondarySort.java
  
> Add an example of a secondary sort
> ----------------------------------
>
>                 Key: HADOOP-4545
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4545
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: examples
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.20.0
>
>         Attachments: h4545.patch, h4545.patch
>
>
> We should have an example of using secondary sort.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (HADOOP-4545) Add an example of a secondary sort

Posted by "Rares Vernica (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719076#action_12719076 ] 

Rares Vernica edited comment on HADOOP-4545 at 6/12/09 9:48 PM:
----------------------------------------------------------------

In the example, is there a typo in the hashCode function of IntPair?

{noformat}
    public int hashCode() {
      return first * 157 + second;
                             ^^^
                            127?
    }
{noformat}

Here is the .java file: http://svn.apache.org/viewvc/hadoop/core/trunk/src/examples/org/apache/hadoop/examples/SecondarySort.java

      was (Author: rvernica):
    In the example, is there a typo in the hashCode function of IntPair?

    public int hashCode() {
      return first * 157 + second;

                             ^^^

                            127?

    }

Here is the .java file: http://svn.apache.org/viewvc/hadoop/core/trunk/src/examples/org/apache/hadoop/examples/SecondarySort.java
  
> Add an example of a secondary sort
> ----------------------------------
>
>                 Key: HADOOP-4545
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4545
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: examples
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.20.0
>
>         Attachments: h4545.patch, h4545.patch
>
>
> We should have an example of using secondary sort.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4545) Add an example of a secondary sort

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643764#action_12643764 ] 

Chris Douglas commented on HADOOP-4545:
---------------------------------------

Looks good. A unit test using this example would also be helpful; there aren't many tests that use the grouping comparator.

> Add an example of a secondary sort
> ----------------------------------
>
>                 Key: HADOOP-4545
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4545
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: examples
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.20.0
>
>         Attachments: h4545.patch
>
>
> We should have an example of using secondary sort.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.