You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by "Shaofeng SHI (JIRA)" <ji...@apache.org> on 2018/11/26 11:03:00 UTC

[jira] [Resolved] (KYLIN-3669) Add log to GTStreamAggregateScanner

     [ https://issues.apache.org/jira/browse/KYLIN-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shaofeng SHI resolved KYLIN-3669.
---------------------------------
    Resolution: Fixed

> Add log to GTStreamAggregateScanner
> -----------------------------------
>
>                 Key: KYLIN-3669
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3669
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Query Engine
>            Reporter: Jiatao Tao
>            Assignee: Jiatao Tao
>            Priority: Trivial
>             Fix For: v2.5.2
>
>
> There's no log printing in GTStreamAggregateScanner, and you know nothing about whether you go to this path or not, it's pretty unfriendly for trouble shooting.
> Code in _SegmentCubeTupleIterator_.
> {code:java}
> boolean hasMultiplePartitions = records instanceof SortMergedPartitionResultIterator;
> if (hasMultiplePartitions && context.isStreamAggregateEnabled()) {
>     ...
>     // input records are ordered, leverage stream aggregator to produce possibly fewer records
>     try (GTStreamAggregateScanner aggregator = new GTStreamAggregateScanner(inputScanner, scanRequest)) {
>         result = aggregator.valuesIterator(gtDimsIdx, gtMetricsIdx);
>     } catch (IOException ioe) {
>         // implementation of close method of anonymous IGTScanner is empty, no way throw exception
>         throw new IllegalStateException("IOException is not expected here.", ioe);
>     }
>     return result;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)