You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Areg Melik-Adamyan (JIRA)" <ji...@apache.org> on 2019/02/07 22:34:00 UTC
[jira] [Commented] (ARROW-4462) [C++] Upgrade LZ4 v1.7.5 to v1.8.3
to compile with VS2017
[ https://issues.apache.org/jira/browse/ARROW-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763139#comment-16763139 ]
Areg Melik-Adamyan commented on ARROW-4462:
-------------------------------------------
The final fix will require [https://github.com/lz4/lz4/pull/648] PR to land into a stable release, so this will just upgrade the version, which is still beneficial as it fixes data corruption issue [https://github.com/lz4/lz4/issues/560] .
> [C++] Upgrade LZ4 v1.7.5 to v1.8.3 to compile with VS2017
> ---------------------------------------------------------
>
> Key: ARROW-4462
> URL: https://issues.apache.org/jira/browse/ARROW-4462
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++, Developer Tools
> Reporter: Areg Melik-Adamyan
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> By upgrading to LZ4 v1.8.3 the patch and patching step can be removed as it is incorporated into a newer version of VS2010 solution and also VS2017 solution is provided which ease the usage with newer versions. Is there a reason or fixed dependency on v1.7.5?
> There is still an issue with newer than v8.1 MS Build Tools, and requires manual retargeting. Which can be fixed in CMake by introducing complex logic of reading registry tree HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\MSBuild\ToolsVersions\4.0\1*.0 and analyzing which version of tools are installed and then patching the solution and projects. But as this is an external dependency better to submit patch there.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)