You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Thejas M Nair (JIRA)" <ji...@apache.org> on 2010/08/12 01:45:16 UTC

[jira] Created: (PIG-1542) log level not propogated to MR task loggers

log level not propogated to MR task loggers
-------------------------------------------

                 Key: PIG-1542
                 URL: https://issues.apache.org/jira/browse/PIG-1542
             Project: Pig
          Issue Type: Bug
            Reporter: Thejas M Nair
             Fix For: 0.8.0


Specifying "-d DEBUG" does not affect the logging of the MR tasks .
This was fixed earlier in PIG-882 .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1542) log level not propogated to MR task loggers

Posted by "niraj rai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

niraj rai updated PIG-1542:
---------------------------

    Attachment: PIG-1542.patch

> log level not propogated to MR task loggers
> -------------------------------------------
>
>                 Key: PIG-1542
>                 URL: https://issues.apache.org/jira/browse/PIG-1542
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Thejas M Nair
>            Assignee: niraj rai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1542.patch
>
>
> Specifying "-d DEBUG" does not affect the logging of the MR tasks .
> This was fixed earlier in PIG-882 .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1542) log level not propogated to MR task loggers

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-1542:
----------------------------

      Resolution: Fixed
    Release Note: Patch committed to both trunk and 0.8 branch.
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

> log level not propogated to MR task loggers
> -------------------------------------------
>
>                 Key: PIG-1542
>                 URL: https://issues.apache.org/jira/browse/PIG-1542
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Thejas M Nair
>            Assignee: niraj rai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1542.patch, PIG-1542_1.patch, PIG-1542_2.patch, PIG-1542_3.patch, PIG-1542_4.patch
>
>
> Specifying "-d DEBUG" does not affect the logging of the MR tasks .
> This was fixed earlier in PIG-882 .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1542) log level not propogated to MR task loggers

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917079#action_12917079 ] 

Daniel Dai commented on PIG-1542:
---------------------------------

Yes, -d xxx should treat as -Ddebug=xxx. And system properties already have higher priority in the current code. (And in my mind, we should deprecate -d in favor of -Ddebug)

> log level not propogated to MR task loggers
> -------------------------------------------
>
>                 Key: PIG-1542
>                 URL: https://issues.apache.org/jira/browse/PIG-1542
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Thejas M Nair
>            Assignee: niraj rai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1542.patch, PIG-1542_1.patch, PIG-1542_2.patch
>
>
> Specifying "-d DEBUG" does not affect the logging of the MR tasks .
> This was fixed earlier in PIG-882 .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1542) log level not propogated to MR task loggers

Posted by "niraj rai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

niraj rai updated PIG-1542:
---------------------------

    Status: Open  (was: Patch Available)

> log level not propogated to MR task loggers
> -------------------------------------------
>
>                 Key: PIG-1542
>                 URL: https://issues.apache.org/jira/browse/PIG-1542
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Thejas M Nair
>            Assignee: niraj rai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1542.patch, PIG-1542_1.patch, PIG-1542_2.patch, PIG-1542_3.patch
>
>
> Specifying "-d DEBUG" does not affect the logging of the MR tasks .
> This was fixed earlier in PIG-882 .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1542) log level not propogated to MR task loggers

Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917058#action_12917058 ] 

Thejas M Nair commented on PIG-1542:
------------------------------------

Comment on the patch -
In case of log level settings, it is not possible to override the config file setting using command line options. In other cases, the command line values usually override what is specified in configuration file. For example in case of hadoop properties, this is what happens. This is also very convenient, because you can easily change the setting for a particular invocation of pig. You don't have to change config file which you might potentially share with other users.


> log level not propogated to MR task loggers
> -------------------------------------------
>
>                 Key: PIG-1542
>                 URL: https://issues.apache.org/jira/browse/PIG-1542
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Thejas M Nair
>            Assignee: niraj rai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1542.patch, PIG-1542_1.patch, PIG-1542_2.patch
>
>
> Specifying "-d DEBUG" does not affect the logging of the MR tasks .
> This was fixed earlier in PIG-882 .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1542) log level not propogated to MR task loggers

Posted by "niraj rai (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916974#action_12916974 ] 

niraj rai commented on PIG-1542:
--------------------------------

All the tests: end to end, unit and test-patch tests passed. If Thejas does not have any feedback, please commit the patch.
Thanks
Niraj

> log level not propogated to MR task loggers
> -------------------------------------------
>
>                 Key: PIG-1542
>                 URL: https://issues.apache.org/jira/browse/PIG-1542
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Thejas M Nair
>            Assignee: niraj rai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1542.patch, PIG-1542_1.patch, PIG-1542_2.patch
>
>
> Specifying "-d DEBUG" does not affect the logging of the MR tasks .
> This was fixed earlier in PIG-882 .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1542) log level not propogated to MR task loggers

Posted by "niraj rai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

niraj rai updated PIG-1542:
---------------------------

    Attachment: PIG-1542_3.patch

Moved the log4j property setting to Main.java

> log level not propogated to MR task loggers
> -------------------------------------------
>
>                 Key: PIG-1542
>                 URL: https://issues.apache.org/jira/browse/PIG-1542
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Thejas M Nair
>            Assignee: niraj rai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1542.patch, PIG-1542_1.patch, PIG-1542_2.patch, PIG-1542_3.patch
>
>
> Specifying "-d DEBUG" does not affect the logging of the MR tasks .
> This was fixed earlier in PIG-882 .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1542) log level not propogated to MR task loggers

Posted by "niraj rai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

niraj rai updated PIG-1542:
---------------------------

    Status: Patch Available  (was: Open)

> log level not propogated to MR task loggers
> -------------------------------------------
>
>                 Key: PIG-1542
>                 URL: https://issues.apache.org/jira/browse/PIG-1542
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Thejas M Nair
>            Assignee: niraj rai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1542.patch, PIG-1542_1.patch, PIG-1542_2.patch
>
>
> Specifying "-d DEBUG" does not affect the logging of the MR tasks .
> This was fixed earlier in PIG-882 .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1542) log level not propogated to MR task loggers

Posted by "niraj rai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

niraj rai updated PIG-1542:
---------------------------

    Attachment: PIG-1542_1.patch

Unset the hadoop debug messages and only printing the pig debug messages.

> log level not propogated to MR task loggers
> -------------------------------------------
>
>                 Key: PIG-1542
>                 URL: https://issues.apache.org/jira/browse/PIG-1542
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Thejas M Nair
>            Assignee: niraj rai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1542.patch, PIG-1542_1.patch
>
>
> Specifying "-d DEBUG" does not affect the logging of the MR tasks .
> This was fixed earlier in PIG-882 .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1542) log level not propogated to MR task loggers

Posted by "niraj rai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

niraj rai updated PIG-1542:
---------------------------

    Status: Patch Available  (was: Open)

> log level not propogated to MR task loggers
> -------------------------------------------
>
>                 Key: PIG-1542
>                 URL: https://issues.apache.org/jira/browse/PIG-1542
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Thejas M Nair
>            Assignee: niraj rai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1542.patch, PIG-1542_1.patch
>
>
> Specifying "-d DEBUG" does not affect the logging of the MR tasks .
> This was fixed earlier in PIG-882 .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1542) log level not propogated to MR task loggers

Posted by "niraj rai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

niraj rai updated PIG-1542:
---------------------------

    Status: Patch Available  (was: Open)

> log level not propogated to MR task loggers
> -------------------------------------------
>
>                 Key: PIG-1542
>                 URL: https://issues.apache.org/jira/browse/PIG-1542
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Thejas M Nair
>            Assignee: niraj rai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1542.patch, PIG-1542_1.patch, PIG-1542_2.patch, PIG-1542_3.patch
>
>
> Specifying "-d DEBUG" does not affect the logging of the MR tasks .
> This was fixed earlier in PIG-882 .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1542) log level not propogated to MR task loggers

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920108#action_12920108 ] 

Daniel Dai commented on PIG-1542:
---------------------------------

Is it possible to move "pigContext.getLog4jProperties().setProperty( "log4j.logger.org.apache.pig", pigContext.getLog4jProperties().getProperty("log4j.logger.org.apache.pig.level"));" from PigMapBase to Main? It might be better to set things up in the frontend and just apply in the backend. 

> log level not propogated to MR task loggers
> -------------------------------------------
>
>                 Key: PIG-1542
>                 URL: https://issues.apache.org/jira/browse/PIG-1542
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Thejas M Nair
>            Assignee: niraj rai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1542.patch, PIG-1542_1.patch, PIG-1542_2.patch
>
>
> Specifying "-d DEBUG" does not affect the logging of the MR tasks .
> This was fixed earlier in PIG-882 .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1542) log level not propogated to MR task loggers

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-1542:
----------------------------

    Attachment: PIG-1542_4.patch

I attach a simpler fix PIG-1542_4.patch

> log level not propogated to MR task loggers
> -------------------------------------------
>
>                 Key: PIG-1542
>                 URL: https://issues.apache.org/jira/browse/PIG-1542
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Thejas M Nair
>            Assignee: niraj rai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1542.patch, PIG-1542_1.patch, PIG-1542_2.patch, PIG-1542_3.patch, PIG-1542_4.patch
>
>
> Specifying "-d DEBUG" does not affect the logging of the MR tasks .
> This was fixed earlier in PIG-882 .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (PIG-1542) log level not propogated to MR task loggers

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich reassigned PIG-1542:
-----------------------------------

    Assignee: niraj rai

This will be looked at after the branch since this is a regression and we don't have time to do it now.

> log level not propogated to MR task loggers
> -------------------------------------------
>
>                 Key: PIG-1542
>                 URL: https://issues.apache.org/jira/browse/PIG-1542
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Thejas M Nair
>            Assignee: niraj rai
>             Fix For: 0.8.0
>
>
> Specifying "-d DEBUG" does not affect the logging of the MR tasks .
> This was fixed earlier in PIG-882 .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1542) log level not propogated to MR task loggers

Posted by "niraj rai (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909027#action_12909027 ] 

niraj rai commented on PIG-1542:
--------------------------------

I have also changes the logic of setting the right log level, in case, the pig.logfile.level is passed from command line.


> log level not propogated to MR task loggers
> -------------------------------------------
>
>                 Key: PIG-1542
>                 URL: https://issues.apache.org/jira/browse/PIG-1542
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Thejas M Nair
>            Assignee: niraj rai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1542.patch
>
>
> Specifying "-d DEBUG" does not affect the logging of the MR tasks .
> This was fixed earlier in PIG-882 .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1542) log level not propogated to MR task loggers

Posted by "niraj rai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

niraj rai updated PIG-1542:
---------------------------

    Attachment: PIG-1542_2.patch

> log level not propogated to MR task loggers
> -------------------------------------------
>
>                 Key: PIG-1542
>                 URL: https://issues.apache.org/jira/browse/PIG-1542
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Thejas M Nair
>            Assignee: niraj rai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1542.patch, PIG-1542_1.patch, PIG-1542_2.patch
>
>
> Specifying "-d DEBUG" does not affect the logging of the MR tasks .
> This was fixed earlier in PIG-882 .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1542) log level not propogated to MR task loggers

Posted by "niraj rai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

niraj rai updated PIG-1542:
---------------------------

    Status: Open  (was: Patch Available)

> log level not propogated to MR task loggers
> -------------------------------------------
>
>                 Key: PIG-1542
>                 URL: https://issues.apache.org/jira/browse/PIG-1542
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Thejas M Nair
>            Assignee: niraj rai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1542.patch, PIG-1542_1.patch, PIG-1542_2.patch
>
>
> Specifying "-d DEBUG" does not affect the logging of the MR tasks .
> This was fixed earlier in PIG-882 .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.