You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/01/13 11:31:33 UTC
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5856: ui: fix deploy vm in basic zone
DaanHoogland commented on a change in pull request #5856:
URL: https://github.com/apache/cloudstack/pull/5856#discussion_r783873377
##########
File path: ui/src/views/compute/DeployVM.vue
##########
@@ -1659,7 +1659,7 @@ export default {
}
}
}
- if (this.securitygroupids.length > 0) {
+ if (this.securitygroupids && this.securitygroupids.length > 0) {
Review comment:
question: if above the update method adds an empty list, is this extra check still needed? (or vice versa?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org