You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org> on 2009/02/12 12:29:59 UTC
[jira] Created: (HADOOP-5236) Unreachable code in
TaskInProgress.inCompleteSubTask
Unreachable code in TaskInProgress.inCompleteSubTask
----------------------------------------------------
Key: HADOOP-5236
URL: https://issues.apache.org/jira/browse/HADOOP-5236
Project: Hadoop Core
Issue Type: Bug
Components: mapred
Reporter: Amareshwari Sriramadasu
Assignee: Amareshwari Sriramadasu
Priority: Minor
Fix For: 0.21.0
TaskInProgress.incompleteSubTask has the following unreachable-code :
{noformat}
if (taskState != TaskStatus.State.FAILED &&
taskState != TaskStatus.State.KILLED &&
taskState != TaskStatus.State.FAILED_UNCLEAN &&
taskState != TaskStatus.State.KILLED_UNCLEAN) {
LOG.info("Task '" + taskid + "' running on '" + trackerName +
"' in state: '" + taskState + "' being failed!");
status.setRunState(TaskStatus.State.FAILED);
taskState = TaskStatus.State.FAILED;
}
{noformat}
It would never reach this code, because it is never called from other places, where taskState is not FAILED, KILLED, FAILED_UNCLEAN and KILLED_UNCLEAN.
Also status != null is not required, since status is never null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5236) Unreachable code in
TaskInProgress.inCompleteSubTask
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5236:
--------------------------------------------
Status: Patch Available (was: Open)
> Unreachable code in TaskInProgress.inCompleteSubTask
> ----------------------------------------------------
>
> Key: HADOOP-5236
> URL: https://issues.apache.org/jira/browse/HADOOP-5236
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: patch-5236.txt
>
>
> TaskInProgress.incompleteSubTask has the following unreachable-code :
> {noformat}
> if (taskState != TaskStatus.State.FAILED &&
> taskState != TaskStatus.State.KILLED &&
> taskState != TaskStatus.State.FAILED_UNCLEAN &&
> taskState != TaskStatus.State.KILLED_UNCLEAN) {
> LOG.info("Task '" + taskid + "' running on '" + trackerName +
> "' in state: '" + taskState + "' being failed!");
> status.setRunState(TaskStatus.State.FAILED);
> taskState = TaskStatus.State.FAILED;
> }
> {noformat}
> It would never reach this code, because it is never called from other places, where taskState is not FAILED, KILLED, FAILED_UNCLEAN and KILLED_UNCLEAN.
> Also status != null is not required, since status is never null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5236) Unreachable code in
TaskInProgress.inCompleteSubTask
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5236:
--------------------------------------------
Status: Patch Available (was: Open)
> Unreachable code in TaskInProgress.inCompleteSubTask
> ----------------------------------------------------
>
> Key: HADOOP-5236
> URL: https://issues.apache.org/jira/browse/HADOOP-5236
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: patch-5236-1.txt, patch-5236.txt
>
>
> TaskInProgress.incompleteSubTask has the following unreachable-code :
> {noformat}
> if (taskState != TaskStatus.State.FAILED &&
> taskState != TaskStatus.State.KILLED &&
> taskState != TaskStatus.State.FAILED_UNCLEAN &&
> taskState != TaskStatus.State.KILLED_UNCLEAN) {
> LOG.info("Task '" + taskid + "' running on '" + trackerName +
> "' in state: '" + taskState + "' being failed!");
> status.setRunState(TaskStatus.State.FAILED);
> taskState = TaskStatus.State.FAILED;
> }
> {noformat}
> It would never reach this code, because it is never called from other places, where taskState is not FAILED, KILLED, FAILED_UNCLEAN and KILLED_UNCLEAN.
> Also status != null is not required, since status is never null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5236) Unreachable code in
TaskInProgress.inCompleteSubTask
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680389#action_12680389 ]
Hadoop QA commented on HADOOP-5236:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12400933/patch-5236.txt
against trunk revision 751870.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
-1 patch. The patch command could not apply the patch.
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/40/console
This message is automatically generated.
> Unreachable code in TaskInProgress.inCompleteSubTask
> ----------------------------------------------------
>
> Key: HADOOP-5236
> URL: https://issues.apache.org/jira/browse/HADOOP-5236
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: patch-5236.txt
>
>
> TaskInProgress.incompleteSubTask has the following unreachable-code :
> {noformat}
> if (taskState != TaskStatus.State.FAILED &&
> taskState != TaskStatus.State.KILLED &&
> taskState != TaskStatus.State.FAILED_UNCLEAN &&
> taskState != TaskStatus.State.KILLED_UNCLEAN) {
> LOG.info("Task '" + taskid + "' running on '" + trackerName +
> "' in state: '" + taskState + "' being failed!");
> status.setRunState(TaskStatus.State.FAILED);
> taskState = TaskStatus.State.FAILED;
> }
> {noformat}
> It would never reach this code, because it is never called from other places, where taskState is not FAILED, KILLED, FAILED_UNCLEAN and KILLED_UNCLEAN.
> Also status != null is not required, since status is never null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5236) Unreachable code in
TaskInProgress.inCompleteSubTask
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680968#action_12680968 ]
Hadoop QA commented on HADOOP-5236:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12401909/patch-5236-1.txt
against trunk revision 752405.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/71/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/71/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/71/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/71/console
This message is automatically generated.
> Unreachable code in TaskInProgress.inCompleteSubTask
> ----------------------------------------------------
>
> Key: HADOOP-5236
> URL: https://issues.apache.org/jira/browse/HADOOP-5236
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: patch-5236-1.txt, patch-5236.txt
>
>
> TaskInProgress.incompleteSubTask has the following unreachable-code :
> {noformat}
> if (taskState != TaskStatus.State.FAILED &&
> taskState != TaskStatus.State.KILLED &&
> taskState != TaskStatus.State.FAILED_UNCLEAN &&
> taskState != TaskStatus.State.KILLED_UNCLEAN) {
> LOG.info("Task '" + taskid + "' running on '" + trackerName +
> "' in state: '" + taskState + "' being failed!");
> status.setRunState(TaskStatus.State.FAILED);
> taskState = TaskStatus.State.FAILED;
> }
> {noformat}
> It would never reach this code, because it is never called from other places, where taskState is not FAILED, KILLED, FAILED_UNCLEAN and KILLED_UNCLEAN.
> Also status != null is not required, since status is never null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5236) Unreachable code in
TaskInProgress.inCompleteSubTask
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5236:
--------------------------------------------
Attachment: patch-5236.txt
patch removing unreachable code
> Unreachable code in TaskInProgress.inCompleteSubTask
> ----------------------------------------------------
>
> Key: HADOOP-5236
> URL: https://issues.apache.org/jira/browse/HADOOP-5236
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: patch-5236.txt
>
>
> TaskInProgress.incompleteSubTask has the following unreachable-code :
> {noformat}
> if (taskState != TaskStatus.State.FAILED &&
> taskState != TaskStatus.State.KILLED &&
> taskState != TaskStatus.State.FAILED_UNCLEAN &&
> taskState != TaskStatus.State.KILLED_UNCLEAN) {
> LOG.info("Task '" + taskid + "' running on '" + trackerName +
> "' in state: '" + taskState + "' being failed!");
> status.setRunState(TaskStatus.State.FAILED);
> taskState = TaskStatus.State.FAILED;
> }
> {noformat}
> It would never reach this code, because it is never called from other places, where taskState is not FAILED, KILLED, FAILED_UNCLEAN and KILLED_UNCLEAN.
> Also status != null is not required, since status is never null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5236) Unreachable code in
TaskInProgress.inCompleteSubTask
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-5236:
----------------------------------
Status: Open (was: Patch Available)
Unfortunately the patch is now stale.
> Unreachable code in TaskInProgress.inCompleteSubTask
> ----------------------------------------------------
>
> Key: HADOOP-5236
> URL: https://issues.apache.org/jira/browse/HADOOP-5236
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: patch-5236-1.txt, patch-5236.txt
>
>
> TaskInProgress.incompleteSubTask has the following unreachable-code :
> {noformat}
> if (taskState != TaskStatus.State.FAILED &&
> taskState != TaskStatus.State.KILLED &&
> taskState != TaskStatus.State.FAILED_UNCLEAN &&
> taskState != TaskStatus.State.KILLED_UNCLEAN) {
> LOG.info("Task '" + taskid + "' running on '" + trackerName +
> "' in state: '" + taskState + "' being failed!");
> status.setRunState(TaskStatus.State.FAILED);
> taskState = TaskStatus.State.FAILED;
> }
> {noformat}
> It would never reach this code, because it is never called from other places, where taskState is not FAILED, KILLED, FAILED_UNCLEAN and KILLED_UNCLEAN.
> Also status != null is not required, since status is never null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5236) Unreachable code in
TaskInProgress.inCompleteSubTask
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5236:
--------------------------------------------
Attachment: patch-5236-1.txt
Patch updated with trunk
> Unreachable code in TaskInProgress.inCompleteSubTask
> ----------------------------------------------------
>
> Key: HADOOP-5236
> URL: https://issues.apache.org/jira/browse/HADOOP-5236
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: patch-5236-1.txt, patch-5236.txt
>
>
> TaskInProgress.incompleteSubTask has the following unreachable-code :
> {noformat}
> if (taskState != TaskStatus.State.FAILED &&
> taskState != TaskStatus.State.KILLED &&
> taskState != TaskStatus.State.FAILED_UNCLEAN &&
> taskState != TaskStatus.State.KILLED_UNCLEAN) {
> LOG.info("Task '" + taskid + "' running on '" + trackerName +
> "' in state: '" + taskState + "' being failed!");
> status.setRunState(TaskStatus.State.FAILED);
> taskState = TaskStatus.State.FAILED;
> }
> {noformat}
> It would never reach this code, because it is never called from other places, where taskState is not FAILED, KILLED, FAILED_UNCLEAN and KILLED_UNCLEAN.
> Also status != null is not required, since status is never null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5236) Unreachable code in
TaskInProgress.inCompleteSubTask
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5236:
--------------------------------------------
Status: Open (was: Patch Available)
> Unreachable code in TaskInProgress.inCompleteSubTask
> ----------------------------------------------------
>
> Key: HADOOP-5236
> URL: https://issues.apache.org/jira/browse/HADOOP-5236
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: patch-5236.txt
>
>
> TaskInProgress.incompleteSubTask has the following unreachable-code :
> {noformat}
> if (taskState != TaskStatus.State.FAILED &&
> taskState != TaskStatus.State.KILLED &&
> taskState != TaskStatus.State.FAILED_UNCLEAN &&
> taskState != TaskStatus.State.KILLED_UNCLEAN) {
> LOG.info("Task '" + taskid + "' running on '" + trackerName +
> "' in state: '" + taskState + "' being failed!");
> status.setRunState(TaskStatus.State.FAILED);
> taskState = TaskStatus.State.FAILED;
> }
> {noformat}
> It would never reach this code, because it is never called from other places, where taskState is not FAILED, KILLED, FAILED_UNCLEAN and KILLED_UNCLEAN.
> Also status != null is not required, since status is never null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5236) Unreachable code in
TaskInProgress.inCompleteSubTask
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5236:
--------------------------------------------
Status: Patch Available (was: Open)
> Unreachable code in TaskInProgress.inCompleteSubTask
> ----------------------------------------------------
>
> Key: HADOOP-5236
> URL: https://issues.apache.org/jira/browse/HADOOP-5236
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: patch-5236.txt
>
>
> TaskInProgress.incompleteSubTask has the following unreachable-code :
> {noformat}
> if (taskState != TaskStatus.State.FAILED &&
> taskState != TaskStatus.State.KILLED &&
> taskState != TaskStatus.State.FAILED_UNCLEAN &&
> taskState != TaskStatus.State.KILLED_UNCLEAN) {
> LOG.info("Task '" + taskid + "' running on '" + trackerName +
> "' in state: '" + taskState + "' being failed!");
> status.setRunState(TaskStatus.State.FAILED);
> taskState = TaskStatus.State.FAILED;
> }
> {noformat}
> It would never reach this code, because it is never called from other places, where taskState is not FAILED, KILLED, FAILED_UNCLEAN and KILLED_UNCLEAN.
> Also status != null is not required, since status is never null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5236) Unreachable code in
TaskInProgress.inCompleteSubTask
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5236:
--------------------------------------------
Status: Open (was: Patch Available)
test failures are not related to the patch. submitting to hudson again.
> Unreachable code in TaskInProgress.inCompleteSubTask
> ----------------------------------------------------
>
> Key: HADOOP-5236
> URL: https://issues.apache.org/jira/browse/HADOOP-5236
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: patch-5236.txt
>
>
> TaskInProgress.incompleteSubTask has the following unreachable-code :
> {noformat}
> if (taskState != TaskStatus.State.FAILED &&
> taskState != TaskStatus.State.KILLED &&
> taskState != TaskStatus.State.FAILED_UNCLEAN &&
> taskState != TaskStatus.State.KILLED_UNCLEAN) {
> LOG.info("Task '" + taskid + "' running on '" + trackerName +
> "' in state: '" + taskState + "' being failed!");
> status.setRunState(TaskStatus.State.FAILED);
> taskState = TaskStatus.State.FAILED;
> }
> {noformat}
> It would never reach this code, because it is never called from other places, where taskState is not FAILED, KILLED, FAILED_UNCLEAN and KILLED_UNCLEAN.
> Also status != null is not required, since status is never null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5236) Unreachable code in
TaskInProgress.inCompleteSubTask
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676697#action_12676697 ]
Hadoop QA commented on HADOOP-5236:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12400933/patch-5236.txt
against trunk revision 747675.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3917/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3917/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3917/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3917/console
This message is automatically generated.
> Unreachable code in TaskInProgress.inCompleteSubTask
> ----------------------------------------------------
>
> Key: HADOOP-5236
> URL: https://issues.apache.org/jira/browse/HADOOP-5236
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: patch-5236.txt
>
>
> TaskInProgress.incompleteSubTask has the following unreachable-code :
> {noformat}
> if (taskState != TaskStatus.State.FAILED &&
> taskState != TaskStatus.State.KILLED &&
> taskState != TaskStatus.State.FAILED_UNCLEAN &&
> taskState != TaskStatus.State.KILLED_UNCLEAN) {
> LOG.info("Task '" + taskid + "' running on '" + trackerName +
> "' in state: '" + taskState + "' being failed!");
> status.setRunState(TaskStatus.State.FAILED);
> taskState = TaskStatus.State.FAILED;
> }
> {noformat}
> It would never reach this code, because it is never called from other places, where taskState is not FAILED, KILLED, FAILED_UNCLEAN and KILLED_UNCLEAN.
> Also status != null is not required, since status is never null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.