You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/01/16 17:20:40 UTC
[GitHub] [commons-collections] garydgregory commented on a change in pull request #209: [COLLECTIONS-779] - Migrate assert to Assertions
garydgregory commented on a change in pull request #209:
URL: https://github.com/apache/commons-collections/pull/209#discussion_r558970391
##########
File path: src/test/java/org/apache/commons/collections4/iterators/LoopingListIteratorTest.java
##########
@@ -21,8 +21,8 @@
import java.util.List;
import java.util.NoSuchElementException;
-import org.junit.Test;
-import static org.junit.Assert.*;
+import org.junit.jupiter.api.Test;
+import static org.junit.jupiter.api.Assertions.*;
Review comment:
@arturobernalg
Did you forget to flip the arguments on the `assert*` API calls in this file and subsequent files?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org