[jira] Commented: (JCR-2513) Omit default BatchReadConfig in Spi2davexRepositoryServiceFactory

["Michael Dürig (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCR-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837244#action_12837244 ] 

Michael Dürig commented on JCR-2513:
------------------------------------

I wasn't aware that spi2davex.RepositoryServiceImpl can cope with null values for the batchread-config. However, since it has its own default batchread-config which applies if null is passed, I think it is correct to remove the 'other' default from Spi2davexRepositoryServiceFactory.


> Omit default BatchReadConfig in Spi2davexRepositoryServiceFactory
> -----------------------------------------------------------------
>
>                 Key: JCR-2513
>                 URL: https://issues.apache.org/jira/browse/JCR-2513
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-spi2dav
>    Affects Versions: 2.0.0
>            Reporter: angela
>            Priority: Minor
>
> i'd like to remove the default batchread configuration created in Spi2davexRepositoryServiceFactory (ll 79) and instead pass 
> null if the service configuration doesn't define the batch-read-config.
> for test execution e.g. the given default isn't really optimal as sessions only have a short life time and only read
> a very limited amount of items (in general)... always reading with depth 4 doesn't add any benefit in this case.
> running the level1 jcr tests in jcr2dav (that as far as i saw doesn't define an extra batchread-config took 1.5, 2.5 and 13 minutes
> from null-config -> depth2 -> depth4.
> if there is a strong reason for keeping that default in the factory we should at least change that for the tests.
> michael, what do you think?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.