[GitHub] [pinot] ege-st commented on a diff in pull request #10852: compress nullvector bitmap upon seal

["ege-st (via GitHub)" <gi...@apache.org>]

ege-st commented on code in PR #10852:
URL: https://github.com/apache/pinot/pull/10852#discussion_r1218737717


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/nullvalue/NullValueVectorCreator.java:
##########
@@ -42,7 +42,7 @@
  * null, which is true for all index creators types unless this one.
  */
 public class NullValueVectorCreator implements IndexCreator {
-  private final MutableRoaringBitmap _nullBitmap = new MutableRoaringBitmap();
+  private final RoaringBitmapWriter<RoaringBitmap> _bitmapWriter;

Review Comment:
   Why the change to `RoaringBitmapWriter`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org