You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bbovenzi (via GitHub)" <gi...@apache.org> on 2024/04/03 17:15:55 UTC
[PR] Fix grid header rendering [airflow]
bbovenzi opened a new pull request, #38720:
URL: https://github.com/apache/airflow/pull/38720
We were relying on fetching the Task Instance in order to render the task display name. But you didn't always have a task instance selected, we already have it as `task.label`, so let's use that instead.
Also, we already have the rendered map index so passing that to our header object instead.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix grid header rendering [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #38720:
URL: https://github.com/apache/airflow/pull/38720#issuecomment-2036684606
> Since I am merging this PR now
So far I've been marking those candidates for rc2 as 2.9.0 - then when we release 2.9.0 finally we will just move those in 2.9.0 which are unmerged to 2.9.1 ( I think that might be easier and our scripts for 2.9.1 shoudl detect any mismatches) cc: @ephraimbuddy ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix grid header rendering [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal merged PR #38720:
URL: https://github.com/apache/airflow/pull/38720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix grid header rendering [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #38720:
URL: https://github.com/apache/airflow/pull/38720#issuecomment-2035592900
From code and description I do not see and understand where the problem is - therefore it is hard for me to understand where and what is fixed. Maybe I am still to noob in the UI world. Can you describe a bit more where the problem was?
And as we are still in RC1, is this something that can go into 2.9.1 or shall we raise hands to make it into 2.9.0 if the RC1 does not make it through testing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix grid header rendering [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #38720:
URL: https://github.com/apache/airflow/pull/38720#issuecomment-2036548759
Since I am merging this PR now
I am marking it for 2.9.1 in case we have rc2 for 2.9.0 then release manager can simply go over the PRs on 2.9.1 and decide what to bring into 2.9.0rc2 otherwise we may risk losing track of the PR. cc @ephraimbuddy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix grid header rendering [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #38720:
URL: https://github.com/apache/airflow/pull/38720#issuecomment-2036686817
But yes - it's a bit misleding and ambiguous, possibly we could improve it somehow (RC milestone?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix grid header rendering [airflow]
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on PR #38720:
URL: https://github.com/apache/airflow/pull/38720#issuecomment-2037114631
> > Since I am merging this PR now
>
> So far I've been marking those candidates for rc2 as 2.9.0 - then when we release 2.9.0 finally we will just move those in 2.9.0 which are unmerged to 2.9.1 ( I think that might be easier and our scripts for 2.9.1 shoudl detect any mismatches) cc: @ephraimbuddy ?
Yes. that's okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix grid header rendering [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #38720:
URL: https://github.com/apache/airflow/pull/38720#issuecomment-2035690515
Before: (note how we're looking at the summary of mapped tasks)
<img width="1107" alt="Screenshot 2024-04-03 at 6 11 06 PM" src="https://github.com/apache/airflow/assets/4600967/b7c8a236-c2c1-4b29-be8a-8ca63ca3c11f">
After:
<img width="1048" alt="Screenshot 2024-04-03 at 6 11 48 PM" src="https://github.com/apache/airflow/assets/4600967/4bf1a3c7-c19c-4088-8283-f4a9952dad29">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org