You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/07/29 18:43:33 UTC
[GitHub] [lucene] gf53520 opened a new pull request #231: Remove TieredMergePolicy's redundant query computation
gf53520 opened a new pull request #231:
URL: https://github.com/apache/lucene/pull/231
…DeletesToMerge
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene:
* https://issues.apache.org/jira/projects/LUCENE
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
LUCENE must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Please provide a short description of the changes you're making with this pull request.
# Solution
Please provide a short description of the approach taken to implement your solution.
# Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gf53520 edited a comment on pull request #231: LUCENE-10041: Remove TieredMergePolicy's redundant query computation
Posted by GitBox <gi...@apache.org>.
gf53520 edited a comment on pull request #231:
URL: https://github.com/apache/lucene/pull/231#issuecomment-899177506
> @gf53520 Sorry for the late response. I was offline last week.
>
> After taking another look, I think we should not introduce another `size` method in MergePolicy, but wrap MergeContext to cache `numDeletesToMerge` in SoftDeletesRetentionMergePolicy instead. I know this is not ideal, but it's less confusing than the current approach.
ok, I think make that cache for SoftDeletesRetentionMergePolicy is more elegrant, considering that size method is only useful in soft-deletes case. I close this mr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dnhatn commented on pull request #231: LUCENE-10041: Remove TieredMergePolicy's redundant query computation
Posted by GitBox <gi...@apache.org>.
dnhatn commented on pull request #231:
URL: https://github.com/apache/lucene/pull/231#issuecomment-889383140
@gf53520 Changes look good to me. Can you also override the new method in FilterMergePolicy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gf53520 commented on pull request #231: LUCENE-10041: Remove TieredMergePolicy's redundant query computation
Posted by GitBox <gi...@apache.org>.
gf53520 commented on pull request #231:
URL: https://github.com/apache/lucene/pull/231#issuecomment-899177506
> @gf53520 Sorry for the late response. I was offline last week.
>
> After taking another look, I think we should not introduce another `size` method in MergePolicy, but wrap MergeContext to cache `numDeletesToMerge` in SoftDeletesRetentionMergePolicy instead. I know this is not ideal, but it's less confusing than the current approach.
ok, I think make that cache for SoftDeletesRetentionMergePolicy is more elegrant, considering that size method is only useful in soft-deletes case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gf53520 commented on pull request #231: LUCENE-10041: Remove TieredMergePolicy's redundant query computation
Posted by GitBox <gi...@apache.org>.
gf53520 commented on pull request #231:
URL: https://github.com/apache/lucene/pull/231#issuecomment-889587470
> @gf53520 Changes look good to me. Can you also override the new method in FilterMergePolicy?
Thanks @dnhatn. I have just overridden the new method in FilterMergePolicy, Please take a took.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dnhatn commented on pull request #231: LUCENE-10041: Remove TieredMergePolicy's redundant query computation
Posted by GitBox <gi...@apache.org>.
dnhatn commented on pull request #231:
URL: https://github.com/apache/lucene/pull/231#issuecomment-899166760
@gf53520 Sorry for the late response. I was offline last week.
After taking another look, I think we should not introduce another `size` method in MergePolicy, but wrap MergeContext to cache `numDeletesToMerge` in SoftDeletesRetentionMergePolicy instead. I know this is not ideal, but it's less confusing than the current approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gf53520 edited a comment on pull request #231: LUCENE-10041: Remove TieredMergePolicy's redundant query computation
Posted by GitBox <gi...@apache.org>.
gf53520 edited a comment on pull request #231:
URL: https://github.com/apache/lucene/pull/231#issuecomment-899177506
> @gf53520 Sorry for the late response. I was offline last week.
>
> After taking another look, I think we should not introduce another `size` method in MergePolicy, but wrap MergeContext to cache `numDeletesToMerge` in SoftDeletesRetentionMergePolicy instead. I know this is not ideal, but it's less confusing than the current approach.
@dnhatn ok, I think make that cache for SoftDeletesRetentionMergePolicy is more elegrant, considering that size method is only useful in soft-deletes case. I close this mr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gf53520 closed pull request #231: LUCENE-10041: Remove TieredMergePolicy's redundant query computation
Posted by GitBox <gi...@apache.org>.
gf53520 closed pull request #231:
URL: https://github.com/apache/lucene/pull/231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org