You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/22 22:39:26 UTC

[GitHub] [airflow] potiuk commented on issue #19757: Change the default for `dag_processor_manager_log_location`

potiuk commented on issue #19757:
URL: https://github.com/apache/airflow/issues/19757#issuecomment-975979665


   This is nontrivial because in it's general solution it will depend on the sequence of how the entties are specified and used and some cases are unsolvable.
   
   I.e.  what should happens if you specify `base_log_folder={DAG_PROCESSOR_MANAGER_LOG_LOCATION}` and `dag_processor_manger_log_location={BASE_LOG_FOLDER}' ? 
   
   How to avoid infiinite recursion? 
   
   The current approach is that we can specify ENV_VARIABLES in the config but we can't specify other config variables (which is what you basically proposed). As this could cuase infinite recursion.
   
   Maybe  a solution is to add some comments to the descriptions of the variables to mention that those configuration variables are independent from each other. 
   
   Maybe you'd lilke to make PR with such documentation change that will make future debugging much easier for other users? As a person who struggled with it, maybe you can find the riight wording?
   
   It's basically updating this file: https://github.com/apache/airflow/blob/968952bb8d0b410e5cf013f3d0d074fc5783c6f1/airflow/config_templates/config.yml#L449  - and you can even open PR and edit it directly from the Github UI - just make a fork and edit the file and make a PR there. 
   
   Shall I assign you this issue?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org