You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stefan <lu...@gmx.de> on 2016/05/14 23:13:11 UTC
[PATCH] troubleshooting http-pipelining for 1.9 release notes
Hi,
following patch adds the troubleshooting section to the 1.9 release
notes including a section about lock/unlock issues related to
old/ancient proxies.
I'd appreciate, if the actual description could be reviewed by someone
with a deeper knowledge on the underlying issue than I have.
[[[
Add a troubleshooting section to 1.9 to help users tracing down problems
related to proxies when locking/unlocking multiple files.
* docs/release-notes/1.9.html
(troubleshooting): Add new section including http-pipelining issue
description.
]]]
Regards,
Stefan
Re: [PATCH] troubleshooting http-pipelining for 1.9 release notes
Posted by Stefan <lu...@posteo.de>.
On 5/16/2016 16:18, Branko Čibej wrote:
> On 16.05.2016 15:07, Stefan wrote:
>> On 5/16/2016 14:29, Branko Čibej wrote:
>>> On 16.05.2016 13:24, Stefan wrote:
>>>> On 5/16/2016 13:14, Ivan Zhakov wrote:
>>>>> On 16 May 2016 at 13:43, Stefan <lu...@posteo.de> wrote:
>>>>>> On 5/16/2016 11:42, Ivan Zhakov wrote:
>>>>>>> On 15 May 2016 at 03:02, Stefan <lu...@gmx.de> wrote:
>>>>>>>> On 5/15/2016 01:13, Stefan wrote:
>>>>>>>>> [[[
>>>>>>>>> Add a troubleshooting section to 1.9 to help users tracing down problems
>>>>>>>>> related to proxies when locking/unlocking multiple files.
>>>>>>>>>
>>>>>>>>> * docs/release-notes/1.9.html
>>>>>>>>> (troubleshooting): Add new section including http-pipelining issue
>>>>>>>>> description.
>>>>>>>>> ]]]
>>>>>>>> Small correction to patchnotes:
>>>>>>>>
>>>>>>>> [[[
>>>>>>>> Add a troubleshooting section to 1.9 to help users tracing down problems
>>>>>>>> related to proxies when locking/unlocking multiple files.
>>>>>>>>
>>>>>>>> * docs/release-notes/1.9.html
>>>>>>>> (troubleshooting): Add new section including http-pipelining issue
>>>>>>>> description.
>>>>>>>> (news): Add link to new troubleshooting section.
>>>>>>>> ]]]
>>>>>>>>
>>>>>>> I think it's better to use term "HTTP pipelining" instead of
>>>>>>> "http-pipelining" on the website. Another wording suggestion: replace
>>>>>>> ".. protocols/applications involved in processing http-pipelining."
>>>>>>> with something like ".. protocols/applications involved in processing
>>>>>>> pipelined HTTP requests."
>>>>>> Thanks for the review Ivan, attached patch incorporates your changes and
>>>>>> also changes the section name (http-pipeline-issue ->
>>>>>> http-pipelining-issue).
>>>>>>
>>>>> Thanks for fixing that, but title still uses term 'http-pipelining":
>>>>> +<h3>Lock/Unlock errors related to http-pipelining
>>>>> + <a class="sectionlink" href="#http-pipelining-issue"
>>>>> + title="Link to this section">¶</a>
>>>>> +</h3>
>>>> Good spot. Fixed with the attached patch.
>>> Can you please not use <br/> where it's not appropriate. You should
>>> actually have multiple paragraphs in the description, not one paragraph
>>> with hard line breaks.
>>>
>>> An HTML editor quirk, perhaps?
>> It's rather my layout style which I didn't correctly adjust to cope for
>> the layout used on the release notes page.
>> I believe that the revised patch should use the correct layout now.
>> The patch also corrects the missing encoding of the & in the URL in the
>> new trouble shooting section.
> Thanks, looks good as far as I'm concerned.
>
> -- Brane
Thanks for the review to the both of you. Committed in r1744791 now. (I
hope I got that right, in that your statement was an approval for
commit, Brane).
Regards,
Stefan
Re: [PATCH] troubleshooting http-pipelining for 1.9 release notes
Posted by Branko Čibej <br...@apache.org>.
On 16.05.2016 15:07, Stefan wrote:
> On 5/16/2016 14:29, Branko \u010cibej wrote:
>> On 16.05.2016 13:24, Stefan wrote:
>>> On 5/16/2016 13:14, Ivan Zhakov wrote:
>>>> On 16 May 2016 at 13:43, Stefan <lu...@posteo.de> wrote:
>>>>> On 5/16/2016 11:42, Ivan Zhakov wrote:
>>>>>> On 15 May 2016 at 03:02, Stefan <lu...@gmx.de> wrote:
>>>>>>> On 5/15/2016 01:13, Stefan wrote:
>>>>>>>> [[[
>>>>>>>> Add a troubleshooting section to 1.9 to help users tracing down problems
>>>>>>>> related to proxies when locking/unlocking multiple files.
>>>>>>>>
>>>>>>>> * docs/release-notes/1.9.html
>>>>>>>> (troubleshooting): Add new section including http-pipelining issue
>>>>>>>> description.
>>>>>>>> ]]]
>>>>>>> Small correction to patchnotes:
>>>>>>>
>>>>>>> [[[
>>>>>>> Add a troubleshooting section to 1.9 to help users tracing down problems
>>>>>>> related to proxies when locking/unlocking multiple files.
>>>>>>>
>>>>>>> * docs/release-notes/1.9.html
>>>>>>> (troubleshooting): Add new section including http-pipelining issue
>>>>>>> description.
>>>>>>> (news): Add link to new troubleshooting section.
>>>>>>> ]]]
>>>>>>>
>>>>>> I think it's better to use term "HTTP pipelining" instead of
>>>>>> "http-pipelining" on the website. Another wording suggestion: replace
>>>>>> ".. protocols/applications involved in processing http-pipelining."
>>>>>> with something like ".. protocols/applications involved in processing
>>>>>> pipelined HTTP requests."
>>>>> Thanks for the review Ivan, attached patch incorporates your changes and
>>>>> also changes the section name (http-pipeline-issue ->
>>>>> http-pipelining-issue).
>>>>>
>>>> Thanks for fixing that, but title still uses term 'http-pipelining":
>>>> +<h3>Lock/Unlock errors related to http-pipelining
>>>> + <a class="sectionlink" href="#http-pipelining-issue"
>>>> + title="Link to this section">¶</a>
>>>> +</h3>
>>> Good spot. Fixed with the attached patch.
>> Can you please not use <br/> where it's not appropriate. You should
>> actually have multiple paragraphs in the description, not one paragraph
>> with hard line breaks.
>>
>> An HTML editor quirk, perhaps?
> It's rather my layout style which I didn't correctly adjust to cope for
> the layout used on the release notes page.
> I believe that the revised patch should use the correct layout now.
> The patch also corrects the missing encoding of the & in the URL in the
> new trouble shooting section.
Thanks, looks good as far as I'm concerned.
-- Brane
Re: [PATCH] troubleshooting http-pipelining for 1.9 release notes
Posted by Stefan <lu...@posteo.de>.
On 5/16/2016 14:29, Branko Čibej wrote:
> On 16.05.2016 13:24, Stefan wrote:
>> On 5/16/2016 13:14, Ivan Zhakov wrote:
>>> On 16 May 2016 at 13:43, Stefan <lu...@posteo.de> wrote:
>>>> On 5/16/2016 11:42, Ivan Zhakov wrote:
>>>>> On 15 May 2016 at 03:02, Stefan <lu...@gmx.de> wrote:
>>>>>> On 5/15/2016 01:13, Stefan wrote:
>>>>>>> [[[
>>>>>>> Add a troubleshooting section to 1.9 to help users tracing down problems
>>>>>>> related to proxies when locking/unlocking multiple files.
>>>>>>>
>>>>>>> * docs/release-notes/1.9.html
>>>>>>> (troubleshooting): Add new section including http-pipelining issue
>>>>>>> description.
>>>>>>> ]]]
>>>>>> Small correction to patchnotes:
>>>>>>
>>>>>> [[[
>>>>>> Add a troubleshooting section to 1.9 to help users tracing down problems
>>>>>> related to proxies when locking/unlocking multiple files.
>>>>>>
>>>>>> * docs/release-notes/1.9.html
>>>>>> (troubleshooting): Add new section including http-pipelining issue
>>>>>> description.
>>>>>> (news): Add link to new troubleshooting section.
>>>>>> ]]]
>>>>>>
>>>>> I think it's better to use term "HTTP pipelining" instead of
>>>>> "http-pipelining" on the website. Another wording suggestion: replace
>>>>> ".. protocols/applications involved in processing http-pipelining."
>>>>> with something like ".. protocols/applications involved in processing
>>>>> pipelined HTTP requests."
>>>> Thanks for the review Ivan, attached patch incorporates your changes and
>>>> also changes the section name (http-pipeline-issue ->
>>>> http-pipelining-issue).
>>>>
>>> Thanks for fixing that, but title still uses term 'http-pipelining":
>>> +<h3>Lock/Unlock errors related to http-pipelining
>>> + <a class="sectionlink" href="#http-pipelining-issue"
>>> + title="Link to this section">¶</a>
>>> +</h3>
>> Good spot. Fixed with the attached patch.
> Can you please not use <br/> where it's not appropriate. You should
> actually have multiple paragraphs in the description, not one paragraph
> with hard line breaks.
>
> An HTML editor quirk, perhaps?
It's rather my layout style which I didn't correctly adjust to cope for
the layout used on the release notes page.
I believe that the revised patch should use the correct layout now.
The patch also corrects the missing encoding of the & in the URL in the
new trouble shooting section.
Regards,
Stefan
Re: [PATCH] troubleshooting http-pipelining for 1.9 release notes
Posted by Branko Čibej <br...@apache.org>.
On 16.05.2016 13:24, Stefan wrote:
> On 5/16/2016 13:14, Ivan Zhakov wrote:
>> On 16 May 2016 at 13:43, Stefan <lu...@posteo.de> wrote:
>>> On 5/16/2016 11:42, Ivan Zhakov wrote:
>>>> On 15 May 2016 at 03:02, Stefan <lu...@gmx.de> wrote:
>>>>> On 5/15/2016 01:13, Stefan wrote:
>>>>>> [[[
>>>>>> Add a troubleshooting section to 1.9 to help users tracing down problems
>>>>>> related to proxies when locking/unlocking multiple files.
>>>>>>
>>>>>> * docs/release-notes/1.9.html
>>>>>> (troubleshooting): Add new section including http-pipelining issue
>>>>>> description.
>>>>>> ]]]
>>>>> Small correction to patchnotes:
>>>>>
>>>>> [[[
>>>>> Add a troubleshooting section to 1.9 to help users tracing down problems
>>>>> related to proxies when locking/unlocking multiple files.
>>>>>
>>>>> * docs/release-notes/1.9.html
>>>>> (troubleshooting): Add new section including http-pipelining issue
>>>>> description.
>>>>> (news): Add link to new troubleshooting section.
>>>>> ]]]
>>>>>
>>>> I think it's better to use term "HTTP pipelining" instead of
>>>> "http-pipelining" on the website. Another wording suggestion: replace
>>>> ".. protocols/applications involved in processing http-pipelining."
>>>> with something like ".. protocols/applications involved in processing
>>>> pipelined HTTP requests."
>>> Thanks for the review Ivan, attached patch incorporates your changes and
>>> also changes the section name (http-pipeline-issue ->
>>> http-pipelining-issue).
>>>
>> Thanks for fixing that, but title still uses term 'http-pipelining":
>> +<h3>Lock/Unlock errors related to http-pipelining
>> + <a class="sectionlink" href="#http-pipelining-issue"
>> + title="Link to this section">¶</a>
>> +</h3>
> Good spot. Fixed with the attached patch.
Can you please not use <br/> where it's not appropriate. You should
actually have multiple paragraphs in the description, not one paragraph
with hard line breaks.
An HTML editor quirk, perhaps?
-- Brane
Re: [PATCH] troubleshooting http-pipelining for 1.9 release notes
Posted by Stefan <lu...@posteo.de>.
On 5/16/2016 13:14, Ivan Zhakov wrote:
> On 16 May 2016 at 13:43, Stefan <lu...@posteo.de> wrote:
>> On 5/16/2016 11:42, Ivan Zhakov wrote:
>>> On 15 May 2016 at 03:02, Stefan <lu...@gmx.de> wrote:
>>>> On 5/15/2016 01:13, Stefan wrote:
>>>>> [[[
>>>>> Add a troubleshooting section to 1.9 to help users tracing down problems
>>>>> related to proxies when locking/unlocking multiple files.
>>>>>
>>>>> * docs/release-notes/1.9.html
>>>>> (troubleshooting): Add new section including http-pipelining issue
>>>>> description.
>>>>> ]]]
>>>> Small correction to patchnotes:
>>>>
>>>> [[[
>>>> Add a troubleshooting section to 1.9 to help users tracing down problems
>>>> related to proxies when locking/unlocking multiple files.
>>>>
>>>> * docs/release-notes/1.9.html
>>>> (troubleshooting): Add new section including http-pipelining issue
>>>> description.
>>>> (news): Add link to new troubleshooting section.
>>>> ]]]
>>>>
>>> I think it's better to use term "HTTP pipelining" instead of
>>> "http-pipelining" on the website. Another wording suggestion: replace
>>> ".. protocols/applications involved in processing http-pipelining."
>>> with something like ".. protocols/applications involved in processing
>>> pipelined HTTP requests."
>> Thanks for the review Ivan, attached patch incorporates your changes and
>> also changes the section name (http-pipeline-issue ->
>> http-pipelining-issue).
>>
> Thanks for fixing that, but title still uses term 'http-pipelining":
> +<h3>Lock/Unlock errors related to http-pipelining
> + <a class="sectionlink" href="#http-pipelining-issue"
> + title="Link to this section">¶</a>
> +</h3>
Good spot. Fixed with the attached patch.
Regards,
Stefan
Re: [PATCH] troubleshooting http-pipelining for 1.9 release notes
Posted by Ivan Zhakov <iv...@visualsvn.com>.
On 16 May 2016 at 13:43, Stefan <lu...@posteo.de> wrote:
> On 5/16/2016 11:42, Ivan Zhakov wrote:
>> On 15 May 2016 at 03:02, Stefan <lu...@gmx.de> wrote:
>>> On 5/15/2016 01:13, Stefan wrote:
>>>> [[[
>>>> Add a troubleshooting section to 1.9 to help users tracing down problems
>>>> related to proxies when locking/unlocking multiple files.
>>>>
>>>> * docs/release-notes/1.9.html
>>>> (troubleshooting): Add new section including http-pipelining issue
>>>> description.
>>>> ]]]
>>>
>>> Small correction to patchnotes:
>>>
>>> [[[
>>> Add a troubleshooting section to 1.9 to help users tracing down problems
>>> related to proxies when locking/unlocking multiple files.
>>>
>>> * docs/release-notes/1.9.html
>>> (troubleshooting): Add new section including http-pipelining issue
>>> description.
>>> (news): Add link to new troubleshooting section.
>>> ]]]
>>>
>> I think it's better to use term "HTTP pipelining" instead of
>> "http-pipelining" on the website. Another wording suggestion: replace
>> ".. protocols/applications involved in processing http-pipelining."
>> with something like ".. protocols/applications involved in processing
>> pipelined HTTP requests."
>
> Thanks for the review Ivan, attached patch incorporates your changes and
> also changes the section name (http-pipeline-issue ->
> http-pipelining-issue).
>
Thanks for fixing that, but title still uses term 'http-pipelining":
+<h3>Lock/Unlock errors related to http-pipelining
+ <a class="sectionlink" href="#http-pipelining-issue"
+ title="Link to this section">¶</a>
+</h3>
--
Ivan Zhakov
Re: [PATCH] troubleshooting http-pipelining for 1.9 release notes
Posted by Stefan <lu...@posteo.de>.
On 5/16/2016 11:42, Ivan Zhakov wrote:
> On 15 May 2016 at 03:02, Stefan <lu...@gmx.de> wrote:
>> On 5/15/2016 01:13, Stefan wrote:
>>> [[[
>>> Add a troubleshooting section to 1.9 to help users tracing down problems
>>> related to proxies when locking/unlocking multiple files.
>>>
>>> * docs/release-notes/1.9.html
>>> (troubleshooting): Add new section including http-pipelining issue
>>> description.
>>> ]]]
>>
>> Small correction to patchnotes:
>>
>> [[[
>> Add a troubleshooting section to 1.9 to help users tracing down problems
>> related to proxies when locking/unlocking multiple files.
>>
>> * docs/release-notes/1.9.html
>> (troubleshooting): Add new section including http-pipelining issue
>> description.
>> (news): Add link to new troubleshooting section.
>> ]]]
>>
> I think it's better to use term "HTTP pipelining" instead of
> "http-pipelining" on the website. Another wording suggestion: replace
> ".. protocols/applications involved in processing http-pipelining."
> with something like ".. protocols/applications involved in processing
> pipelined HTTP requests."
Thanks for the review Ivan, attached patch incorporates your changes and
also changes the section name (http-pipeline-issue ->
http-pipelining-issue).
Regards,
Stefan
Re: [PATCH] troubleshooting http-pipelining for 1.9 release notes
Posted by Ivan Zhakov <iv...@visualsvn.com>.
On 15 May 2016 at 03:02, Stefan <lu...@gmx.de> wrote:
> On 5/15/2016 01:13, Stefan wrote:
>>
>> [[[
>> Add a troubleshooting section to 1.9 to help users tracing down problems
>> related to proxies when locking/unlocking multiple files.
>>
>> * docs/release-notes/1.9.html
>> (troubleshooting): Add new section including http-pipelining issue
>> description.
>> ]]]
>
>
> Small correction to patchnotes:
>
> [[[
> Add a troubleshooting section to 1.9 to help users tracing down problems
> related to proxies when locking/unlocking multiple files.
>
> * docs/release-notes/1.9.html
> (troubleshooting): Add new section including http-pipelining issue
> description.
> (news): Add link to new troubleshooting section.
> ]]]
>
I think it's better to use term "HTTP pipelining" instead of
"http-pipelining" on the website. Another wording suggestion: replace
".. protocols/applications involved in processing http-pipelining."
with something like ".. protocols/applications involved in processing
pipelined HTTP requests."
--
Ivan Zhakov
Re: [PATCH] troubleshooting http-pipelining for 1.9 release notes
Posted by Stefan <lu...@gmx.de>.
On 5/15/2016 01:13, Stefan wrote:
> [[[
> Add a troubleshooting section to 1.9 to help users tracing down
> problems related to proxies when locking/unlocking multiple files.
>
> * docs/release-notes/1.9.html
> (troubleshooting): Add new section including http-pipelining issue
> description.
> ]]]
Small correction to patchnotes:
[[[
Add a troubleshooting section to 1.9 to help users tracing down problems
related to proxies when locking/unlocking multiple files.
* docs/release-notes/1.9.html
(troubleshooting): Add new section including http-pipelining issue
description.
(news): Add link to new troubleshooting section.
]]]