You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Deivanayaki-S (via GitHub)" <gi...@apache.org> on 2025/04/15 10:42:53 UTC
[PR] [Relax] Refactor missing op check into shared utility for Torch frontends [tvm]
Deivanayaki-S opened a new pull request, #17840:
URL: https://github.com/apache/tvm/pull/17840
This PR refactors the logic for detecting unsupported ops by moving _check_unsupported_func_type into a shared utility in base_fx_graph_translator.py file. Previously, this logic was implemented separately in both from_fx and from_exported_program. By centralizing this function, we reduce duplication and ensure consistent missing op reporting across Torch frontends.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Relax] Refactor missing op check into shared utility for Torch frontends [tvm]
Posted by "mshr-h (via GitHub)" <gi...@apache.org>.
mshr-h commented on code in PR #17840:
URL: https://github.com/apache/tvm/pull/17840#discussion_r2045950879
##########
python/tvm/relax/frontend/torch/base_fx_graph_translator.py:
##########
@@ -103,6 +103,16 @@ def _retrieve_args(self, node):
else:
return node
+ def _check_unsupported_func_type(self, nodes):
Review Comment:
Please add type hint for nodes arg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Relax] Refactor missing op check into shared utility for Torch frontends [tvm]
Posted by "mshr-h (via GitHub)" <gi...@apache.org>.
mshr-h merged PR #17840:
URL: https://github.com/apache/tvm/pull/17840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Relax] Refactor missing op check into shared utility for Torch frontends [tvm]
Posted by "mshr-h (via GitHub)" <gi...@apache.org>.
mshr-h commented on PR #17840:
URL: https://github.com/apache/tvm/pull/17840#issuecomment-2808335049
LGTM! Thanks for the tidy up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Relax] Refactor missing op check into shared utility for Torch frontends [tvm]
Posted by "mshr-h (via GitHub)" <gi...@apache.org>.
mshr-h commented on code in PR #17840:
URL: https://github.com/apache/tvm/pull/17840#discussion_r2045950879
##########
python/tvm/relax/frontend/torch/base_fx_graph_translator.py:
##########
@@ -103,6 +103,16 @@ def _retrieve_args(self, node):
else:
return node
+ def _check_unsupported_func_type(self, nodes):
Review Comment:
Would be better to add type hint for nodes arg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org