You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@sling.apache.org by GitBox <gi...@apache.org> on 2022/04/06 13:41:17 UTC

[GitHub] [sling-org-apache-sling-distribution-journal] jose-correia commented on a diff in pull request #105: SLING-11181: Distinguish between permanent and transient package import failures and add metric on successful retries

jose-correia commented on code in PR #105:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/105#discussion_r843964997


##########
src/main/java/org/apache/sling/distribution/journal/shared/DistributionMetricsService.java:
##########
@@ -103,6 +101,8 @@
 
     private Counter invalidationProcessRequest;
 
+    private Meter successfullyRetriedPackageImports;

Review Comment:
   I see where I was wrong here. I was classifying `transient` as `an error that may still be fixed in the future`, when in reality it's `something that failed temporarily but was now successful`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org