You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/02 01:34:27 UTC

[GitHub] EronWright opened a new pull request #7393: [FLINK-9172][table][sql-client] - Support external catalogs in SQL-Client

EronWright opened a new pull request #7393: [FLINK-9172][table][sql-client] - Support external catalogs in SQL-Client
URL: https://github.com/apache/flink/pull/7393
 
 
   ## What is the purpose of the change
   
   _Based on #7392.  Please see commits prefixed with FLINK-9172._
   
   Adds support for catalogs to the SQL Client environment file, using descriptors.  For example, here's a sample catalog of type `taxi-data` being registered into `sql-client-defaults.yaml`:
   ```
   catalogs:
     - name: nyc
       type: taxi-data
       rides-file: /Users/david/stuff/flink-training/trainingData/nycTaxiRides.gz
       fares-file: /Users/david/stuff/flink-training/trainingData/nycTaxiFares.gz
   ```
   
   ## Brief change log
   [FLINK-9172] [table] [sql-client] - Support external catalogs in SQL-Client
   - add `CatalogEntry` to configuration types
   - enhance `Environment` to include `catalogs` in overall configuration
   - enhance `ExecutionContext` to register the configured catalogs
   - cleanup test-table-factories.yaml (references to non-existent classes)
   - update test dependencies of sql-client to include flink-table's test classes (for `TestExternalCatalogFactory`)
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   - enhanced unit test `DependencyTest` to test discovery of catalog factories
   - enhanced unit test `EnvironmentTest` to test merging of catalog configuration
   - enhanced unit test `EnvironmentTest` to test the detection of duplicate catalogs/tables/functions
   - enhanced unit test `ExecutionContextTest` to test external catalogs
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **yes**
     - If yes, how is the feature documented? not documented (see FLINK-11245)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services