You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 00:47:10 UTC
[PR] fix(i18n): localize DLQ page [rocketmq-dashboard]
yyqdbngt opened a new pull request, #3182:
URL: https://github.com/apache/rocketmq-dashboard/pull/3182
## Summary
The DLQ page (instance/dlq.tsx) only localized its page header; every other visible string was hard-coded zh, so the page stayed Chinese in English mode. This PR completes the page localization:
- Routes all visible copy through translation keys - table headers, action buttons (消息明细 / 重投消息 / 导出 / 重发), the filter bar, pagination totals, the retry modal (title, notice, labels, confirm), the message detail drawer (title, summary labels, export actions, range notice) and every toast / error fallback.
- Toasts and confirmations use parameterized keys (`dlq.rescanIncomplete`, `dlq.exportIncomplete`, `dlq.detailTitle`, `dlq.batchResend`, ...) so numbers, group names and topics interpolate in the active language.
- The module-level zh error constants were removed; each error path now passes its own localized fallback (`dlq.loadFailed`, `dlq.exportFailed`, ...).
- Reuses existing `common.actions`, `common.cancel` and `message.batchExport` keys.
## Why
The DLQ management flow is one of the most action-heavy Studio surfaces (scan/retry/export with many result states); leaving its feedback text in zh made en-mode operation confusing.
## Testing
- `tsc --noEmit` passes
- `eslint` - 0 errors (1 pre-existing fast-refresh warning on the exported `formatDateTime` helper)
- `vitest run DLQPage` - 18/18 tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(i18n): localize DLQ page [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3182: fix(i18n): localize DLQ page
URL: https://github.com/apache/rocketmq-dashboard/pull/3182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org