[jira] [Commented] (BEAM-9168) AppliedPTransform.from_runner_api fails on unexpected non-ParDo class with PAR_DO.urn

["Udi Meiri (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020686#comment-17020686 ] 

Udi Meiri commented on BEAM-9168:
---------------------------------

Possible options (I'm not that familiar with the semantics):
1. When replacing a ParDo with RunnerAPIPTransformHolder, change the URN as well (add a new one?).
2. Make a special-case RunnerAPIPTransformHolder class that also inherits from ParDo, or make  ParDo and RunnerAPIPTransformHolder inherit from the same base class and assert isinstance on that base.
3. Explicitly handle cases in the code where RunnerAPIPTransformHolder may come instead of ParDo.


> AppliedPTransform.from_runner_api fails on unexpected non-ParDo class with PAR_DO.urn
> -------------------------------------------------------------------------------------
>
>                 Key: BEAM-9168
>                 URL: https://issues.apache.org/jira/browse/BEAM-9168
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Udi Meiri
>            Assignee: Chamikara Madhusanka Jayalath
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> This is failing on a google-internal test.
> Unexpected class is apache_beam.transforms.core.RunnerAPIPTransformHolder.
> Failed assertion: https://github.com/apache/beam/blob/a59f897a64b0006ef3fcbe5a750d5f46499cfe61/sdks/python/apache_beam/pipeline.py#L1052-L1053



--
This message was sent by Atlassian Jira
(v8.3.4#803005)